Break long lines and cleanup some RefreshLinksJob checks

Change-Id: I02c007a2c2032610551d71ce1b21e03db5c011db

diff --git a/includes/jobqueue/jobs/RefreshLinksJob.php b/includes/jobqueue/jobs/RefreshLinksJob.php
index 25c3ba4..5f1a1a6 100644 (file)
--- a/includes/jobqueue/jobs/RefreshLinksJob.php
+++ b/includes/jobqueue/jobs/RefreshLinksJob.php
@@ -216,10 +216,10 @@ class RefreshLinksJob extends Job {
                        $title, null, !empty( $this->params['useRecursiveLinksUpdate'] ), $parserOutput );
                foreach ( $updates as $key => $update ) {
                        if ( $update instanceof LinksUpdate ) {
-                               if ( isset( $this->params['triggeredRecursive'] ) ) {
+                               if ( !empty( $this->params['triggeredRecursive'] ) ) {
                                        $update->setTriggeredRecursive();
                                }
-                               if ( isset( $this->params['triggeringUser'] ) && $this->params['triggeringUser'] ) {
+                               if ( !empty( $this->params['triggeringUser'] ) ) {
                                        $userInfo = $this->params['triggeringUser'];
                                        if ( $userInfo['userId'] ) {
                                                $user = User::newFromId( $userInfo['userId'] );
@@ -229,7 +229,7 @@ class RefreshLinksJob extends Job {
                                        }
                                        $update->setTriggeringUser( $user );
                                }
-                               if ( isset( $this->params['triggeringRevisionId'] ) && $this->params['triggeringRevisionId'] ) {
+                               if ( !empty( $this->params['triggeringRevisionId'] ) ) {
                                        $revision = Revision::newFromId( $this->params['triggeringRevisionId'] );
                                        if ( $revision === null ) {
                                                $revision = Revision::newFromId(