Merge "shell script fix using shellcheck lint"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Tue, 17 Jun 2014 14:18:23 +0000 (14:18 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Tue, 17 Jun 2014 14:18:23 +0000 (14:18 +0000)
maintenance/dev/includes/php.sh

index 7ce8794..3c5bef0 100644 (file)
@@ -4,7 +4,7 @@
 # and previous home directory location
 # The binary path is returned in $PHP if any
 
-for binary in $PHP `which php || true` "$DEV/php/bin/php" "$HOME/.mediawiki/php/bin/php" "$HOME/.mwphp/bin/php" ]; do
+for binary in $PHP $(which php || true) "$DEV/php/bin/php" "$HOME/.mediawiki/php/bin/php" "$HOME/.mwphp/bin/php" ]; do
        if [ -x "$binary" ]; then
                if "$binary" -r 'exit((int)!version_compare(PHP_VERSION, "5.4", ">="));'; then
                        PHP="$binary"