From de931602e5fab4040ad0a6df17a5304e70bfa1d8 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Bartosz=20Dziewo=C5=84ski?= Date: Tue, 5 Apr 2016 22:09:40 +0200 Subject: [PATCH] SpecialLog: Don't put assignment within another expression Change-Id: I0a0cd9ee0647e8778d2e835cc02c571a83b3a8c2 --- includes/specials/SpecialLog.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/includes/specials/SpecialLog.php b/includes/specials/SpecialLog.php index 7132207e24..85728ef0d7 100644 --- a/includes/specials/SpecialLog.php +++ b/includes/specials/SpecialLog.php @@ -147,7 +147,8 @@ class SpecialLog extends SpecialPage { private function parseParams( FormOptions $opts, $par ) { # Get parameters - $parms = explode( '/', ( $par = ( $par !== null ) ? $par : '' ) ); + $par = $par !== null ? $par : ''; + $parms = explode( '/', $par ); $symsForAll = [ '*', 'all' ]; if ( $parms[0] != '' && ( in_array( $par, $this->getConfig()->get( 'LogTypes' ) ) || in_array( $par, $symsForAll ) ) -- 2.20.1