From 7ac6ec988857322dff99b7d6b6f07d9e56f06b7e Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Thu, 29 Mar 2018 14:33:25 -0700 Subject: [PATCH] mediawiki.action.view.rightClickEdit: Remove redundanat dom-ready handler This file was wrapped in a jQuery() dom-ready callback, but it doesn't and shouldn't have that because it needlessly delays execution. I probably added because back then, using the first parameter of jQuery() was a common way for aliasing it to '$', but we use closures for that nowadays. Change-Id: I65768564ed556828fd193dfe99d11370fa745112 --- .../mediawiki.action.view.rightClickEdit.js | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/resources/src/mediawiki.action/mediawiki.action.view.rightClickEdit.js b/resources/src/mediawiki.action/mediawiki.action.view.rightClickEdit.js index ebd1ebccdf..35f948ebab 100644 --- a/resources/src/mediawiki.action/mediawiki.action.view.rightClickEdit.js +++ b/resources/src/mediawiki.action/mediawiki.action.view.rightClickEdit.js @@ -3,11 +3,12 @@ * When the user right-clicks in a heading, it will open the * edit screen. */ -jQuery( function ( $ ) { - // Select all h1-h6 elements that contain editsection links - // Don't use the ":has:(.mw-editsection a)" selector because it performs very bad. - // http://jsperf.com/jq-1-7-2-vs-jq-1-8-1-performance-of-mw-has/2 +( function ( $ ) { + // Trigger this when a contextmenu click on the page targets an h1-h6 element. + // This uses a delegate handler which 1) starts immediately instead of blocking + // response on dom-ready, and 2) selects and binds once instead of N times. $( document ).on( 'contextmenu', 'h1, h2, h3, h4, h5, h6', function ( e ) { + // Don't use ":has:(.mw-editsection a)" in the selector because it's slow. var $edit = $( this ).find( '.mw-editsection a' ); if ( !$edit.length ) { return; @@ -23,4 +24,4 @@ jQuery( function ( $ ) { $edit.get( 0 ).click(); } } ); -} ); +}( jQuery ) ); -- 2.20.1