From 3326188eca1b3278e5ed955b2503341e24def3c0 Mon Sep 17 00:00:00 2001
From: Trevor Parscal <tparscal@users.mediawiki.org>
Date: Wed, 6 Oct 2010 21:37:51 +0000
Subject: [PATCH] Created mediawiki.views.history and moved init functionality
 from mediawiki.legacy.history to it.

---
 includes/HistoryPage.php                       |  2 +-
 resources/Resources.php                        |  4 ++++
 resources/mediawiki/mediawiki.views.history.js |  7 +++++++
 skins/common/history.js                        | 17 -----------------
 4 files changed, 12 insertions(+), 18 deletions(-)
 create mode 100644 resources/mediawiki/mediawiki.views.history.js

diff --git a/includes/HistoryPage.php b/includes/HistoryPage.php
index 27c1153395..803935064b 100644
--- a/includes/HistoryPage.php
+++ b/includes/HistoryPage.php
@@ -81,7 +81,7 @@ class HistoryPage {
 		$wgOut->setRobotPolicy( 'noindex,nofollow' );
 		$wgOut->setSyndicated( true );
 		$wgOut->setFeedAppendQuery( 'action=history' );
-		$wgOut->addModules( array( 'mediawiki.legacy.history' ) );
+		$wgOut->addModules( array( 'mediawiki.legacy.history', 'mediawiki.views.history' ) );
 
 		$logPage = SpecialPage::getTitleFor( 'Log' );
 		$logLink = $this->skin->link(
diff --git a/resources/Resources.php b/resources/Resources.php
index 74a45bc6d9..add824b4cf 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -313,6 +313,10 @@ return array(
 	'mediawiki.specials.search' => new ResourceLoaderFileModule( array(
 		'scripts' => 'resources/mediawiki/mediawiki.specials.search.js',
 	) ),
+	'mediawiki.views.history' => new ResourceLoaderFileModule( array(
+		'scripts' => 'resources/mediawiki/mediawiki.views.history.js',
+		'dependencies' => 'mediawiki.legacy.history',
+	) ),
 	
 	/* MediaWiki Legacy */
 	
diff --git a/resources/mediawiki/mediawiki.views.history.js b/resources/mediawiki/mediawiki.views.history.js
new file mode 100644
index 0000000000..d85e5970e9
--- /dev/null
+++ b/resources/mediawiki/mediawiki.views.history.js
@@ -0,0 +1,7 @@
+/*
+ * JavaScript for History view
+ */
+
+// Replaces histrowinit
+$( '#pagehistory li input[name=diff], #pagehistory li input[name=oldid]' ).click( diffcheck );
+diffcheck();
\ No newline at end of file
diff --git a/skins/common/history.js b/skins/common/history.js
index 9bc8f4d8cb..9da0a75118 100644
--- a/skins/common/history.js
+++ b/skins/common/history.js
@@ -75,20 +75,3 @@ window.diffcheck = function() {
 	}
 	return true;
 }
-
-// Attach event handlers to the input elements on history page
-window.histrowinit = function() {
-	var hf = document.getElementById('pagehistory');
-	if (!hf) return;
-	var lis = hf.getElementsByTagName('li');
-	for (var i = 0; i < lis.length; i++) {
-		var inputs = historyRadios(lis[i]);
-		if (inputs[0] && inputs[1]) {
-			inputs[0].onclick = diffcheck;
-			inputs[1].onclick = diffcheck;
-		}
-	}
-	diffcheck();
-}
-
-hookEvent("load", histrowinit);
-- 
2.20.1