jenkins-bot [Thu, 1 Jun 2017 17:38:09 +0000 (17:38 +0000)]
Merge "EditPage: Restore the old 'id' attributes in OOUI mode"
jenkins-bot [Thu, 1 Jun 2017 17:37:28 +0000 (17:37 +0000)]
Merge "Refactor registration of OOjs UI resource modules"
Bartosz Dziewoński [Sat, 20 May 2017 10:23:18 +0000 (12:23 +0200)]
EditPage: Restore the old 'id' attributes in OOUI mode
For compatibility with old scripts and extensions, we want the legacy
'id' on the `<input>` elements. There is really no good justification
for breaking all of them when we can easily support it.
The actual `<input>` elements have their ids back: 'wpSummary',
'wpSave', 'wpPreview', 'wpDiff', 'wpMinoredit', 'wpWatchthis'.
The widgets (wrapped `<div>`s) now use ids with 'Widget' appended.
Bug: T165854
Change-Id: I4d23f57fd0cda4b8539ffb17a2a19ecd822e077a
jenkins-bot [Thu, 1 Jun 2017 15:43:10 +0000 (15:43 +0000)]
Merge "mediawiki.special/mediawiki.special.apisandbox: Use 'trash' icon which still exists"
jenkins-bot [Thu, 1 Jun 2017 15:43:06 +0000 (15:43 +0000)]
Merge "mediawiki.widgets.datetime/DateTimeInputWidget: Use 'trash' icon which still exists"
James D. Forrester [Wed, 31 May 2017 23:44:24 +0000 (16:44 -0700)]
mediawiki.special/mediawiki.special.apisandbox: Use 'trash' icon which still exists
Bug: T166730
Change-Id: I38c526d2660aae8c221f74ce2927c2e338c01be1
James D. Forrester [Wed, 31 May 2017 23:42:20 +0000 (16:42 -0700)]
mediawiki.widgets.datetime/DateTimeInputWidget: Use 'trash' icon which still exists
Bug: T166730
Change-Id: I30a833ee93d49bb9480f5cfed332a9aa8e306713
Bartosz Dziewoński [Fri, 17 Mar 2017 01:32:59 +0000 (02:32 +0100)]
Refactor registration of OOjs UI resource modules
includes/resourceloader/ResourceLoaderOOUIModule.php
* New trait centralizing some logic for dealing with OOjs UI themes,
previously duplicated in OutputPage, ResourcesOOUI.php and
ResourceLoaderOOUIImageModule.
* Follow-up change I74362f0fc215b26f1f104ce7bdbbac1e106736ad uses this
as a base to allow skins/extensions to define new OOjs UI themes.
resources/Resources.php
resources/ResourcesOOUI.php
includes/resourceloader/ResourceLoader.php
* OOjs UI resource module definitions are moved back to their rightly
place in Resources.php. They are again (almost) normal and static.
* Theme-specific logic is now handled by the module code, definitions
only specify 'themeScripts'/'themeStyles'/'themeImages'.
* ResourcesOOUI.php is deleted and no longer loaded by ResourceLoader.
includes/resourceloader/ResourceLoaderOOUIFileModule.php
includes/resourceloader/ResourceLoaderOOUIImageModule.php
* Glue code previously existing in ResourcesOOUI.php now lives here.
* Use the ResourceLoaderOOUIModule trait to avoid code duplication.
Change-Id: I39cc2a735d9625c87bf4ede6f5fb0ec441d47dcc
Bartosz Dziewoński [Thu, 1 Jun 2017 15:00:18 +0000 (17:00 +0200)]
OutputPage: Do not try to load non-existent 'oojs-ui.styles.icons' module
Follow-up to
0f2795d5bacda8d573dc1478fb2ea9d8f2ac4432.
Change-Id: I461fb179a494e00a14116361700020da577db494
jenkins-bot [Thu, 1 Jun 2017 05:21:30 +0000 (05:21 +0000)]
Merge "Apply $wgShellLocale in Setup.php"
Brad Jorsch [Tue, 9 May 2017 16:12:41 +0000 (12:12 -0400)]
Apply $wgShellLocale in Setup.php
While most of MediaWiki ignores the shell's/C library's locale setting,
there are some things other than shell execs that use it (e.g. the
luasandbox PHP extension).
To provide a consistent environment, set the locale in Setup.php instead
of letting it be changed mid-request depending on whether something else
happened to have called certain functions.
Bug: T107128
Change-Id: I02943803d26d5b1b3ac00ef9216f69cdfa149585
jenkins-bot [Thu, 1 Jun 2017 01:01:36 +0000 (01:01 +0000)]
Merge "Follow-up
7668836236: oojs-ui.styles.icons is now gone"
James D. Forrester [Thu, 1 Jun 2017 00:47:09 +0000 (17:47 -0700)]
Follow-up
7668836236: oojs-ui.styles.icons is now gone
Change-Id: If7fcde0cebe74998a31ca1e88f1d8d90ee1b1b80
jenkins-bot [Thu, 1 Jun 2017 00:34:06 +0000 (00:34 +0000)]
Merge "RCFilters UI: Make monobook override of the 'checkmark' more specific"
Alex Monk [Tue, 27 Sep 2016 00:26:05 +0000 (01:26 +0100)]
MWExceptionRenderer::useOutputPage: Don't bother if we have no Title context
Change-Id: Ieb6d682a9f2fb4def4c01908ccd035fcce2e1895
jenkins-bot [Wed, 31 May 2017 20:12:46 +0000 (20:12 +0000)]
Merge "Update OOjs UI to v0.22.1"
Translation updater bot [Wed, 31 May 2017 19:53:56 +0000 (21:53 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I22cc50259ac61e5e2e4c7f7cce190275713c641a
James D. Forrester [Wed, 31 May 2017 19:26:04 +0000 (12:26 -0700)]
Update OOjs UI to v0.22.1
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.22.1
Depends-On: I4ee36222e67697a7290a1ac94788676e476ca768
Change-Id: I964a298018d837b1a05a1608a81ca0544f34a2c8
Mark A. Hershberger [Wed, 31 May 2017 02:16:22 +0000 (22:16 -0400)]
Update documentation URL
Change-Id: I6a32689c5d224674fe96ad631b073f9efba47e3f
jenkins-bot [Tue, 30 May 2017 23:37:33 +0000 (23:37 +0000)]
Merge "Update OOjs to v2.1.0"
jenkins-bot [Tue, 30 May 2017 23:26:53 +0000 (23:26 +0000)]
Merge "RCFilters UI: Compare states instead of params when switching URL"
James D. Forrester [Tue, 30 May 2017 23:23:58 +0000 (16:23 -0700)]
Update OOjs to v2.1.0
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJS/browse/master/History.md;v2.1.0
Change-Id: I63fb9c2145e1c3e63ce1acf5f020e9208ca21f04
jenkins-bot [Tue, 30 May 2017 22:46:08 +0000 (22:46 +0000)]
Merge "RCFilters: Minimize url string"
jenkins-bot [Tue, 30 May 2017 22:14:05 +0000 (22:14 +0000)]
Merge "objectcache: respect process cache in getMultiWithSetCallback()"
jenkins-bot [Tue, 30 May 2017 21:12:33 +0000 (21:12 +0000)]
Merge "RCFilters: Hide server-side 'empty results' message"
jenkins-bot [Tue, 30 May 2017 21:06:05 +0000 (21:06 +0000)]
Merge "RCFilters: Blur input on 'escape' key"
jenkins-bot [Tue, 30 May 2017 21:03:16 +0000 (21:03 +0000)]
Merge "RCFilters: Unify 'highlight' and 'selected' items"
jenkins-bot [Tue, 30 May 2017 21:02:40 +0000 (21:02 +0000)]
Merge "Show total number of autoblocks on top of Special:AutoblockList"
jenkins-bot [Tue, 30 May 2017 20:58:35 +0000 (20:58 +0000)]
Merge "Use PHP DateInputWidget in Contribs and use for range filtering"
Moriel Schottlender [Tue, 30 May 2017 11:29:35 +0000 (14:29 +0300)]
RCFilters: Unify 'highlight' and 'selected' items
When moving with the arrows, we don't want a distinction between
the 'selected' and 'highlighted' states, since those don't quite
make sense in RCFilters system. We unify those by always using
'selected' state; this also means that when searching AND when
opening the popup, the first item is 'selected' so the user can
hit 'enter' and add it in, or hit the up/down arrow keys and
move up and down in the list.
Bug: T159768
Change-Id: Ife62e6e7241b96d846d8c5851b173a09a1f45fa4
Niharika Kohli [Fri, 26 May 2017 17:13:19 +0000 (22:43 +0530)]
Show total number of autoblocks on top of Special:AutoblockList
Bug: T163172
Change-Id: I51b1b7675c2f4ed68ccb725230ffecf3583cf65f
Translation updater bot [Tue, 30 May 2017 19:56:06 +0000 (21:56 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I07c848f6c5e0fb9267b5dd1e0900de899f88c911
jenkins-bot [Tue, 30 May 2017 19:10:53 +0000 (19:10 +0000)]
Merge "RCFilters UI: Migrate FloatingMenuSelectWidget to MenuSelectWidget"
jenkins-bot [Tue, 30 May 2017 19:10:49 +0000 (19:10 +0000)]
Merge "RCFilters: Add top spacing between RCFilters and top content"
jenkins-bot [Tue, 30 May 2017 19:01:45 +0000 (19:01 +0000)]
Merge "Parser: Better debugging of lock errors ("Did you call Parser::parse recursively?")"
jenkins-bot [Tue, 30 May 2017 18:22:42 +0000 (18:22 +0000)]
Merge "Don't fill in the skin's search box on Special:Search"
jenkins-bot [Tue, 30 May 2017 17:48:17 +0000 (17:48 +0000)]
Merge "EditPage: Fix passing the save/publish button label to other messages"
jenkins-bot [Tue, 30 May 2017 13:28:47 +0000 (13:28 +0000)]
Merge "Avoid duplicate refreshCounts() updates"
Moriel Schottlender [Tue, 30 May 2017 11:37:04 +0000 (14:37 +0300)]
RCFilters: Blur input on 'escape' key
Bug: T161493
Change-Id: Iae8f1e5dc5653f04708da74e137e35bd46cbf232
Moriel Schottlender [Tue, 30 May 2017 10:55:59 +0000 (13:55 +0300)]
RCFilters UI: Migrate FloatingMenuSelectWidget to MenuSelectWidget
FloatingMenuSelectWidget has been deprecated in OOUI, moving to the
MenuSelectWidget widget instead.
Change-Id: Id4e5e4c551d50242ce19837c2e958b9773139906
Moriel Schottlender [Tue, 30 May 2017 09:33:28 +0000 (12:33 +0300)]
RCFilters: Add top spacing between RCFilters and top content
Bug: T165095
Change-Id: I0cfafe700fd6548a27d510a5f624f7728327b490
jenkins-bot [Tue, 30 May 2017 03:41:13 +0000 (03:41 +0000)]
Merge "Refactor Statsd classes to enable null collector to work."
Stanislav Malyshev [Fri, 26 May 2017 00:23:44 +0000 (17:23 -0700)]
Refactor Statsd classes to enable null collector to work.
The following changes are added:
- Created MediawikiStatsdDataFactory interface
- Added hasData() method to see if there are any data to send
- Added getData() method to fetch data
- Made service infrastructure use MediawikiStatsdDataFactory interface
- Made wfLogProfilingData() use MediawikiStatsdDataFactory interface
- Added capability to enable/disable buffering collector
Bug: T166354
Change-Id: I2874175647e987996a9a399829b3319674471aaa
L10n-bot [Mon, 29 May 2017 20:03:40 +0000 (20:03 +0000)]
Merge "Localisation updates from https://translatewiki.net."
Translation updater bot [Mon, 29 May 2017 20:03:28 +0000 (22:03 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I2ac1e5176315ced37d1067e1616a3447592429f0
jenkins-bot [Mon, 29 May 2017 20:03:00 +0000 (20:03 +0000)]
Merge "Do not output invalid links for deleted names on Special:Contributions"
Bartosz Dziewoński [Mon, 29 May 2017 18:46:24 +0000 (20:46 +0200)]
EditPage: Fix passing the save/publish button label to other messages
We were passing the message key, instead of the message text.
Follow-up to
44f596231397eb9ea2a5fe345c79ae952d6a1247.
Bug: T166478
Change-Id: Iaf33b0e6fba71ebf1130fc067210ed49c1b06011
Geoffrey Mon [Mon, 12 Dec 2016 14:26:15 +0000 (09:26 -0500)]
Use PHP DateInputWidget in Contribs and use for range filtering
* Add two DateInputWidgets to Special:Contributions, one for start and
one for end
** If start input is empty but end input is not, display edits up to end
input, and vice versa
** If both inputs are specified, display edits between the two dates
** If both inputs are empty, no date range is used
* Legacy options (year=/month=) are converted to use for the end
timestamp, so URLs with them should still work.
* Unit tests!
Bug: T120733
Change-Id: Id15f2b2ce2954fe98dfbbb7b0e86c0e4e5713f5e
Bartosz Dziewoński [Mon, 29 May 2017 16:22:33 +0000 (18:22 +0200)]
mw.widgets.DateInputWidget: Remove accidental 'user-select' on PHP widget's input
This is only meant to apply to the JS widget's handle.
Also moved another block of CSS only meant to apply to the JS widget.
This wasn't causing any actual issues though.
Bug: T166416
Change-Id: I6e58a38a1d5a8fb4b581734b02cc4f12640b4a75
jenkins-bot [Mon, 29 May 2017 15:44:50 +0000 (15:44 +0000)]
Merge "Making the default toggle look clickable again"
jenkins-bot [Mon, 29 May 2017 15:23:11 +0000 (15:23 +0000)]
Merge "ImagePage: Do not parse message 'imgmultipageprev'"
jenkins-bot [Mon, 29 May 2017 14:50:48 +0000 (14:50 +0000)]
Merge "Return 400 on invalid CSP reports"
Bartosz Dziewoński [Mon, 29 May 2017 13:22:03 +0000 (15:22 +0200)]
ImagePage: Do not parse message 'imgmultipageprev'
This message is used as alt text for an image thumbnail, and so it
can't contain HTML tags anyway. This matches the 'imgmultipagenext'
message now. (This inconsistency has been present ever since the
feature was introduced in 2006:
7f7e79022bfd421e49084b089e74c7a16b77bc03.)
Due to using OutputPage::parse() instead of Message::parse(), an
incorrect `<div class="mw-parser-output">` wrapper was also being added.
Bug: T166508
Change-Id: I092887cc91e2c800685d4e55177aed814bb3fce9
jenkins-bot [Mon, 29 May 2017 10:54:40 +0000 (10:54 +0000)]
Merge "Make running Selenium tests using Sauce Labs easy"
Moriel Schottlender [Mon, 29 May 2017 09:49:17 +0000 (12:49 +0300)]
RCFilters: Hide server-side 'empty results' message
RCFilters uses its own empty-results message that also relates to
the reason of why the results are empty (in case of conflicts, etc).
We want to make sure the server-side message is hidden and gone
while we load, and manage the empty-results message ourselves.
Bug: T163577
Change-Id: I1d0f07068653f369dea181f5c4f9964fd6d7cd58
Moriel Schottlender [Mon, 29 May 2017 08:22:40 +0000 (11:22 +0300)]
RCFilters UI: Make monobook override of the 'checkmark' more specific
Bug: T165444
Bug: T165446
Change-Id: I6412fb84767332259955462e53bde8dffe17e905
Depends-On: Ibe4b4fc92de1a864059d9cd37168c7ef33b6d874
jenkins-bot [Mon, 29 May 2017 08:03:56 +0000 (08:03 +0000)]
Merge "RCFilters: Dismiss Apex' insistence to add checkmark to optionWidgets"
jenkins-bot [Mon, 29 May 2017 06:57:46 +0000 (06:57 +0000)]
Merge "Swap default page title for Special:BlankPage in Spanish"
Moriel Schottlender [Sun, 28 May 2017 20:09:39 +0000 (23:09 +0300)]
RCFilters: Dismiss Apex' insistence to add checkmark to optionWidgets
Bug: T165446
Change-Id: I8188b34675e7e49f3603e7b7154e4e0800e94c37
Translation updater bot [Sun, 28 May 2017 19:54:06 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Id10e621f71f0522f6dcb16369cca50d95abf33dc
Moriel Schottlender [Fri, 26 May 2017 20:45:09 +0000 (23:45 +0300)]
RCFilters UI: Compare states instead of params when switching URL
For empty url (initial load) and for cases where the URL is
minimized (upcoming) the method should check filter states
to recognize whether there's a difference between current and
requested URL.
Bug: T166347
Change-Id: I9dcc82ce7dbc0ad7c6cf3169cee7269234c95298
Jesús Martínez Novo [Sun, 28 May 2017 17:23:58 +0000 (19:23 +0200)]
Swap default page title for Special:BlankPage in Spanish
"Blanquear página" is a wrong translation in this context.
"Blanquear" is using "blank" as the verb and means "to blank a page",
but this page should translate "blank" as an adjective "this page is blank"
This was already in the list of aliases so I've swapped them so the correct
one is first and is picked as the default page name in wikis with Spanish
content language.
Change-Id: I29c2b02937878c09df09460eedbc5df697e51e34
Moriel Schottlender [Mon, 15 May 2017 21:43:33 +0000 (14:43 -0700)]
RCFilters: Minimize url string
In order to minimize the URL query, we use a base representation of the
parameters as if they were all '0' or '' and internally expand on it.
- Only display parameters with a value that is not empty or '0' in the
URI. Any parameter that is missing from the URI is presumed to have
an empty value.
- Stop pushing defaultParameters everywhere. Default parameters should
only be considered either on load (when/if needed) or when the user
actively requests for them.
- Minimize parameters to the URL, and expand when reading into the model.
Similar to using base filters, we can use a representation of base
parameters to make the URL small but the representation all-encompassing.
Bug: T165445
Change-Id: I1d21c38137fde51fcd561e2de24592722bf532c6
jenkins-bot [Sat, 27 May 2017 20:05:57 +0000 (20:05 +0000)]
Merge "Add fr (French) as fallback for kbp (Kabiyè)"
Translation updater bot [Sat, 27 May 2017 20:04:18 +0000 (22:04 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I62626aff6dbf017f7fb0fa3b6d33d3cc9ae2c249
jenkins-bot [Sat, 27 May 2017 18:40:10 +0000 (18:40 +0000)]
Merge "Fix incomplete Language::getDatePreferences() documentation"
Moritz Oberhauser [Sat, 27 May 2017 11:20:35 +0000 (13:20 +0200)]
Making the default toggle look clickable again
The toggle should now look same same prior to the premade toggle changes. The brackets are not part of the link, but the text inbetween. The link has no href property, so the toggle action is still triggered.
Bug: T166359
Change-Id: I38698cd66d380626728eae9b8a9da1e465b207a6
jenkins-bot [Sat, 27 May 2017 03:40:32 +0000 (03:40 +0000)]
Merge "wfIsBadImage: Avoid deprecated wfMemcKey()"
jenkins-bot [Sat, 27 May 2017 03:40:14 +0000 (03:40 +0000)]
Merge "User: Avoid deprecated wfMemcKey()"
jenkins-bot [Sat, 27 May 2017 03:40:10 +0000 (03:40 +0000)]
Merge "parser: Avoid deprecated wfMemcKey()"
jenkins-bot [Sat, 27 May 2017 00:16:07 +0000 (00:16 +0000)]
Merge "LanguageConverter: Avoid deprecated wfMemcKey()"
jenkins-bot [Sat, 27 May 2017 00:16:03 +0000 (00:16 +0000)]
Merge "CachingSiteStore: Avoid deprecated wfMemcKey()"
jenkins-bot [Fri, 26 May 2017 23:53:00 +0000 (23:53 +0000)]
Merge "User: Avoid deprecated wfMemcKey()"
jenkins-bot [Fri, 26 May 2017 23:48:29 +0000 (23:48 +0000)]
Merge "UploadBase: Avoid deprecated wfMemcKey()"
jenkins-bot [Fri, 26 May 2017 23:07:27 +0000 (23:07 +0000)]
Merge "SpecialVersion: Avoid deprecated wfMemcKey()"
jenkins-bot [Fri, 26 May 2017 23:06:19 +0000 (23:06 +0000)]
Merge "page: Avoid deprecated wfMemcKey()"
jenkins-bot [Fri, 26 May 2017 23:06:14 +0000 (23:06 +0000)]
Merge "SiteStatsUpdate: Avoid deprecated wfMemcKey()"
jenkins-bot [Fri, 26 May 2017 23:04:35 +0000 (23:04 +0000)]
Merge "SiteStats: Avoid deprecated wfMemcKey()"
jenkins-bot [Fri, 26 May 2017 23:01:55 +0000 (23:01 +0000)]
Merge "Block: Avoid deprecated wfMemcKey()"
Aaron Schulz [Fri, 26 May 2017 18:12:07 +0000 (11:12 -0700)]
objectcache: respect process cache in getMultiWithSetCallback()
Backend cache queries are now avoided if they are fresh in memory.
Also factor out some code into private methods for clarity.
Change-Id: Ib343fde3dbf63f39e8cb09eca6278811a7d9738b
jenkins-bot [Fri, 26 May 2017 22:14:01 +0000 (22:14 +0000)]
Merge "objectcache: fix cache warmup bug in getMultiWithSetCallback()"
jenkins-bot [Fri, 26 May 2017 22:12:35 +0000 (22:12 +0000)]
Merge "Fix TextPassDumperDatabaseTest::testPrefetchPlain postgres failures"
Aaron Schulz [Fri, 26 May 2017 21:38:07 +0000 (14:38 -0700)]
Fix TextPassDumperDatabaseTest::testPrefetchPlain postgres failures
The insertId() method was returning a string, which caused the
returnValueMap not to trigger due to int/string mismatches.
Also add sanity integer cast to WikiPage::insertOn().
Added a few more type docs.
Bug: T75174
Change-Id: Id1090f3e3d0481272a3d13c3af8f2588f06dc912
L10n-bot [Fri, 26 May 2017 20:06:20 +0000 (20:06 +0000)]
Merge "Revert "Localisation updates from https://translatewiki.net.""
Raimond Spekking [Fri, 26 May 2017 20:05:36 +0000 (20:05 +0000)]
Revert "Localisation updates from https://translatewiki.net."
Overwrites https://gerrit.wikimedia.org/r/#/c/353696/
This reverts commit
d47331a707a00ec0b7ffab1f9fdcb02d70975898.
Change-Id: I2db66a32c3eb1baef84c0abe797ebb9bc052670d
L10n-bot [Fri, 26 May 2017 19:58:44 +0000 (19:58 +0000)]
Merge "Localisation updates from https://translatewiki.net."
Translation updater bot [Fri, 26 May 2017 19:58:32 +0000 (21:58 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Iabf3bace8c57875133115d1faab44be656807657
jenkins-bot [Fri, 26 May 2017 19:58:31 +0000 (19:58 +0000)]
Merge "RCFilters: Style saved links option menu"
jenkins-bot [Fri, 26 May 2017 19:54:54 +0000 (19:54 +0000)]
Merge "RCFilters: Style the Saved Links placeholder and add a title"
jenkins-bot [Fri, 26 May 2017 15:39:35 +0000 (15:39 +0000)]
Merge "resourceloader: Ensure user.styles and site.styles having their own request"
Kevin Israel [Mon, 27 Feb 2017 01:19:25 +0000 (20:19 -0500)]
WebStart.php: Update the file's doc comment
The doc comment did not reflect the removal of MW_NO_SETUP in
edc9edbc769b570c, or the fact that Setup.php no longer loads
AutoLoader.php or GlobalFunctions.php.
Change-Id: I19a12fd83e369828b9e08176ddf3bfca16aae465
Timo Tijhof [Fri, 12 May 2017 22:26:36 +0000 (23:26 +0100)]
resourceloader: Ensure user.styles and site.styles having their own request
Regardless of whether other modules exist with group=user or group=site,
these two modules in particular must always be in their own request for
legacy reasons.
This has already always been the case because even in the few cases where
an extension uses this group (eg. MobileFrontend's custom site module) it
would load it instead of another module in that group, never at the same
time. There is one notable exception, which is GlobalCssJs. However the
ext.globalCssJs.user.styles module is usually served from another wiki
which is why that went unnoticed as well. This commit fixes that so that
even if you're viewing a page on the central wiki, the modules are still
in separate requests.
Aside from this one existing edge case, there is also need to add
group=site to gadgets by default so that they load after the DynamicStyles
marker instead of before, which is currently causing problems with the
cascading order (gadget apply before core and skin styles due to being
in the same request group and alphabetically sorting before them).
Semantically, the appropiate solution is group=site, but this wasn't
possible due to core putting "all" group=site modules in the same request
(under the assumption there is only one such module). This commit removes
that fragile assumption.
Bug: T147667
Change-Id: I9eb725c083124d22a9af3bf3d075ade6f3b970a3
Filippo Giunchedi [Fri, 26 May 2017 10:19:56 +0000 (12:19 +0200)]
Return 400 on invalid CSP reports
Not really a server error since there's nothing we can do about invalid
user-provided data.
Bug: T166229
Change-Id: I87a7be32ae7e80c112be556bc13db19f11e614ca
Federico Leva [Fri, 26 May 2017 07:12:57 +0000 (09:12 +0200)]
Add fr (French) as fallback for kbp (Kabiyè)
Follow-up to
03e306dd3bc72fd134375a60ecd8b88541ea2973
Change-Id: I06f9788eb16cb1b40faac33aaa75d56e8075bc49
Aaron Schulz [Thu, 25 May 2017 00:59:50 +0000 (17:59 -0700)]
objectcache: fix cache warmup bug in getMultiWithSetCallback()
The warmup cache was not properly prefixed and was also using the entity
IDs instead of the cache keys. Thus, it effectively just wasted a
getMulti() query and resulted in the usual separate GETs anyway.
Added some unit tests for this.
Change-Id: I75b7a31214b515511856f9d95db32e8881d80ccc
jenkins-bot [Thu, 25 May 2017 21:37:15 +0000 (21:37 +0000)]
Merge "jquery.makeCollapsible: Restore considering empty <a> as part of toggle"
jenkins-bot [Thu, 25 May 2017 21:25:01 +0000 (21:25 +0000)]
Merge "Add missing ampersand to getMultiWithSetCallback() callback"
Timo Tijhof [Thu, 25 May 2017 21:08:24 +0000 (23:08 +0200)]
jquery.makeCollapsible: Restore considering empty <a> as part of toggle
Before
2d95d36a8e, clicks on links inside toggles with non-empty
targets that are not '#', were ignored ("pass through") since they
are not intended for the toggle.
In
2d95d36a8e, this was simplified to ignoring clicks from all <a>
elements inside toggles. However this ignored too much as links
without 'href' attribute are also sometimes used inside toggles
to look like links and have no href-target, which means clicking
them does nothing and is in fact meant to toggle the element.
Restore previous behaviour and restore previous test + add a new
test for this specific case.
Bug: T166298
Change-Id: Ia3a0648f809f94be0977a83b469fbd184aa72aff
jenkins-bot [Thu, 25 May 2017 21:14:56 +0000 (21:14 +0000)]
Merge "Revert "Creating new WMF 1.30.0-wmf.2 branch""
jenkins-bot [Thu, 25 May 2017 21:04:35 +0000 (21:04 +0000)]
Merge "Add kbp language code"