jenkins-bot [Tue, 27 Jun 2017 22:35:52 +0000 (22:35 +0000)]
Merge "resourceloader: Add basic tests for getScript() and buildContent()"
jenkins-bot [Tue, 27 Jun 2017 22:19:19 +0000 (22:19 +0000)]
Merge "benchmarks: Add reporting of resource usage"
jenkins-bot [Tue, 27 Jun 2017 22:10:51 +0000 (22:10 +0000)]
Merge "Fix typo in comment."
jenkins-bot [Tue, 27 Jun 2017 22:08:42 +0000 (22:08 +0000)]
Merge "tests: Use TestingAccessWrapper to reload LanguageConverter tables"
jenkins-bot [Tue, 27 Jun 2017 22:08:39 +0000 (22:08 +0000)]
Merge "tests: Reset LanguageConverter conversion tables between test cases"
jenkins-bot [Tue, 27 Jun 2017 21:15:10 +0000 (21:15 +0000)]
Merge "RCFilters: Move legend into results (both js and nojs output)"
C. Scott Ananian [Tue, 27 Jun 2017 21:11:31 +0000 (17:11 -0400)]
Fix typo in comment.
Change-Id: Ia656c55ca22fa30b5a911b8cb3a6218c916d3316
C. Scott Ananian [Tue, 27 Jun 2017 21:09:12 +0000 (17:09 -0400)]
tests: Use TestingAccessWrapper to reload LanguageConverter tables
Make the LanguageConverter::reloadTables method actually private,
and use the TestingAccessWrapper to call it when running parser tests.
Follow-up to I65736520cd04bfe8949b29ade07338a6e1b88a4d.
Change-Id: I43b81b8fef6441ad50b858ff7757732ecb5eef91
jenkins-bot [Tue, 27 Jun 2017 20:07:08 +0000 (20:07 +0000)]
Merge "Fix border-radii on FilterTagMultiselectWidget"
jenkins-bot [Tue, 27 Jun 2017 20:01:28 +0000 (20:01 +0000)]
Merge "RangeChronologicalPager: Don't clear $offset when $this->rangeConds is set"
Translation updater bot [Tue, 27 Jun 2017 19:54:39 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I27707dbaae9edf04ef400300801c339a22df3eb3
jenkins-bot [Tue, 27 Jun 2017 19:47:39 +0000 (19:47 +0000)]
Merge "RCFilters: Always use the filled bookmark icon (unClip)"
jenkins-bot [Tue, 27 Jun 2017 19:47:04 +0000 (19:47 +0000)]
Merge "RCFilters: Simplify "Saved filter settings" to "Saved filters""
jenkins-bot [Tue, 27 Jun 2017 19:20:54 +0000 (19:20 +0000)]
Merge "Downgrade 'found writes/callbacks pending.' from error to info"
Moriel Schottlender [Tue, 27 Jun 2017 18:19:31 +0000 (11:19 -0700)]
RCFilters: Move legend into results (both js and nojs output)
Move the legend from the fieldset area to the results area.
Bug: T168043
Change-Id: I40454b194fe3975d8d4ac13d96774bfa5b5d5a46
jenkins-bot [Tue, 27 Jun 2017 19:14:08 +0000 (19:14 +0000)]
Merge "RCFilters: Make extra filters footer non-sticky"
jenkins-bot [Tue, 27 Jun 2017 19:10:51 +0000 (19:10 +0000)]
Merge "RCFilters: Correct default view title"
jenkins-bot [Tue, 27 Jun 2017 19:08:59 +0000 (19:08 +0000)]
Merge "RCFilters: Remove <hr> if extension table is empty"
Moriel Schottlender [Tue, 27 Jun 2017 00:17:19 +0000 (17:17 -0700)]
RCFilters: Make extra filters footer non-sticky
Bug: T168851
Change-Id: I504847e4b07d473786a4026b053a55ae460897e8
Aaron Schulz [Tue, 27 Jun 2017 18:31:35 +0000 (11:31 -0700)]
Avoid checking double-prefixed table names in mysql tableExists()
Change-Id: I9d91a5305227171d0776ffa443d4e538fbe1b15f
jenkins-bot [Tue, 27 Jun 2017 13:18:10 +0000 (13:18 +0000)]
Merge "resourceloader: Add @covers for stripBom and makeModuleResponse tests"
jenkins-bot [Tue, 27 Jun 2017 13:18:07 +0000 (13:18 +0000)]
Merge "resourceloader: Add @covers for stripBom() test"
jenkins-bot [Tue, 27 Jun 2017 13:16:46 +0000 (13:16 +0000)]
Merge "resourceloader: Complete test coverage for FileModule::getTemplates()"
jenkins-bot [Tue, 27 Jun 2017 08:57:28 +0000 (08:57 +0000)]
Merge "build: Prepare for mediawiki/mediawiki-codesniffer to 0.9.0"
jenkins-bot [Tue, 27 Jun 2017 06:02:23 +0000 (06:02 +0000)]
Merge "Remove "@author Bryan Davis" and "Brad Jorsch" annotations"
Timo Tijhof [Tue, 27 Jun 2017 05:04:21 +0000 (22:04 -0700)]
resourceloader: Add basic tests for getScript() and buildContent()
Bug: T162719
Change-Id: I37d64da77682adfef61e78033d639b623d7c9c2b
Timo Tijhof [Tue, 27 Jun 2017 04:44:11 +0000 (21:44 -0700)]
resourceloader: Add @covers for stripBom and makeModuleResponse tests
Change-Id: Ie32178cdd03a79a0ab871122acf081c65e5a9f4d
Timo Tijhof [Tue, 27 Jun 2017 04:44:11 +0000 (21:44 -0700)]
resourceloader: Add @covers for stripBom() test
Change-Id: I3403b6617121f5965ef7aa125eb2528db7c89e95
Timo Tijhof [Tue, 27 Jun 2017 04:21:36 +0000 (21:21 -0700)]
resourceloader: Complete test coverage for FileModule::getTemplates()
* Add coverage for the 'else' branch for file not existing and
an exception being thrown.
Change-Id: Ia7d608f1ed72f07f46b969046d9c9910fbfd738d
Moriel Schottlender [Tue, 27 Jun 2017 00:37:18 +0000 (17:37 -0700)]
RCFilters: Remove <hr> if extension table is empty
Bug: T168325
Change-Id: I5f537722aeef8d52cd5b0555519be97a7675491f
jenkins-bot [Tue, 27 Jun 2017 00:29:48 +0000 (00:29 +0000)]
Merge "RCFilters: Add 'single_option' group type"
Moriel Schottlender [Tue, 27 Jun 2017 00:25:14 +0000 (17:25 -0700)]
RCFilters: Correct default view title
The key was changed from "label" to "title" but that was not changed
in the default view. Change the definition key and adjust the name
of the method so it isn't confusing.
Bug: T168855
Change-Id: Ib94f57d3bcce94a02fac25d66b893a68aa648e84
Moriel Schottlender [Fri, 23 Jun 2017 20:30:42 +0000 (13:30 -0700)]
RCFilters: Add 'single_option' group type
Group type that only allows a single option to be selected
from its range of items.
Bonus: Add the ability to have a view that is hidden from
the menus
Bug: T162784
Bug: T162786
Change-Id: Ide93491a49c1405926ac171c7924a469e94c0e0a
Roan Kattouw [Tue, 27 Jun 2017 00:00:56 +0000 (17:00 -0700)]
RCFilters: Simplify "Saved filter settings" to "Saved filters"
Bug: T167876
Change-Id: I5beb2433a9fb0ba8493ec571c1c4d37cd4ee26ba
Roan Kattouw [Mon, 26 Jun 2017 23:49:52 +0000 (16:49 -0700)]
RCFilters: Always use the filled bookmark icon (unClip)
Bug: T168828
Change-Id: I436f00bc87db143116125a185abd8000132df195
jenkins-bot [Mon, 26 Jun 2017 22:56:45 +0000 (22:56 +0000)]
Merge "Replace some usages of Linker::link with LinkRenderer"
jenkins-bot [Mon, 26 Jun 2017 22:46:47 +0000 (22:46 +0000)]
Merge "RCFilters: Invert the muted state of inverted namespace options"
Moriel Schottlender [Wed, 21 Jun 2017 21:16:51 +0000 (14:16 -0700)]
RCFilters: Invert the muted state of inverted namespace options
Since the inversion happened, the background of selected items was
overridden by "muted" background, so we had to change a few more
details to get things to work properly:
- Override selected color even if the item is muted (previously,
'selected' cannot be muted by definition, but this patch changes
that and hence needs to make sure selected color overrides the
muted color state)
- Set correct muted state on the namespace items to be reversed.
- The highlight/select/mute background issue exposed a secondary
issue when switching views by clicking the 'tag' item, whereby
the change of view itself causes the input to empty, and triggers
the updateItemVisibility in MenuSelectWidget, which then selects
the first item. This shouldn't happen when the user is actively
selecting an item from the tags, so a method of recognizing that
the user is actively selecting an item was added.
Change-Id: Idf5c2232216ad6a38b29bbc103bbca66f56533b7
Bryan Davis [Tue, 13 Jun 2017 16:51:53 +0000 (10:51 -0600)]
Remove "@author Bryan Davis" and "Brad Jorsch" annotations
Undo traces of a practice we carried over from past projects and
existing examples that is neither universal nor actively encouraged in
the MediaWiki codebase.
Bug: T139301
Change-Id: I5c9c89b72a45a44aa4264a5e57b003c1a86cdf6e
Co-Authored-By: Brad Jorsch <bjorsch@wikimedia.org>
jenkins-bot [Mon, 26 Jun 2017 20:25:38 +0000 (20:25 +0000)]
Merge "mw.filewarning: Increase the area of the warning button"
jenkins-bot [Mon, 26 Jun 2017 20:21:18 +0000 (20:21 +0000)]
Merge "mediawiki.Title: Remove needless $.type() and minor clean up"
Translation updater bot [Mon, 26 Jun 2017 19:56:04 +0000 (21:56 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I457987aceec9e936608988e63a88686d1e98675d
C. Scott Ananian [Mon, 26 Jun 2017 17:56:30 +0000 (13:56 -0400)]
tests: Reset LanguageConverter conversion tables between test cases
Conversion rules defined in a previous test case were leaking into
subsequent test cases. Existing tests had worked around this by defining
non-overlapping rules, but it's better to just fix the problem at the
source.
Change-Id: I65736520cd04bfe8949b29ade07338a6e1b88a4d
Umherirrender [Mon, 26 Jun 2017 16:35:31 +0000 (18:35 +0200)]
build: Prepare for mediawiki/mediawiki-codesniffer to 0.9.0
The used phpcs has a bug, so the version 0.9.0 could not be enforced at the moment.
Will be fixed in next version, see T167168
Changed:
- Remove duplicate newline at end of file
- Add space between function and ( for closures
- and -> &&, or -> ||
Change-Id: I4172fb08861729bccd55aecbd07e029e2638d311
Mukunda Modell [Mon, 26 Jun 2017 16:27:23 +0000 (11:27 -0500)]
Downgrade 'found writes/callbacks pending.' from error to info
This generates useless logspam and should be logged with a lower
log level.
Bug: T149353
Change-Id: If5e84b89eca098ac7f8c788ca3b0d268adf799fb
Bartosz Dziewoński [Mon, 26 Jun 2017 16:26:34 +0000 (18:26 +0200)]
mw.filewarning: Increase the area of the warning button
So that the user can move the mouse cursor to the popup
without the popup disappearing.
Bug: T157544
Change-Id: Ide9db6f6fd092caeea1bacfc97ec79f9acc3793e
jenkins-bot [Mon, 26 Jun 2017 15:05:22 +0000 (15:05 +0000)]
Merge "Parser: Emit deprecation warnings for ParserLimitReport hook"
jenkins-bot [Mon, 26 Jun 2017 06:55:16 +0000 (06:55 +0000)]
Merge "Perform input validation for file $page at some strategic locations"
Prateek Saxena [Mon, 26 Jun 2017 03:52:56 +0000 (09:22 +0530)]
docs: Use oojs-ui-wikimediaui, instead of -mediawiki
Change-Id: Iac6a526c928fe384f5f7df5af6b0156146bf2f33
Translation updater bot [Sun, 25 Jun 2017 20:08:15 +0000 (22:08 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I3311079076af3f9bad7b06c4ac0a532a2ecd75ba
jenkins-bot [Sun, 25 Jun 2017 10:35:55 +0000 (10:35 +0000)]
Merge "Update weblinks in comments to msdn.microsoft.com"
jenkins-bot [Sun, 25 Jun 2017 10:25:55 +0000 (10:25 +0000)]
Merge "Rename canTalk methods"
jenkins-bot [Sun, 25 Jun 2017 10:24:58 +0000 (10:24 +0000)]
Merge "Parser: Ensure function and tag hook callbacks are callable upon registration"
jenkins-bot [Sun, 25 Jun 2017 10:15:42 +0000 (10:15 +0000)]
Merge "FileDeleteForm: Create log entry even if the page didn't exist"
daniel [Fri, 9 Jun 2017 18:29:18 +0000 (20:29 +0200)]
Rename canTalk methods
This renames Title::canTalk to Title::canHaveTalkPage
and MWNamespace::canTalk to MWNamespace::hasTalkNamespace.
Bug: T165149
Change-Id: I342a273a497b31282388b13bf76dadfb1122dcbb
daniel [Wed, 7 Jun 2017 10:49:24 +0000 (12:49 +0200)]
Parser: Ensure function and tag hook callbacks are callable upon registration
This is to safeguard against issues like T167238, where the callback was invalid,
but was only noticed when the magic word was used in an article.
In general, type checks should be applied when things get
registered for later use. Fail early, stay sane.
Change-Id: Ifb7005ee214829c98cec534261c0db7d13f50f35
jenkins-bot [Sun, 25 Jun 2017 10:08:32 +0000 (10:08 +0000)]
Merge "API: Allow deleting files without corresponding pages"
Umherirrender [Sat, 24 Jun 2017 23:40:22 +0000 (01:40 +0200)]
Remove newline at end from english messages
Newline get lost on translation, but it seems there are not needed.
Change-Id: I51cfc598052d4d9b457c2d7a4f25178d580d8ee3
Translation updater bot [Sat, 24 Jun 2017 20:11:00 +0000 (22:11 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I18ef4dcda34a029f16c6a85c3474eeef6a71502b
Kunal Mehta [Sat, 24 Jun 2017 00:37:31 +0000 (17:37 -0700)]
Parser: Emit deprecation warnings for ParserLimitReport hook
Change-Id: I351f0867132acf8d5cc9ee51b575744445b28b77
Timo Tijhof [Sat, 24 Jun 2017 00:23:49 +0000 (01:23 +0100)]
mediawiki.Title: Remove needless $.type() and minor clean up
* Use typeof instead of $.type() for primitives.
* Remove needless type check before instanceof.
* Use early-return pattern.
Change-Id: Ibfdbc3912961fd017cefb7115951f07b92f6d435
jenkins-bot [Fri, 23 Jun 2017 21:35:47 +0000 (21:35 +0000)]
Merge "API: Fix capitalization of SpecialRecentChanges* classes"
Translation updater bot [Fri, 23 Jun 2017 19:55:33 +0000 (21:55 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Id56fbcea3887cfa2a0ba2a3bdc83a180c20bdc92
Kunal Mehta [Fri, 23 Jun 2017 19:23:55 +0000 (12:23 -0700)]
API: Fix capitalization of SpecialRecentChanges* classes
And use the magic ::class instead of plain strings.
Noticed by logging added for T166759.
Change-Id: I7694c272c255b5b1f7455e55e70ecc240a4ba61c
Kunal Mehta [Fri, 23 Jun 2017 19:13:02 +0000 (12:13 -0700)]
SpecialContributions: Fix capitalization of DateInputWidget class
The namespace was improperly capitalized, move it to a "use" statement
while we're at it so it's only included once.
Noticed by the logging added for T166759.
Change-Id: I3fe6533a0f06dcbc37017361679dad9e77808830
jenkins-bot [Fri, 23 Jun 2017 18:39:02 +0000 (18:39 +0000)]
Merge "RCFilters: Unify reading filters by views and adjust unit tests"
jenkins-bot [Fri, 23 Jun 2017 18:35:45 +0000 (18:35 +0000)]
Merge "RCFilters: Change the input icon on interaction"
Moriel Schottlender [Fri, 23 Jun 2017 01:35:58 +0000 (18:35 -0700)]
RCFilters: Unify reading filters by views and adjust unit tests
- Have the initialization method read filters by views and treat
all filters, regardless of their views, the exact same, including
evaluating their subsets and conflicts.
- Clean up unit test file and make pass with the new initialization.
Change-Id: I200720ffde8ad8ff7a63d0cd82615d358e74949a
jenkins-bot [Fri, 23 Jun 2017 15:05:29 +0000 (15:05 +0000)]
Merge "Set $wgGalleryOptions in Setup.php"
jenkins-bot [Fri, 23 Jun 2017 11:42:26 +0000 (11:42 +0000)]
Merge "Use $.noop instead of function () {}"
Matthias Mullie [Fri, 23 Jun 2017 11:31:49 +0000 (13:31 +0200)]
Set $wgGalleryOptions in Setup.php
Defaults will be added to the config array at a later point,
without overriding any that have already been set.
This'll make it less prone to errors in case $wgGalleryOptions
is incomplete.
Bug: T168479
Change-Id: I5f127e5ac8c8a1583301dd7aed2ae8e434987950
jenkins-bot [Fri, 23 Jun 2017 11:32:13 +0000 (11:32 +0000)]
Merge "resourceloader: Backport jquery-migrate.js patch for exceptionHook"
Fomafix [Fri, 23 Jun 2017 06:45:29 +0000 (08:45 +0200)]
Use $.noop instead of function () {}
$.noop (https://api.jquery.com/jQuery.noop/) already provides an empty
function.
Change-Id: I7f1ca20a894d0469cb7bcb72c81722070e040956
Ed Sanders [Fri, 23 Jun 2017 05:26:29 +0000 (22:26 -0700)]
Fix border-radii on FilterTagMultiselectWidget
Change-Id: I14211db541f02a48e7aa0a95f967d7882c59280e
jenkins-bot [Fri, 23 Jun 2017 00:24:13 +0000 (00:24 +0000)]
Merge "RCFilters: Reposition TagItemWidget to be center on the widget"
jenkins-bot [Fri, 23 Jun 2017 00:18:15 +0000 (00:18 +0000)]
Merge "RCFilters: Have the model accept multiple views"
jenkins-bot [Fri, 23 Jun 2017 00:12:02 +0000 (00:12 +0000)]
Merge "RCFilters: Correct unbalanced margins in active filters display"
jenkins-bot [Fri, 23 Jun 2017 00:11:19 +0000 (00:11 +0000)]
Merge "RCFilters: Remove view triggers before checking emptiness of string"
jenkins-bot [Fri, 23 Jun 2017 00:06:45 +0000 (00:06 +0000)]
Merge "RCFilters: Change to the new views redesign"
Moriel Schottlender [Thu, 15 Jun 2017 00:15:52 +0000 (17:15 -0700)]
RCFilters: Change to the new views redesign
- Allow for multiple footers for the menu, each configured
for its own view (or multiple views)
- Move the switch view buttons to the right of the input
- Add a 'back' button on the menu header when we're in
advanced filters view, moving back to default view
Bug: T167384
Change-Id: I9fd0243f88f92ddacb4c912ff974f7d325f32f5d
Timo Tijhof [Thu, 22 Jun 2017 22:49:56 +0000 (23:49 +0100)]
resourceloader: Backport jquery-migrate.js patch for exceptionHook
jQuery Migrate has to monkey-patch jQuery.Deferred, but in doing so
it also effectively disables exceptionHook, which means exceptions
are no longer logged to the console.
<https://github.com/jquery/jquery-migrate/pull/262>
Bug: T168086
Change-Id: Id46abcc7fb5e65954532b114636bf0f1f000a551
jenkins-bot [Thu, 22 Jun 2017 22:48:14 +0000 (22:48 +0000)]
Merge "RCFilters: Actually recognize a saved query default and delete when removed"
jenkins-bot [Thu, 22 Jun 2017 21:24:17 +0000 (21:24 +0000)]
Merge "Fix the tableExists method of MysqlBase"
mainframe98 [Mon, 19 Jun 2017 17:20:43 +0000 (19:20 +0200)]
Fix the tableExists method of MysqlBase
The table name generated by Database::tableName() does not work in
MysqlBase's tableExist method, as the syntax of SHOW TABLES does not
function like other foreign db queries. It instead should use FROM
$database rather than the database name in front of the table name.
Bug: T168207
Change-Id: I7806090eaa647959fd34de8bc606eeb952161529
Translation updater bot [Thu, 22 Jun 2017 20:02:22 +0000 (22:02 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ie2c6873b323f3668546ee1467865fdb342900a77
Moriel Schottlender [Wed, 21 Jun 2017 00:37:17 +0000 (17:37 -0700)]
RCFilters: Have the model accept multiple views
Organize the way we create and process multiple views, to stop
hard-coding namespaces and tags.
Change-Id: Ib28c166052781b23a3b35c1b7b0af7d26f102e3f
Moriel Schottlender [Thu, 22 Jun 2017 01:21:56 +0000 (18:21 -0700)]
RCFilters: Actually recognize a saved query default and delete when removed
Compare ID to saved default even if those were saved in different
formats (number vs string) when setting default on initialization
and when deleting the default when deleting the item.
Change-Id: Ia211a7166b3ff514c0e2a34bb370cf2d50057745
jenkins-bot [Thu, 22 Jun 2017 18:09:46 +0000 (18:09 +0000)]
Merge "Linker: Remove whiny FIXME comments"
Bartosz Dziewoński [Thu, 22 Jun 2017 17:49:20 +0000 (19:49 +0200)]
Linker: Remove whiny FIXME comments
These are not actionable. Such is life, deal with it.
Change-Id: I81df045f54052b98cf798d3d42a3d730407d68ae
jenkins-bot [Thu, 22 Jun 2017 17:10:36 +0000 (17:10 +0000)]
Merge "API: Display message-per-value style help for submodule parameters"
jenkins-bot [Thu, 22 Jun 2017 16:49:40 +0000 (16:49 +0000)]
Merge "Add 3D filetype for STL files"
jenkins-bot [Thu, 22 Jun 2017 16:08:27 +0000 (16:08 +0000)]
Merge "Remove execute bits from non-executable files"
Brad Jorsch [Thu, 22 Jun 2017 15:27:23 +0000 (11:27 -0400)]
Remove execute bits from non-executable files
Change-Id: I4d6a202c63bef3e52b67b55fb6daef04dc2fdd62
Bartosz Dziewoński [Thu, 22 Jun 2017 14:22:49 +0000 (16:22 +0200)]
CollationFa: Avoid PHP 7 Unicode escape syntax
We still support PHP 5.5.
Change-Id: I587cb794cded95afe7ad493614a6090a108efe6c
jenkins-bot [Thu, 22 Jun 2017 14:11:21 +0000 (14:11 +0000)]
Merge "Ability to create tests with nested modules"
jenkins-bot [Thu, 22 Jun 2017 00:48:38 +0000 (00:48 +0000)]
Merge "RC Filters: Fix tags for integrated filters"
Moriel Schottlender [Wed, 21 Jun 2017 20:31:35 +0000 (13:31 -0700)]
RCFilters: Remove view triggers before checking emptiness of string
Bug: T168220
Change-Id: I3ae6fba358456745cb570840211319f7eac754ce
Translation updater bot [Wed, 21 Jun 2017 20:07:34 +0000 (22:07 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: If8ff147d26d1ccf1d4c540ee7bc25cabead1da5a
jenkins-bot [Wed, 21 Jun 2017 20:01:47 +0000 (20:01 +0000)]
Merge "resourceloader: Add unit tests for ResourceLoader::isFileModule"
jenkins-bot [Wed, 21 Jun 2017 19:53:24 +0000 (19:53 +0000)]
Merge "Allow $wgResourceModuleSkinStyles for any ResourceLoaderFileModule subclass"