From: Aaron Schulz <aschulz@wikimedia.org>
Date: Sun, 21 Oct 2018 07:44:45 +0000 (-0700)
Subject: Remove unused fields in ForeignDBViaLBRepo
X-Git-Tag: 1.34.0-rc.0~3653^2
X-Git-Url: http://git.cyclocoop.org/%22%20.%20generer_url_ecrire%28%22calendrier%22%2C%22type=semaine%22%29%20.%20%22?a=commitdiff_plain;h=b02c9190019be5733b67d249920ea208c6c173e3;p=lhc%2Fweb%2Fwiklou.git

Remove unused fields in ForeignDBViaLBRepo

Change-Id: Ia60139c5670ad572058cf39c7e7bf78972d29d9f
---

diff --git a/includes/filerepo/ForeignDBViaLBRepo.php b/includes/filerepo/ForeignDBViaLBRepo.php
index 302b194a2c..ad6ec472f4 100644
--- a/includes/filerepo/ForeignDBViaLBRepo.php
+++ b/includes/filerepo/ForeignDBViaLBRepo.php
@@ -23,7 +23,7 @@
 
 use MediaWiki\MediaWikiServices;
 use Wikimedia\Rdbms\IDatabase;
-use Wikimedia\Rdbms\LoadBalancer;
+use Wikimedia\Rdbms\ILoadBalancer;
 
 /**
  * A foreign repository with a MediaWiki database accessible via the configured LBFactory
@@ -34,12 +34,6 @@ class ForeignDBViaLBRepo extends LocalRepo {
 	/** @var string */
 	protected $wiki;
 
-	/** @var string */
-	protected $dbName;
-
-	/** @var string */
-	protected $tablePrefix;
-
 	/** @var array */
 	protected $fileFactory = [ ForeignDBFile::class, 'newFromTitle' ];
 
@@ -55,7 +49,6 @@ class ForeignDBViaLBRepo extends LocalRepo {
 	function __construct( $info ) {
 		parent::__construct( $info );
 		$this->wiki = $info['wiki'];
-		list( $this->dbName, $this->tablePrefix ) = wfSplitWikiID( $this->wiki );
 		$this->hasSharedCache = $info['hasSharedCache'];
 	}
 
@@ -83,10 +76,11 @@ class ForeignDBViaLBRepo extends LocalRepo {
 	}
 
 	/**
-	 * @return LoadBalancer
+	 * @return ILoadBalancer
 	 */
 	protected function getDBLoadBalancer() {
 		$lbFactory = MediaWikiServices::getInstance()->getDBLoadBalancerFactory();
+
 		return $lbFactory->getMainLB( $this->wiki );
 	}