From: James D. Forrester <jforrester@wikimedia.org>
Date: Sat, 9 Feb 2019 01:34:49 +0000 (-0800)
Subject: Drop LinkCache->addLink(), deprecated in 1.27 and unused
X-Git-Tag: 1.34.0-rc.0~2884
X-Git-Url: http://git.cyclocoop.org/%22%20.%20generer_url_ecrire%28%22calendrier%22%2C%22type=semaine%22%29%20.%20%22?a=commitdiff_plain;h=33418878f9ae7b9d2871e6063c08585869d02581;p=lhc%2Fweb%2Fwiklou.git

Drop LinkCache->addLink(), deprecated in 1.27 and unused

Change-Id: Id6395cc9a122375349b7a13c051049bca3f5ab08
---

diff --git a/RELEASE-NOTES-1.33 b/RELEASE-NOTES-1.33
index eb55a88773..ee4f215d33 100644
--- a/RELEASE-NOTES-1.33
+++ b/RELEASE-NOTES-1.33
@@ -215,6 +215,8 @@ because of Phabricator reports.
   version in DummyLinker). You can use TemplatesOnThisPageFormatter directly.
 * EventRelayerGroup::singleton(), deprecated in 1.27, has been removed. You can
   use MediaWikiServices::getInstance()->getEventRelayerGroup() directly.
+* LinkCache->addLink(), deprecated in 1.27, has been removed. It is thought to
+  be unused, and is distinct from OutputPage->addLink(), which remains.
 
 === Deprecations in 1.33 ===
 * The configuration option $wgUseESI has been deprecated, and is expected
diff --git a/includes/cache/LinkCache.php b/includes/cache/LinkCache.php
index b9944a82f0..b3dc00468b 100644
--- a/includes/cache/LinkCache.php
+++ b/includes/cache/LinkCache.php
@@ -189,22 +189,6 @@ class LinkCache {
 		$this->goodLinks->clear( $dbkey );
 	}
 
-	/**
-	 * Add a title to the link cache, return the page_id or zero if non-existent
-	 *
-	 * @deprecated since 1.27, unused
-	 * @param string $title Prefixed DB key
-	 * @return int Page ID or zero
-	 */
-	public function addLink( $title ) {
-		wfDeprecated( __METHOD__, '1.27' );
-		$nt = Title::newFromDBkey( $title );
-		if ( !$nt ) {
-			return 0;
-		}
-		return $this->addLinkObj( $nt );
-	}
-
 	/**
 	 * Fields that LinkCache needs to select
 	 *