Drop unnecessary CSS selectors for a.external[href^="gopher://"]

* They don't do anything anyway - gopher:// links are not styled by
  anything else, so they'd just get the same styles as regular
  external links.
* They cause problems in browsers not supporting the attribute
  selector (like IE6), as the browser drops the entire rule, as
  required by the CSS specification.

Also removed some code in monobook/IE60Fixes.css which seems to be
simply a workaround for the issue described above.

Bug: 31495
Change-Id: Ib33d47d5372dd73097bdcef8d00ebd073f6bbd68

diff --git a/skins/modern/main.css b/skins/modern/main.css
index 47c320b..40fbfd7 100644 (file)
--- a/skins/modern/main.css
+++ b/skins/modern/main.css
@@ -405,8 +405,7 @@ h1, h2, h3, h4, h5, h6 {
        text-decoration: none;
        color: white;
 }
-#mw_content a.external,
-#mw_content a.external[href ^="gopher://"] {
+#mw_content a.external {
        /* @embed */
        background: url(external.png) center right no-repeat;
        padding-right: 13px;

diff --git a/skins/monobook/IE60Fixes.css b/skins/monobook/IE60Fixes.css
index ec1ce43..534d333 100644 (file)
--- a/skins/monobook/IE60Fixes.css
+++ b/skins/monobook/IE60Fixes.css
@@ -70,15 +70,6 @@ div#footer {
 #portal-personaltools {
        padding-bottom: 0.1em;
 }
-#bodyContent a.external {
-       background: url(external.png) center right no-repeat;
-       padding-right: 13px;
-}
-
-.rtl #bodyContent a.external {
-       background-image: url(external-rtl.png);
-       padding-right: 13px;
-}
 
 .rtl a.feedlink {
        background-position: right;

diff --git a/skins/monobook/main.css b/skins/monobook/main.css
index 50b9e09..d8f25eb 100644 (file)
--- a/skins/monobook/main.css
+++ b/skins/monobook/main.css
@@ -142,8 +142,7 @@ table.rimage {
 ** keep the whitespace in front of the ^=, hides rule from konqueror
 ** this is css3, the validator doesn't like it when validating as css2
 */
-#bodyContent a.external,
-#bodyContent a.external[href ^="gopher://"] {
+#bodyContent a.external {
        /* @embed */
        background: url(external-ltr.png) center right no-repeat;
        padding-right: 13px;

diff --git a/skins/vector/screen.css b/skins/vector/screen.css
index 8a69f84..c164c6d 100644 (file)
--- a/skins/vector/screen.css
+++ b/skins/vector/screen.css
@@ -703,8 +703,7 @@ pre, .mw-code {
        margin-top: 0;
        font-size: 1.6em;
 }
-div#content a.external,
-div#content a.external[href ^="gopher://"] {
+div#content a.external {
        /* @embed */
        background: url(images/external-link-ltr-icon.png) center right no-repeat;
        padding-right: 13px;