9ec1b4667b718fb72e95a731bc90703c63dba75e
6 class UploadBaseTest
extends MediaWikiTestCase
{
8 /** @var UploadTestHandler */
11 protected function setUp() {
14 $this->upload
= new UploadTestHandler
;
16 $this->setMwGlobals( 'wgHooks', array(
17 'InterwikiLoadPrefix' => array(
18 function ( $prefix, &$data ) {
26 * First checks the return code
27 * of UploadBase::getTitle() and then the actual returned title
29 * @dataProvider provideTestTitleValidation
30 * @covers UploadBase::getTitle
32 public function testTitleValidation( $srcFilename, $dstFilename, $code, $msg ) {
33 /* Check the result code */
34 $this->assertEquals( $code,
35 $this->upload
->testTitleValidation( $srcFilename ),
38 /* If we expect a valid title, check the title itself. */
39 if ( $code == UploadBase
::OK
) {
40 $this->assertEquals( $dstFilename,
41 $this->upload
->getTitle()->getText(),
47 * Test various forms of valid and invalid titles that can be supplied.
49 public static function provideTestTitleValidation() {
51 /* Test a valid title */
52 array( 'ValidTitle.jpg', 'ValidTitle.jpg', UploadBase
::OK
,
53 'upload valid title' ),
54 /* A title with a slash */
55 array( 'A/B.jpg', 'B.jpg', UploadBase
::OK
,
56 'upload title with slash' ),
57 /* A title with illegal char */
58 array( 'A:B.jpg', 'A-B.jpg', UploadBase
::OK
,
59 'upload title with colon' ),
60 /* Stripping leading File: prefix */
61 array( 'File:C.jpg', 'C.jpg', UploadBase
::OK
,
62 'upload title with File prefix' ),
63 /* Test illegal suggested title (r94601) */
64 array( '%281%29.JPG', null, UploadBase
::ILLEGAL_FILENAME
,
65 'illegal title for upload' ),
66 /* A title without extension */
67 array( 'A', null, UploadBase
::FILETYPE_MISSING
,
68 'upload title without extension' ),
69 /* A title with no basename */
70 array( '.jpg', null, UploadBase
::MIN_LENGTH_PARTNAME
,
71 'upload title without basename' ),
72 /* A title that is longer than 255 bytes */
73 array( str_repeat( 'a', 255 ) . '.jpg', null, UploadBase
::FILENAME_TOO_LONG
,
74 'upload title longer than 255 bytes' ),
75 /* A title that is longer than 240 bytes */
76 array( str_repeat( 'a', 240 ) . '.jpg', null, UploadBase
::FILENAME_TOO_LONG
,
77 'upload title longer than 240 bytes' ),
82 * Test the upload verification functions
83 * @covers UploadBase::verifyUpload
85 public function testVerifyUpload() {
86 /* Setup with zero file size */
87 $this->upload
->initializePathInfo( '', '', 0 );
88 $result = $this->upload
->verifyUpload();
89 $this->assertEquals( UploadBase
::EMPTY_FILE
,
91 'upload empty file' );
94 // Helper used to create an empty file of size $size.
95 private function createFileOfSize( $size ) {
96 $filename = $this->getNewTempFile();
98 $fh = fopen( $filename, 'w' );
99 ftruncate( $fh, $size );
106 * test uploading a 100 bytes file with $wgMaxUploadSize = 100
108 * This method should be abstracted so we can test different settings.
110 public function testMaxUploadSize() {
111 $this->setMwGlobals( array(
112 'wgMaxUploadSize' => 100,
113 'wgFileExtensions' => array(
118 $filename = $this->createFileOfSize( 100 );
119 $this->upload
->initializePathInfo( basename( $filename ) . '.txt', $filename, 100 );
120 $result = $this->upload
->verifyUpload();
123 array( 'status' => UploadBase
::OK
),
130 * @dataProvider provideCheckSvgScriptCallback
132 public function testCheckSvgScriptCallback( $svg, $wellFormed, $filterMatch, $message ) {
133 list( $formed, $match ) = $this->upload
->checkSvgString( $svg );
134 $this->assertSame( $wellFormed, $formed, $message );
135 $this->assertSame( $filterMatch, $match, $message );
138 public static function provideCheckSvgScriptCallback() {
139 // @codingStandardsIgnoreStart Generic.Files.LineLength
141 // html5sec SVG vectors
143 '<svg xmlns="http://www.w3.org/2000/svg"><script>alert(1)</script></svg>',
146 'Script tag in svg (http://html5sec.org/#47)'
149 '<svg xmlns="http://www.w3.org/2000/svg"><g onload="javascript:alert(1)"></g></svg>',
152 'SVG with onload property (http://html5sec.org/#11)'
155 '<svg onload="javascript:alert(1)" xmlns="http://www.w3.org/2000/svg"></svg>',
158 'SVG with onload property (http://html5sec.org/#65)'
161 '<svg xmlns="http://www.w3.org/2000/svg"> <a xmlns:xlink="http://www.w3.org/1999/xlink" xlink:href="javascript:alert(1)"><rect width="1000" height="1000" fill="white"/></a> </svg>',
164 'SVG with javascript xlink (http://html5sec.org/#87)'
167 '<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"><use xlink:href="data:application/xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHhtbG5zOnhsaW5rPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hsaW5rIj4KPGRlZnM+CjxjaXJjbGUgaWQ9InRlc3QiIHI9IjUwIiBjeD0iMTAwIiBjeT0iMTAwIiBzdHlsZT0iZmlsbDogI0YwMCI+CjxzZXQgYXR0cmlidXRlTmFtZT0iZmlsbCIgYXR0cmlidXRlVHlwZT0iQ1NTIiBvbmJlZ2luPSdhbGVydChkb2N1bWVudC5jb29raWUpJwpvbmVuZD0nYWxlcnQoIm9uZW5kIiknIHRvPSIjMDBGIiBiZWdpbj0iMXMiIGR1cj0iNXMiIC8+CjwvY2lyY2xlPgo8L2RlZnM+Cjx1c2UgeGxpbms6aHJlZj0iI3Rlc3QiLz4KPC9zdmc+#test"/> </svg>',
170 'SVG with Opera image xlink (http://html5sec.org/#88 - c)'
173 '<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"> <animation xlink:href="javascript:alert(1)"/> </svg>',
176 'SVG with Opera animation xlink (http://html5sec.org/#88 - a)'
179 '<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"> <animation xlink:href="data:text/xml,%3Csvg xmlns=\'http://www.w3.org/2000/svg\' onload=\'alert(1)\'%3E%3C/svg%3E"/> </svg>',
182 'SVG with Opera animation xlink (http://html5sec.org/#88 - b)'
185 '<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"> <image xlink:href="data:image/svg+xml,%3Csvg xmlns=\'http://www.w3.org/2000/svg\' onload=\'alert(1)\'%3E%3C/svg%3E"/> </svg>',
188 'SVG with Opera image xlink (http://html5sec.org/#88 - c)'
191 '<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"> <foreignObject xlink:href="javascript:alert(1)"/> </svg>',
194 'SVG with Opera foreignObject xlink (http://html5sec.org/#88 - d)'
197 '<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"> <foreignObject xlink:href="data:text/xml,%3Cscript xmlns=\'http://www.w3.org/1999/xhtml\'%3Ealert(1)%3C/script%3E"/> </svg>',
200 'SVG with Opera foreignObject xlink (http://html5sec.org/#88 - e)'
203 '<svg xmlns="http://www.w3.org/2000/svg"> <set attributeName="onmouseover" to="alert(1)"/> </svg>',
206 'SVG with event handler set (http://html5sec.org/#89 - a)'
209 '<svg xmlns="http://www.w3.org/2000/svg"> <animate attributeName="onunload" to="alert(1)"/> </svg>',
212 'SVG with event handler animate (http://html5sec.org/#89 - a)'
215 '<svg xmlns="http://www.w3.org/2000/svg"> <handler xmlns:ev="http://www.w3.org/2001/xml-events" ev:event="load">alert(1)</handler> </svg>',
218 'SVG with element handler (http://html5sec.org/#94)'
221 '<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"> <feImage> <set attributeName="xlink:href" to="data:image/svg+xml;charset=utf-8;base64, PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciPjxzY3JpcHQ%2BYWxlcnQoMSk8L3NjcmlwdD48L3N2Zz4NCg%3D%3D"/> </feImage> </svg>',
224 'SVG with href to data: url (http://html5sec.org/#95)'
227 '<svg xmlns="http://www.w3.org/2000/svg" id="foo"> <x xmlns="http://www.w3.org/2001/xml-events" event="load" observer="foo" handler="data:image/svg+xml,%3Csvg%20xmlns%3D%22http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg%22%3E%0A%3Chandler%20xml%3Aid%3D%22bar%22%20type%3D%22application%2Fecmascript%22%3E alert(1) %3C%2Fhandler%3E%0A%3C%2Fsvg%3E%0A#bar"/> </svg>',
230 'SVG with Tiny handler (http://html5sec.org/#104)'
233 '<svg xmlns="http://www.w3.org/2000/svg"> <a id="x"><rect fill="white" width="1000" height="1000"/></a> <rect fill="white" style="clip-path:url(test3.svg#a);fill:url(#b);filter:url(#c);marker:url(#d);mask:url(#e);stroke:url(#f);"/> </svg>',
236 'SVG with new CSS styles properties (http://html5sec.org/#109)'
239 '<svg xmlns="http://www.w3.org/2000/svg"> <a id="x"><rect fill="white" width="1000" height="1000"/></a> <rect clip-path="url(test3.svg#a)" /> </svg>',
242 'SVG with new CSS styles properties as attributes'
245 '<svg xmlns="http://www.w3.org/2000/svg"> <a id="x"> <rect fill="white" width="1000" height="1000"/> </a> <rect fill="url(http://html5sec.org/test3.svg#a)" /> </svg>',
248 'SVG with new CSS styles properties as attributes (2)'
251 '<svg xmlns="http://www.w3.org/2000/svg"> <path d="M0,0" style="marker-start:url(test4.svg#a)"/> </svg>',
254 'SVG with path marker-start (http://html5sec.org/#110)'
257 '<?xml version="1.0"?> <?xml-stylesheet type="text/xml" href="#stylesheet"?> <!DOCTYPE doc [ <!ATTLIST xsl:stylesheet id ID #REQUIRED>]> <svg xmlns="http://www.w3.org/2000/svg"> <xsl:stylesheet id="stylesheet" version="1.0" xmlns:xsl="http://www.w3.org/1999/XSL/Transform"> <xsl:template match="/"> <iframe xmlns="http://www.w3.org/1999/xhtml" src="javascript:alert(1)"></iframe> </xsl:template> </xsl:stylesheet> <circle fill="red" r="40"></circle> </svg>',
260 'SVG with embedded stylesheet (http://html5sec.org/#125)'
263 '<svg xmlns="http://www.w3.org/2000/svg" id="x"> <listener event="load" handler="#y" xmlns="http://www.w3.org/2001/xml-events" observer="x"/> <handler id="y">alert(1)</handler> </svg>',
266 'SVG with handler attribute (http://html5sec.org/#127)'
269 // Haven't found a browser that accepts this particular example, but we
270 // don't want to allow embeded svgs, ever
271 '<svg> <image style=\'filter:url("data:image/svg+xml;charset=utf-8;base64, PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciPjxzY3JpcHQ/YWxlcnQoMSk8L3NjcmlwdD48L3N2Zz4NCg==")\' /> </svg>',
274 'SVG with image filter via style (http://html5sec.org/#129)'
277 // This doesn't seem possible without embedding the svg, but just in case
278 '<svg> <a xmlns:xlink="http://www.w3.org/1999/xlink" xlink:href="?"> <circle r="400"></circle> <animate attributeName="xlink:href" begin="0" from="javascript:alert(1)" to="" /> </a></svg>',
281 'SVG with animate from (http://html5sec.org/#137)'
284 '<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"> <a><text y="1em">Click me</text> <animate attributeName="xlink:href" values="javascript:alert(\'Bang!\')" begin="0s" dur="0.1s" fill="freeze" /> </a></svg>',
287 'SVG with animate xlink:href (http://html5sec.org/#137)'
290 '<svg xmlns="http://www.w3.org/2000/svg" xmlns:y="http://www.w3.org/1999/xlink"> <a y:href="#"> <text y="1em">Click me</text> <animate attributeName="y:href" values="javascript:alert(\'Bang!\')" begin="0s" dur="0.1s" fill="freeze" /> </a> </svg>',
293 'SVG with animate y:href (http://html5sec.org/#137)'
296 // Other hostile SVG's
298 '<?xml version="1.0" encoding="UTF-8" standalone="no"?> <svg xmlns:xlink="http://www.w3.org/1999/xlink"> <image xlink:href="https://upload.wikimedia.org/wikipedia/commons/3/34/Bahnstrecke_Zeitz-Camburg_1930.png" /> </svg>',
301 'SVG with non-local image href (bug 65839)'
304 '<?xml version="1.0" ?> <?xml-stylesheet type="text/xsl" href="/w/index.php?title=User:Jeeves/test.xsl&action=raw&format=xml" ?> <svg> <height>50</height> <width>100</width> </svg>',
307 'SVG with remote stylesheet (bug 57550)'
310 '<svg xmlns="http://www.w3.org/2000/svg" viewbox="-1 -1 15 15"> <rect y="0" height="13" width="12" stroke="#179" rx="1" fill="#2ac"/> <text x="1.5" y="11" font-family="courier" stroke="white" font-size="16"><![CDATA[B]]></text> <iframe xmlns="http://www.w3.org/1999/xhtml" srcdoc="<script>alert('XSSED => Domain('+top.document.domain+')');</script>"></iframe> </svg>',
313 'SVG with rembeded iframe (bug 60771)'
316 '<svg xmlns="http://www.w3.org/2000/svg" viewBox="6 3 177 153" xmlns:xlink="http://www.w3.org/1999/xlink"> <style>@import url("https://fonts.googleapis.com/css?family=Bitter:700&text=WebPlatform.org");</style> <g transform="translate(-.5,-.5)"> <text fill="#474747" x="95" y="150" text-anchor="middle" font-family="Bitter" font-size="20" font-weight="bold">WebPlatform.org</text> </g> </svg>',
319 'SVG with @import in style element (bug 69008)'
322 '<svg xmlns="http://www.w3.org/2000/svg" viewBox="6 3 177 153" xmlns:xlink="http://www.w3.org/1999/xlink"> <style>@import url("https://fonts.googleapis.com/css?family=Bitter:700&text=WebPlatform.org");<foo/></style> <g transform="translate(-.5,-.5)"> <text fill="#474747" x="95" y="150" text-anchor="middle" font-family="Bitter" font-size="20" font-weight="bold">WebPlatform.org</text> </g> </svg>',
325 'SVG with @import in style element and child element (bug 69008#c11)'
328 '<svg xmlns="http://www.w3.org/2000/svg" viewBox="6 3 177 153" xmlns:xlink="http://www.w3.org/1999/xlink"> <style>@imporT "https://fonts.googleapis.com/css?family=Bitter:700&text=WebPlatform.org";</style> <g transform="translate(-.5,-.5)"> <text fill="#474747" x="95" y="150" text-anchor="middle" font-family="Bitter" font-size="20" font-weight="bold">WebPlatform.org</text> </g> </svg>',
331 'SVG with case-insensitive @import in style element (bug T85349)'
334 '<svg xmlns="http://www.w3.org/2000/svg"> <rect width="100" height="100" style="background-image:url(https://www.google.com/images/srpr/logo11w.png)"/> </svg>',
337 'SVG with remote background image (bug 69008)'
340 '<svg xmlns="http://www.w3.org/2000/svg"> <rect width="100" height="100" style="background-image:\55rl(https://www.google.com/images/srpr/logo11w.png)"/> </svg>',
343 'SVG with remote background image, encoded (bug 69008)'
346 '<svg xmlns="http://www.w3.org/2000/svg"> <style> #a { background-image:\55rl(\'https://www.google.com/images/srpr/logo11w.png\'); } </style> <rect width="100" height="100" id="a"/> </svg>',
349 'SVG with remote background image, in style element (bug 69008)'
352 // This currently doesn't seem to work in any browsers, but in case
353 // http://www.w3.org/TR/css3-images/ is implemented for SVG files
354 '<svg xmlns="http://www.w3.org/2000/svg"> <rect width="100" height="100" style="background-image:image(\'sprites.svg#xywh=40,0,20,20\')"/> </svg>',
357 'SVG with remote background image using image() (bug 69008)'
360 // As reported by Cure53
361 '<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"> <a xlink:href="data:text/html;charset=utf-8;base64, PHNjcmlwdD5hbGVydChkb2N1bWVudC5kb21haW4pPC9zY3JpcHQ%2BDQo%3D"> <circle r="400" fill="red"></circle> </a> </svg>',
364 'SVG with data:text/html link target (firefox only)'
367 '<?xml version="1.0" encoding="UTF-8" standalone="no"?> <!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd" [ <!ENTITY lol "lol"> <!ENTITY lol2 "<script>alert('XSSED => '+document.domain);</script>"> ]> <svg xmlns="http://www.w3.org/2000/svg" width="68" height="68" viewBox="-34 -34 68 68" version="1.1"> <circle cx="0" cy="0" r="24" fill="#c8c8c8"/> <text x="0" y="0" fill="black">&lol2;</text> </svg>',
370 'SVG with encoded script tag in internal entity (reported by Beyond Security)'
373 '<?xml version="1.0"?> <!DOCTYPE svg [ <!ENTITY foo SYSTEM "file:///etc/passwd"> ]> <svg xmlns="http://www.w3.org/2000/svg" version="1.1"> <desc>&foo;</desc> <rect width="300" height="100" style="fill:rgb(0,0,255);stroke-width:1;stroke:rgb(0,0,2)" /> </svg>',
376 'SVG with external entity'
379 // Test good, but strange files that we want to allow
381 '<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"> <g> <a xlink:href="http://en.wikipedia.org/wiki/Main_Page"> <path transform="translate(0,496)" id="path6706" d="m 112.09375,107.6875 -5.0625,3.625 -4.3125,5.03125 -0.46875,0.5 -4.09375,3.34375 -9.125,5.28125 -8.625,-3.375 z" style="fill:#cccccc;fill-opacity:1;stroke:#6e6e6e;stroke-width:0.69999999;stroke-linecap:round;stroke-linejoin:round;stroke-miterlimit:4;stroke-dasharray:none;display:inline" /> </a> </g> </svg>',
384 'SVG with <a> link to a remote site'
387 '<svg> <defs> <filter id="filter6226" x="-0.93243687" width="2.8648737" y="-0.24250539" height="1.4850108"> <feGaussianBlur stdDeviation="3.2344681" id="feGaussianBlur6228" /> </filter> <clipPath id="clipPath2436"> <path d="M 0,0 L 0,0 L 0,0 L 0,0 z" id="path2438" /> </clipPath> </defs> <g clip-path="url(#clipPath2436)" id="g2460"> <text id="text2466"> <tspan>12345</tspan> </text> </g> <path style="fill:#346733;fill-rule:evenodd;stroke:#000000;stroke-width:1;stroke-linecap:round;stroke-linejoin:bevel;stroke-opacity:1;stroke-miterlimit:4;stroke-dasharray:1, 1;stroke-dashoffset:0;filter:url(\'#filter6226\');fill-opacity:1;opacity:0.79807692" d="M 236.82371,332.63732 C 236.92217,332.63732 z" id="path5618" /> </svg>',
390 'SVG with local urls, including filter: in style'
393 // @codingStandardsIgnoreEnd
397 class UploadTestHandler
extends UploadBase
{
398 public function initializeFromRequest( &$request ) {
401 public function testTitleValidation( $name ) {
402 $this->mTitle
= false;
403 $this->mDesiredDestName
= $name;
404 $this->mTitleError
= UploadBase
::OK
;
407 return $this->mTitleError
;
411 * Almost the same as UploadBase::detectScriptInSvg, except it's
412 * public, works on an xml string instead of filename, and returns
413 * the result instead of interpreting them.
415 public function checkSvgString( $svg ) {
416 $check = new XmlTypeCheck(
418 array( $this, 'checkSvgScriptCallback' ),
420 array( 'processing_instruction_handler' => 'UploadBase::checkSvgPICallback' )
422 return array( $check->wellFormed
, $check->filterMatch
);