From e967a1d0d051be37d1e3d6dfff639246de105458 Mon Sep 17 00:00:00 2001 From: Antoine Musso Date: Mon, 30 Jan 2012 11:08:45 +0000 Subject: [PATCH] drop default parameters from r110252 Html::nmaespaceSelector() generate a select using 'namespace' value for both 'id' and 'name'. Hence passing: array( 'name' => 'namespace', 'id' => 'namespace' ) is not needed. --- includes/specials/SpecialAllpages.php | 3 +-- includes/specials/SpecialRecentchanges.php | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/includes/specials/SpecialAllpages.php b/includes/specials/SpecialAllpages.php index 960a327a05..02741baafd 100644 --- a/includes/specials/SpecialAllpages.php +++ b/includes/specials/SpecialAllpages.php @@ -128,8 +128,7 @@ class SpecialAllpages extends IncludableSpecialPage { " " . Html::namespaceSelector( - array( 'selected' => $namespace ), - array( 'name' => 'namespace', 'id' => 'namespace' ) + array( 'selected' => $namespace ) ) . ' ' . Xml::submitButton( $this->msg( 'allpagessubmit' )->text() ) . " diff --git a/includes/specials/SpecialRecentchanges.php b/includes/specials/SpecialRecentchanges.php index 06a8a0ce32..40e2194482 100644 --- a/includes/specials/SpecialRecentchanges.php +++ b/includes/specials/SpecialRecentchanges.php @@ -656,8 +656,7 @@ class SpecialRecentChanges extends IncludableSpecialPage { */ protected function namespaceFilterForm( FormOptions $opts ) { $nsSelect = Html::namespaceSelector( - array( 'selected' => $opts['namespace'], 'all' => '' ), - array( 'name' => 'namespace', 'id' => 'namespace' ) + array( 'selected' => $opts['namespace'], 'all' => '' ) ); $nsLabel = Xml::label( wfMsg( 'namespace' ), 'namespace' ); $invert = Xml::checkLabel( -- 2.20.1