From: James D. Forrester <jforrester@wikimedia.org>
Date: Thu, 23 Feb 2017 17:46:03 +0000 (-0800)
Subject: stylelint: Drop over-ride for 'declaration-no-important' and make pass
X-Git-Tag: 1.31.0-rc.0~3928^2
X-Git-Url: http://git.cyclocoop.org/%22%20.%20generer_url_ecrire%28%22brouteur%22%2C%28%24id_rubrique%20?a=commitdiff_plain;h=fdf499f2ffca1b170cc5acf48ea523bf915304d8;p=lhc%2Fweb%2Fwiklou.git

stylelint: Drop over-ride for 'declaration-no-important' and make pass

Change-Id: I150acaf188c445ca983583d9de107f10d425a0fb
---

diff --git a/.stylelintrc b/.stylelintrc
index d7a10322f7..27e289d430 100644
--- a/.stylelintrc
+++ b/.stylelintrc
@@ -1,8 +1,6 @@
 {
 	"extends": "stylelint-config-wikimedia",
 	"rules": {
-		"declaration-no-important": null,
-
 		"no-descending-specificity": null,
 
 		"selector-no-id": null
diff --git a/mw-config/config.css b/mw-config/config.css
index 10a6de8067..ea5835d487 100644
--- a/mw-config/config.css
+++ b/mw-config/config.css
@@ -152,8 +152,8 @@
 }
 
 .config-plainlink a {
-	background: none !important;
-	padding: 0 !important;
+	background: none !important; /* stylelint-disable-line declaration-no-important */
+	padding: 0 !important; /* stylelint-disable-line declaration-no-important */
 }
 
 .config-download-link {
diff --git a/resources/src/mediawiki.action/mediawiki.action.view.postEdit.css b/resources/src/mediawiki.action/mediawiki.action.view.postEdit.css
index 6e0010c9fe..a5ca65eebe 100644
--- a/resources/src/mediawiki.action/mediawiki.action.view.postEdit.css
+++ b/resources/src/mediawiki.action/mediawiki.action.view.postEdit.css
@@ -32,7 +32,7 @@
 }
 
 .skin-monobook .postedit {
-	top: 6em !important;
+	top: 6em !important; /* stylelint-disable-line declaration-no-important */
 }
 
 .postedit-faded {
diff --git a/resources/src/mediawiki.action/mediawiki.action.view.redirectPage.css b/resources/src/mediawiki.action/mediawiki.action.view.redirectPage.css
index a6cd6508a0..dccbaccef4 100644
--- a/resources/src/mediawiki.action/mediawiki.action.view.redirectPage.css
+++ b/resources/src/mediawiki.action/mediawiki.action.view.redirectPage.css
@@ -14,8 +14,10 @@
 	display: inline;
 	/* shared.css has some very weird directionality-specific rules for 'ul' we need to override,
 	 * search for "Correct directionality when page dir is different from site/user dir" */
+	/* stylelint-disable declaration-no-important */
 	margin: 0 !important;
 	padding: 0 !important;
+	/* stylelint-enable declaration-no-important */
 }
 
 /* @noflip */
diff --git a/resources/src/mediawiki.legacy/commonPrint.css b/resources/src/mediawiki.legacy/commonPrint.css
index 91c55d7ff7..b047f626c5 100644
--- a/resources/src/mediawiki.legacy/commonPrint.css
+++ b/resources/src/mediawiki.legacy/commonPrint.css
@@ -99,26 +99,26 @@ img {
  * MediaWiki-specific elements
  */
 #globalWrapper {
-	width: 100% !important;
-	min-width: 0 !important;
+	width: 100% !important; /* stylelint-disable-line declaration-no-important */
+	min-width: 0 !important; /* stylelint-disable-line declaration-no-important */
 }
 
 .mw-body {
 	background: #fff;
 	color: #000;
-	border: 0 !important;
-	padding: 0 !important;
-	margin: 0 !important;
+	border: 0 !important; /* stylelint-disable-line declaration-no-important */
+	padding: 0 !important; /* stylelint-disable-line declaration-no-important */
+	margin: 0 !important; /* stylelint-disable-line declaration-no-important */
 	direction: ltr;
 }
 
 #column-content {
-	margin: 0 !important;
+	margin: 0 !important; /* stylelint-disable-line declaration-no-important */
 }
 
 #column-content .mw-body {
 	padding: 1em;
-	margin: 0 !important;
+	margin: 0 !important; /* stylelint-disable-line declaration-no-important */
 }
 
 #toc {
@@ -164,8 +164,8 @@ img {
  * Links
  */
 a {
-	background: none !important;
-	padding: 0 !important;
+	background: none !important; /* stylelint-disable-line declaration-no-important */
+	padding: 0 !important; /* stylelint-disable-line declaration-no-important */
 }
 
 /* Expand URLs for printing */
@@ -187,11 +187,11 @@ a.external,
 a.new,
 a.stub {
 	/* IE 6 & 7 don't understand `inherit` */
-	color: #000 !important;
-	text-decoration: none !important;
+	color: #000 !important; /* stylelint-disable-line declaration-no-important */
+	text-decoration: none !important; /* stylelint-disable-line declaration-no-important */
 	/* Modern browser will apply this, IE 6 & 7 ignore the unknown */
-	color: inherit !important; /* stylelint-disable-line declaration-block-no-duplicate-properties */
-	text-decoration: inherit !important; /* stylelint-disable-line declaration-block-no-duplicate-properties */
+	color: inherit !important; /* stylelint-disable-line declaration-block-no-duplicate-properties, declaration-no-important */
+	text-decoration: inherit !important; /* stylelint-disable-line declaration-block-no-duplicate-properties, declaration-no-important */
 }
 
 /**
diff --git a/resources/src/mediawiki.legacy/shared.css b/resources/src/mediawiki.legacy/shared.css
index 027f7a5e92..ff0c0e3625 100644
--- a/resources/src/mediawiki.legacy/shared.css
+++ b/resources/src/mediawiki.legacy/shared.css
@@ -325,8 +325,8 @@ a.new {
 /* Plainlinks - this can be used to switch
  * off special external link styling */
 .plainlinks a.external {
-	background: none !important;
-	padding: 0 !important;
+	background: none !important; /* stylelint-disable-line declaration-no-important */
+	padding: 0 !important; /* stylelint-disable-line declaration-no-important */
 }
 
 /* External URLs should always be treated as LTR (T6330) */
@@ -540,7 +540,7 @@ table.wikitable > caption {
 }
 
 .mw-small-spinner {
-	padding: 10px !important;
+	padding: 10px !important; /* stylelint-disable-line declaration-no-important */
 	margin-right: 0.6em;
 	background-image: url( images/spinner.gif );
 	background-position: center center;
@@ -570,7 +570,7 @@ h1:lang( pi ),
 h1:lang( sa ),
 h1:lang( ta ),
 h1:lang( te ) {
-	line-height: 1.6em !important;
+	line-height: 1.6em !important; /* stylelint-disable-line declaration-no-important */
 }
 
 /* stylelint-disable selector-list-comma-newline-after */
diff --git a/resources/src/mediawiki.less/mediawiki.mixins.less b/resources/src/mediawiki.less/mediawiki.mixins.less
index 8d6312d2b2..1e952b0c87 100644
--- a/resources/src/mediawiki.less/mediawiki.mixins.less
+++ b/resources/src/mediawiki.less/mediawiki.mixins.less
@@ -155,7 +155,7 @@
 // Screen Reader Helper Mixin
 .mixin-screen-reader-text() {
 	display: block;
-	position: absolute !important;
+	position: absolute !important; /* stylelint-disable-line declaration-no-important */
 	clip: rect( 1px, 1px, 1px, 1px );
 	width: 1px;
 	height: 1px;
diff --git a/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.FilterItemWidget.less b/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.FilterItemWidget.less
index 6166e0e0fb..5b8461b0eb 100644
--- a/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.FilterItemWidget.less
+++ b/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.FilterItemWidget.less
@@ -34,9 +34,8 @@
 	&-filterCheckbox {
 		.oo-ui-fieldLayout.oo-ui-fieldLayout-align-inline {
 			// Override margin-top and -bottom rules from FieldLayout
-			margin: 0 !important;
+			margin: 0 !important; /* stylelint-disable-line declaration-no-important */
 		}
-
 	}
 
 	&-highlightButton {
diff --git a/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.FilterWrapperWidget.less b/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.FilterWrapperWidget.less
index 7b4e39fad6..970d140efb 100644
--- a/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.FilterWrapperWidget.less
+++ b/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.FilterWrapperWidget.less
@@ -6,7 +6,7 @@
 	&-popup {
 		// We have to override OOUI's definition, which is set
 		// on the inline style of the popup
-		margin-top: 2.4em !important;
+		margin-top: 2.4em !important; /* stylelint-disable-line declaration-no-important */
 		max-width: 650px;
 
 		.oo-ui-popupWidget-body {
diff --git a/resources/src/mediawiki.special/mediawiki.special.search.interwikiwidget.styles.less b/resources/src/mediawiki.special/mediawiki.special.search.interwikiwidget.styles.less
index f9cf2f36e1..5504883478 100644
--- a/resources/src/mediawiki.special/mediawiki.special.search.interwikiwidget.styles.less
+++ b/resources/src/mediawiki.special/mediawiki.special.search.interwikiwidget.styles.less
@@ -199,6 +199,7 @@ span the interwiki results across the bottom of the page.
 }
 
 /* mobile */
+/* stylelint-disable declaration-no-important */
 @media only screen and ( max-width: 768px ) {
 	#mw-interwiki-results {
 		width: 100%;
@@ -222,3 +223,4 @@ span the interwiki results across the bottom of the page.
 		max-width: none !important;
 	}
 }
+/* stylelint-enable declaration-no-important */
diff --git a/resources/src/mediawiki.widgets/mw.widgets.CalendarWidget.less b/resources/src/mediawiki.widgets/mw.widgets.CalendarWidget.less
index 162e3a61ab..395f80bce2 100644
--- a/resources/src/mediawiki.widgets/mw.widgets.CalendarWidget.less
+++ b/resources/src/mediawiki.widgets/mw.widgets.CalendarWidget.less
@@ -83,8 +83,8 @@
 	height: @calendarHeight;
 
 	.mw-widget-calendarWidget-body:first-child {
-		margin-top: 0 !important;
-		margin-left: 0 !important;
+		margin-top: 0 !important; /* stylelint-disable-line declaration-no-important */
+		margin-left: 0 !important; /* stylelint-disable-line declaration-no-important */
 		.transition( margin-left 500ms );
 	}
 }
@@ -94,8 +94,8 @@
 	height: @calendarHeight;
 
 	.mw-widget-calendarWidget-body:first-child {
-		margin-left: -@calendarWidth !important; /* stylelint-disable-line value-keyword-case */
-		margin-top: 0 !important;
+		margin-left: -@calendarWidth !important; /* stylelint-disable-line value-keyword-case, declaration-no-important */
+		margin-top: 0 !important; /* stylelint-disable-line declaration-no-important */
 		.transition( margin-left 500ms );
 	}
 }
@@ -109,8 +109,8 @@
 	}
 
 	.mw-widget-calendarWidget-body:first-child {
-		margin-left: 0 !important;
-		margin-top: 0 !important;
+		margin-left: 0 !important; /* stylelint-disable-line declaration-no-important */
+		margin-top: 0 !important; /* stylelint-disable-line declaration-no-important */
 		.transition( margin-top 500ms );
 	}
 }
@@ -124,8 +124,8 @@
 	}
 
 	.mw-widget-calendarWidget-body:first-child {
-		margin-left: 0 !important;
-		margin-top: -@calendarHeight !important; /* stylelint-disable-line value-keyword-case */
+		margin-left: 0 !important; /* stylelint-disable-line declaration-no-important */
+		margin-top: -@calendarHeight !important; /* stylelint-disable-line value-keyword-case, declaration-no-important */
 		.transition( margin-top 500ms );
 	}
 }
diff --git a/resources/src/mediawiki/htmlform/styles.css b/resources/src/mediawiki/htmlform/styles.css
index a53e86351c..a36b379875 100644
--- a/resources/src/mediawiki/htmlform/styles.css
+++ b/resources/src/mediawiki/htmlform/styles.css
@@ -26,7 +26,7 @@ table.mw-htmlform-nolabel td.mw-label {
 }
 
 tr.mw-htmlform-vertical-label td.mw-label {
-	text-align: left !important;
+	text-align: left !important; /* stylelint-disable-line declaration-no-important */
 }
 
 .mw-icon-question {
diff --git a/resources/src/mediawiki/mediawiki.diff.styles.css b/resources/src/mediawiki/mediawiki.diff.styles.css
index af9eb36044..f93df3cfad 100644
--- a/resources/src/mediawiki/mediawiki.diff.styles.css
+++ b/resources/src/mediawiki/mediawiki.diff.styles.css
@@ -115,6 +115,6 @@ td.diff-deletedline .diffchange {
 .diff-otitle,
 .diff-ntitle,
 .diff-lineno {
-	direction: ltr !important;
+	direction: ltr !important; /* stylelint-disable-line declaration-no-important */
 	unicode-bidi: embed;
 }