From: Derick Alangi <alangiderick@gmail.com>
Date: Tue, 27 Aug 2019 22:04:22 +0000 (+0100)
Subject: skins: Skin::getSkinNameMessages() method is now deprecated
X-Git-Tag: 1.34.0-rc.0~527^2
X-Git-Url: http://git.cyclocoop.org/%22%20.%20generer_url_ecrire%28%22brouteur%22%2C%28%24id_rubrique%20?a=commitdiff_plain;h=3acaffd0d7c4cae61a09c4de4e98485c05bd3a43;p=lhc%2Fweb%2Fwiklou.git

skins: Skin::getSkinNameMessages() method is now deprecated

No longer used per CS below;
https://codesearch.wmflabs.org/search/?q=getSkinNameMessages&i=nope&files=&repos=

Change-Id: I2be9f417444024c3612db3e771a385ce5ed12ec4
---

diff --git a/RELEASE-NOTES-1.34 b/RELEASE-NOTES-1.34
index 5da679f8ce..ebc30f7832 100644
--- a/RELEASE-NOTES-1.34
+++ b/RELEASE-NOTES-1.34
@@ -473,6 +473,7 @@ because of Phabricator reports.
   SearchResult::newFromTitle(). This class is being refactored into an abstract
   class. If you extend this class please be sure to override all its methods
   or extend RevisionSearchResult.
+* Skin::getSkinNameMessages() is deprecated and no longer used.
 
 === Other changes in 1.34 ===
 * …
diff --git a/includes/skins/Skin.php b/includes/skins/Skin.php
index 6ec7cb20a3..212ac47157 100644
--- a/includes/skins/Skin.php
+++ b/includes/skins/Skin.php
@@ -61,9 +61,11 @@ abstract class Skin extends ContextSource {
 
 	/**
 	 * Fetch the skinname messages for available skins.
+	 * @deprecated since 1.34, no longer used.
 	 * @return string[]
 	 */
 	static function getSkinNameMessages() {
+		wfDeprecated( __METHOD__, '1.34' );
 		$messages = [];
 		foreach ( self::getSkinNames() as $skinKey => $skinName ) {
 			$messages[] = "skinname-$skinKey";