From: Thiemo Kreuz <thiemo.kreuz@wikimedia.de>
Date: Wed, 27 Mar 2019 10:36:51 +0000 (+0100)
Subject: languages: Replace loop with array_pad()
X-Git-Tag: 1.34.0-rc.0~2202^2
X-Git-Url: http://git.cyclocoop.org/%22%20.%20generer_url_ecrire%28%22brouteur%22%2C%28%24id_rubrique%20?a=commitdiff_plain;h=2218f335e69bf7ff98ec7e31598e7abb5c62be5a;p=lhc%2Fweb%2Fwiklou.git

languages: Replace loop with array_pad()

Change-Id: Ia5159b44653f033d3db79094e46a0d94e1b1d01e
---

diff --git a/languages/Language.php b/languages/Language.php
index 9eea7ab1b8..a52ad9a9ee 100644
--- a/languages/Language.php
+++ b/languages/Language.php
@@ -4023,15 +4023,12 @@ class Language {
 	 * Checks that convertPlural was given an array and pads it to requested
 	 * amount of forms by copying the last one.
 	 *
-	 * @param array $forms Array of forms given to convertPlural
+	 * @param array $forms
 	 * @param int $count How many forms should there be at least
-	 * @return array Padded array of forms or an exception if not an array
+	 * @return array Padded array of forms
 	 */
 	protected function preConvertPlural( /* Array */ $forms, $count ) {
-		while ( count( $forms ) < $count ) {
-			$forms[] = $forms[count( $forms ) - 1];
-		}
-		return $forms;
+		return array_pad( $forms, $count, end( $forms ) );
 	}
 
 	/**