From c5ab19bf314ccc1a175b6eaed7dc46594df48d68 Mon Sep 17 00:00:00 2001 From: umherirrender Date: Tue, 6 Oct 2015 17:13:24 +0200 Subject: [PATCH] Use line comments for @codingStandardsIgnoreStart In Preprocess_DOM.php and Preprocess_Hash.php the @codingStandardsIgnoreStart is inside a doc comment, but phpcs does not see this tag and does not ignore the error. Using line comments fix this problems. See https://integration.wikimedia.org/ci/job/mediawiki-core-phpcs/842/console Change-Id: Id0edf6edb2902466748165c2e820d2cf4b7fcf75 --- includes/parser/Preprocessor_DOM.php | 10 +++++----- includes/parser/Preprocessor_Hash.php | 24 ++++++++++++------------ 2 files changed, 17 insertions(+), 17 deletions(-) diff --git a/includes/parser/Preprocessor_DOM.php b/includes/parser/Preprocessor_DOM.php index 4e359a6249..c3296894c2 100644 --- a/includes/parser/Preprocessor_DOM.php +++ b/includes/parser/Preprocessor_DOM.php @@ -23,8 +23,8 @@ /** * @ingroup Parser - * @codingStandardsIgnoreStart */ +// @codingStandardsIgnoreStart Squiz.Classes.ValidClassName.NotCamelCaps class Preprocessor_DOM implements Preprocessor { // @codingStandardsIgnoreEnd @@ -961,8 +961,8 @@ class PPDPart { /** * An expansion frame, used as a context to expand the result of preprocessToObj() * @ingroup Parser - * @codingStandardsIgnoreStart */ +// @codingStandardsIgnoreStart Squiz.Classes.ValidClassName.NotCamelCaps class PPFrame_DOM implements PPFrame { // @codingStandardsIgnoreEnd @@ -1575,8 +1575,8 @@ class PPFrame_DOM implements PPFrame { /** * Expansion frame with template arguments * @ingroup Parser - * @codingStandardsIgnoreStart */ +// @codingStandardsIgnoreStart Squiz.Classes.ValidClassName.NotCamelCaps class PPTemplateFrame_DOM extends PPFrame_DOM { // @codingStandardsIgnoreEnd @@ -1742,8 +1742,8 @@ class PPTemplateFrame_DOM extends PPFrame_DOM { /** * Expansion frame with custom arguments * @ingroup Parser - * @codingStandardsIgnoreStart */ +// @codingStandardsIgnoreStart Squiz.Classes.ValidClassName.NotCamelCaps class PPCustomFrame_DOM extends PPFrame_DOM { // @codingStandardsIgnoreEnd @@ -1791,8 +1791,8 @@ class PPCustomFrame_DOM extends PPFrame_DOM { /** * @ingroup Parser - * @codingStandardsIgnoreStart */ +// @codingStandardsIgnoreStart Squiz.Classes.ValidClassName.NotCamelCaps class PPNode_DOM implements PPNode { // @codingStandardsIgnoreEnd diff --git a/includes/parser/Preprocessor_Hash.php b/includes/parser/Preprocessor_Hash.php index f536d82218..49fa8a1ebf 100644 --- a/includes/parser/Preprocessor_Hash.php +++ b/includes/parser/Preprocessor_Hash.php @@ -26,8 +26,8 @@ * * attribute nodes are children * * "" nodes that aren't at the top are replaced with * @ingroup Parser - * @codingStandardsIgnoreStart */ +// @codingStandardsIgnoreStart Squiz.Classes.ValidClassName.NotCamelCaps class Preprocessor_Hash implements Preprocessor { // @codingStandardsIgnoreEnd @@ -749,8 +749,8 @@ class Preprocessor_Hash implements Preprocessor { /** * Stack class to help Preprocessor::preprocessToObj() * @ingroup Parser - * @codingStandardsIgnoreStart */ +// @codingStandardsIgnoreStart Squiz.Classes.ValidClassName.NotCamelCaps class PPDStack_Hash extends PPDStack { // @codingStandardsIgnoreEnd @@ -763,8 +763,8 @@ class PPDStack_Hash extends PPDStack { /** * @ingroup Parser - * @codingStandardsIgnoreStart */ +// @codingStandardsIgnoreStart Squiz.Classes.ValidClassName.NotCamelCaps class PPDStackElement_Hash extends PPDStackElement { // @codingStandardsIgnoreENd @@ -804,8 +804,8 @@ class PPDStackElement_Hash extends PPDStackElement { /** * @ingroup Parser - * @codingStandardsIgnoreStart */ +// @codingStandardsIgnoreStart Squiz.Classes.ValidClassName.NotCamelCaps class PPDPart_Hash extends PPDPart { // @codingStandardsIgnoreEnd @@ -820,8 +820,8 @@ class PPDPart_Hash extends PPDPart { /** * @ingroup Parser - * @codingStandardsIgnoreStart */ +// @codingStandardsIgnoreStart Squiz.Classes.ValidClassName.NotCamelCaps class PPDAccum_Hash { // @codingStandardsIgnoreEnd @@ -891,8 +891,8 @@ class PPDAccum_Hash { /** * An expansion frame, used as a context to expand the result of preprocessToObj() * @ingroup Parser - * @codingStandardsIgnoreStart */ +// @codingStandardsIgnoreStart Squiz.Classes.ValidClassName.NotCamelCaps class PPFrame_Hash implements PPFrame { // @codingStandardsIgnoreEnd @@ -1477,8 +1477,8 @@ class PPFrame_Hash implements PPFrame { /** * Expansion frame with template arguments * @ingroup Parser - * @codingStandardsIgnoreStart */ +// @codingStandardsIgnoreStart Squiz.Classes.ValidClassName.NotCamelCaps class PPTemplateFrame_Hash extends PPFrame_Hash { // @codingStandardsIgnoreEnd @@ -1660,8 +1660,8 @@ class PPTemplateFrame_Hash extends PPFrame_Hash { /** * Expansion frame with custom arguments * @ingroup Parser - * @codingStandardsIgnoreStart */ +// @codingStandardsIgnoreStart Squiz.Classes.ValidClassName.NotCamelCaps class PPCustomFrame_Hash extends PPFrame_Hash { // @codingStandardsIgnoreEnd @@ -1713,8 +1713,8 @@ class PPCustomFrame_Hash extends PPFrame_Hash { /** * @ingroup Parser - * @codingStandardsIgnoreStart */ +// @codingStandardsIgnoreStart Squiz.Classes.ValidClassName.NotCamelCaps class PPNode_Hash_Tree implements PPNode { // @codingStandardsIgnoreEnd @@ -1938,8 +1938,8 @@ class PPNode_Hash_Tree implements PPNode { /** * @ingroup Parser - * @codingStandardsIgnoreStart */ +// @codingStandardsIgnoreStart Squiz.Classes.ValidClassName.NotCamelCaps class PPNode_Hash_Text implements PPNode { // @codingStandardsIgnoreEnd @@ -1999,8 +1999,8 @@ class PPNode_Hash_Text implements PPNode { /** * @ingroup Parser - * @codingStandardsIgnoreStart */ +// @codingStandardsIgnoreStart Squiz.Classes.ValidClassName.NotCamelCaps class PPNode_Hash_Array implements PPNode { // @codingStandardsIgnoreEnd @@ -2057,8 +2057,8 @@ class PPNode_Hash_Array implements PPNode { /** * @ingroup Parser - * @codingStandardsIgnoreStart */ +// @codingStandardsIgnoreStart Squiz.Classes.ValidClassName.NotCamelCaps class PPNode_Hash_Attr implements PPNode { // @codingStandardsIgnoreEnd -- 2.20.1