From 36671baf9c179a0c4954da27b986597e981f5e92 Mon Sep 17 00:00:00 2001 From: Roan Kattouw Date: Fri, 26 May 2017 13:14:45 -0700 Subject: [PATCH] RCFilters UI: Use backwards-aligned anchorless popups now that they work Bug: T159906 Depends-On: I14c65f115c704114ba2387d6a89ed7aed44f8238 Change-Id: Id83d9d9b6424bc98abcddf647c47b96baf02de3d --- .../ui/mw.rcfilters.ui.FilterItemHighlightButton.js | 6 +----- .../ui/mw.rcfilters.ui.SavedLinksListWidget.js | 2 +- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterItemHighlightButton.js b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterItemHighlightButton.js index 616608e546..835cec892e 100644 --- a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterItemHighlightButton.js +++ b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterItemHighlightButton.js @@ -19,11 +19,7 @@ icon: 'highlight', indicator: 'down', popup: { - // TODO: There is a bug in non-anchored popups in - // OOUI, so we set this popup to "anchored" until - // the bug is fixed. - // See: https://phabricator.wikimedia.org/T159906 - anchor: true, + anchor: false, padded: true, align: 'backwards', horizontalPosition: 'end', diff --git a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListWidget.js b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListWidget.js index 8c021d0901..3b5e7d9eae 100644 --- a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListWidget.js +++ b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListWidget.js @@ -51,7 +51,7 @@ popup: { width: 300, anchor: false, - align: 'forwards', + align: 'backwards', $autoCloseIgnore: this.$overlay, $content: this.menu.$element } -- 2.20.1