Alex Monk [Fri, 19 Dec 2014 21:49:57 +0000 (21:49 +0000)]
Fix error in docs of VirtualRESTServiceClient and MultiHttpClient
err -> error
Change-Id: I758c026599367b282150a513b09d6f6c837a3a80
Alex Monk [Fri, 19 Dec 2014 20:06:44 +0000 (20:06 +0000)]
Fix VirtualRESTServiceClient::run
runMulti returns an array of response arrays, not request arrays.
Change-Id: I1d57ff24c43c033d533630c23fe3e1e85b448013
Timo Tijhof [Fri, 19 Dec 2014 18:49:25 +0000 (18:49 +0000)]
mediawiki.notification: Use link syntax for URL in documentation
The url was rendered as plain text instead of a clickable link.
https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw.Notification_
Change-Id: Ic7bd0e3765a53f5e4072124333d02417b7e47940
jenkins-bot [Fri, 19 Dec 2014 18:29:39 +0000 (18:29 +0000)]
Merge "maintenance: Don't copy the Apex styles when importing OOjs UI"
jenkins-bot [Fri, 19 Dec 2014 18:25:04 +0000 (18:25 +0000)]
Merge "Don't create Language objects during ResourceLoader tests"
James D. Forrester [Fri, 5 Dec 2014 22:13:03 +0000 (14:13 -0800)]
maintenance: Don't copy the Apex styles when importing OOjs UI
Also remove the existing ones.
Change-Id: I60450f5ce3d8e5b1136f9ffa3557aaf3687ca814
Kunal Mehta [Mon, 15 Dec 2014 17:38:11 +0000 (09:38 -0800)]
SpecialImport: Don't access $this->getConfig() in the constructor
The context is only set later on, so call it in the main
execute() function.
Bug: T73376
Change-Id: I34229877df6a8960756565f7df1d680aa8951cba
jenkins-bot [Fri, 19 Dec 2014 17:14:12 +0000 (17:14 +0000)]
Merge "Use more pretty output in ResourceLoader debug mode for arrays"
Legoktm [Fri, 19 Dec 2014 16:59:27 +0000 (16:59 +0000)]
Merge "Make HTMLForm::formatErrors non-static to can parse message in context"
umherirrender [Fri, 19 Dec 2014 16:55:46 +0000 (17:55 +0100)]
Use more pretty output in ResourceLoader debug mode for arrays
Effected:
- mw.language.data
- mw.language.names
- mw.config.set
- mw.user.options.set for defaults
- mw.toolbar
Change-Id: I8a9e718ab15f0b3f80e12b817295c6843a570d46
This, that and the other [Tue, 9 Dec 2014 00:05:29 +0000 (11:05 +1100)]
Make the autoload generator use forward slashes on all OSs
It was previously using the platform-specific directory separator, meaning
that we got backslashes on Windows and forward slashes on other OSs.
Bug: T77004
Change-Id: I5d502b54fddd55272e63d4a2a14b6d5de541263a
Kevin Israel [Sun, 24 Aug 2014 06:52:38 +0000 (02:52 -0400)]
Change case of class names to match declarations
Found by running tests under a version of PHP patched to report
case mismatches as E_STRICT errors.
User classes:
* MIMEsearchPage
* MostlinkedTemplatesPage
* SpecialBookSources
* UnwatchedpagesPage
Internal classes:
* DOMXPath
* stdClass
* XMLReader
Did not change:
* testautoLoadedcamlCLASS
* testautoloadedserializedclass
Change-Id: Idc8caa82cd6adb7bab44b142af2b02e15f0a89ee
umherirrender [Sat, 13 Dec 2014 11:08:45 +0000 (12:08 +0100)]
Make HTMLForm::formatErrors non-static to can parse message in context
One call in core already called it non-static
Avoid:
[GlobalTitleFail] MessageCache::parse called by
Message::toString/Message::parseText/MessageCache::parse with no title
set
Change-Id: Ic91e715177c0a4578825640a31ec68ecba3176e0
Kevin Israel [Mon, 15 Dec 2014 07:42:34 +0000 (02:42 -0500)]
tables.sql: Improve description of old_flags
* Changed the name of the 'utf8' flag to 'utf-8', as that is what
Revision stores. (This was already corrected in the mediawiki.org
manual page by RichF.) Noted that 'utf8' was, however, mistakenly
used in an old version of recompressTracked.php.
* Added 'external' to the list of flags. This was already added
to the manual page (by GreenReaper) yet not here. Copied the
description from there and added a couple of clarifications.
Change-Id: If15b49a28d7d4b0397481d21e30d877298fc7955
aude [Tue, 2 Dec 2014 22:50:58 +0000 (17:50 -0500)]
Add documentation for SiteListFileCache
Change-Id: I6c5b7fdfbbd6a4e6d67bd0f4aff539ce4d97cfda
Timo Tijhof [Tue, 18 Nov 2014 13:57:28 +0000 (14:57 +0100)]
autoloader: Remove incorrect documentation comment
Follows-up I8b1bdb84a969. This is not generated by that script,
the autoload.php file is, but that one has a similar comment
in it already.
Change-Id: Icb44f3dab356820f1e3aa5ba56949219af1b5719
Jackmcbarn [Fri, 6 Jun 2014 19:56:19 +0000 (15:56 -0400)]
Re-emit unknown tags from #tag
When #tag is given a tag that it doesn't recognize, re-emit it as a
regular tag instead of giving an error. This allows for it to be used with
transparent tags and HTML tags.
Change-Id: I0ceee8a4fdaf2d3142054a108f445ff06597c31a
Aaron Schulz [Fri, 19 Dec 2014 01:28:34 +0000 (17:28 -0800)]
Fixed comment typo and other docs tweaks
Change-Id: I0368561611071f0e4722661e7f7c146618f3364a
Kunal Mehta [Fri, 19 Dec 2014 00:52:28 +0000 (16:52 -0800)]
Don't create Language objects during ResourceLoader tests
Mock calls to ResourceLoaderContext::getDirection(), which creates
Language objects to get the directionality of a language.
Change-Id: Ibe6da3013e658aa7cf596c1da2f8ca1314b7cdd3
jenkins-bot [Fri, 19 Dec 2014 00:41:56 +0000 (00:41 +0000)]
Merge "Don't break autolinks by stripping the final semicolon from an entity."
Brad Jorsch [Thu, 11 Dec 2014 15:56:36 +0000 (10:56 -0500)]
API: Avoid MySQL filesort with list=allpages&apfilterlanglinks=withlanglinks
I'm not sure whether r44584 didn't go far enough or if MySQL's behavior
has changed since 2008, but MySQL is now filesorting when a
constant-in-WHERE field is included in GROUP BY.
If all our supported databases used the 1999 SQL standard rules for
GROUP BY[1] this would be an easy fix. But PostgreSQL before 9.1 uses
the older 1992 rules.[2] And then there's Oracle and MSSQL, which aren't
listed as supported[1] but are still in the code. Simplest thing to do
is probably to check if we're on MySQL, Sqlite, or Postgres >= 9.1 and
use the 1999 rules, and otherwise use the older rules.
[1]: Basically "any non-aggregate field in the SELECT must be
functionally dependent on the grouped-by fields", meaning if you
include the primary key you're good.
[2]: Basically "any non-aggregate field in the SELECT must be in the
GROUP BY".
[3]: https://www.mediawiki.org/wiki/Manual:Installation_requirements#Database_server
Bug: T78276
Change-Id: I80b515bb06d194b146897155b318a3d1c908e8b6
jenkins-bot [Thu, 18 Dec 2014 23:34:45 +0000 (23:34 +0000)]
Merge "Use generalizeSQL for DBPerformance log entries"
Aaron Schulz [Thu, 18 Dec 2014 23:00:57 +0000 (15:00 -0800)]
Use generalizeSQL for DBPerformance log entries
Change-Id: I6612e01ba6382bcdc1642848009f6b8e13bd79f2
Ori Livneh [Thu, 18 Dec 2014 22:10:25 +0000 (14:10 -0800)]
Revert "Simplify MWTidy"
This is broken, for reasons indicated in
<https://gerrit.wikimedia.org/r/#/c/180384/>. It was broken before, but I made
it more broken. So revert for now, and I'll give this another stab.
Change-Id: I7e67a61f7d6370f90487be6470bebe1449432a4c
Ori Livneh [Thu, 18 Dec 2014 22:56:58 +0000 (14:56 -0800)]
Set $wgInternalTidy to false in unit tests when running under HHVM
The Tidy extension for HHVM is nominally usable, but does not provide error
text returns. Tests should use TidySupport to determine whether they should use
the Tidy extension or not.
Change-Id: I0f842ddf8484206fc2a8b01289bc0a6750f34fed
C. Scott Ananian [Thu, 11 Dec 2014 20:15:28 +0000 (15:15 -0500)]
Don't break autolinks by stripping the final semicolon from an entity.
Autolinking free external links is clever about making sure that trailing
punctuation isn't included in the link. But if an HTML entity happens to
terminate the URL, the semicolon from the entity is stripped from the url,
breaking it.
Fix this corner case. This also unifies autolink parsing with Parsoid.
See: I5ae8435322c78dd1df170d7a3543fff3642759b1
Change-Id: I5482782c25e12283030b0fd2150ac55092f7979b
Translation updater bot [Thu, 18 Dec 2014 21:40:35 +0000 (22:40 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I23b96b0ea12c96c9b6fa9f2bfc6a24856986e4bd
jenkins-bot [Thu, 18 Dec 2014 20:18:34 +0000 (20:18 +0000)]
Merge "Remove double escaping in Special:Block"
Niklas Laxström [Sat, 6 Dec 2014 10:47:19 +0000 (11:47 +0100)]
Remove double escaping in Special:Block
This function is used in two extensions, which also pass it to
HtmlForm, so no underescaping there either.
Change-Id: I93325051b3a6ef8fc242437a736b5c84bda56b7d
Niklas Laxström [Sat, 6 Dec 2014 10:16:15 +0000 (11:16 +0100)]
Escape unescaped messages shown on a diff page
Change-Id: I05c07625a2dbb3c5d3ab46d1cfafeaed6a248bba
jenkins-bot [Thu, 18 Dec 2014 19:47:09 +0000 (19:47 +0000)]
Merge "Make PHPCS pass on JsonContentTest"
jenkins-bot [Thu, 18 Dec 2014 19:19:01 +0000 (19:19 +0000)]
Merge "Use Context in Article::delete for messages"
jenkins-bot [Thu, 18 Dec 2014 17:23:59 +0000 (17:23 +0000)]
Merge "Change bugzilla -> phabricator"
Florianschmidtwelzow [Thu, 18 Dec 2014 11:35:12 +0000 (12:35 +0100)]
Change bugzilla -> phabricator
Bug: T84855
Change-Id: Ic71206f5c0c8b7c6c56a350a136eb3f0ae7bc229
jenkins-bot [Thu, 18 Dec 2014 17:06:25 +0000 (17:06 +0000)]
Merge "Skip ApiFormatWddxTest under HHVM"
jenkins-bot [Thu, 18 Dec 2014 16:58:45 +0000 (16:58 +0000)]
Merge "Avoid GlobalTitleFail in HTMLFormField::__construct"
Brad Jorsch [Tue, 16 Dec 2014 16:52:52 +0000 (11:52 -0500)]
Skip ApiFormatWddxTest under HHVM
wddx_serialize_value() fails to escape the ampersand under HHVM. It has
been fixed upstream https://github.com/facebook/hhvm/issues/4283 but
has not been released yet.
When running under HHVM and detecting the ampersand is not escaped, skip
the test..
Bug: T75531
Change-Id: Ia58ec20b4daf78cd90da1bdf8af6cac86015c5d7
Bryan Davis [Thu, 18 Dec 2014 16:29:36 +0000 (09:29 -0700)]
xhprof: Guard against division by 0
Warning: Division by zero in
/srv/mediawiki/php-1.25wmf12/includes/profiler/ProfilerXhprof.php on
line 143
Change-Id: Ibb3d0ce836d30663c511809b6e1dece4baa4da92
Christian Aistleitner [Thu, 18 Dec 2014 13:13:07 +0000 (14:13 +0100)]
Make PHPCS pass on JsonContentTest
Change-Id: I1054d7d0e903e3be7cb815035dddb0f34bcd6334
jenkins-bot [Thu, 18 Dec 2014 09:14:14 +0000 (09:14 +0000)]
Merge "Run structure tests on extensions"
Bryan Davis [Thu, 18 Dec 2014 00:48:58 +0000 (17:48 -0700)]
xhprof: discard section profiler running totals
The '-total' record from the section profiler used for measuring
sub-function timing is not useful in the cumulative xhprof report data.
Change-Id: Ieb79b0e82e0bed54653fab016c133cc74ec4f637
Bryan Davis [Wed, 17 Dec 2014 23:36:04 +0000 (16:36 -0700)]
xhprof: Fix magnitude of %real measurements from scoped profiler
Change-Id: I06e5b3d82cfddd1a407c56819c9bdd91f160e928
jenkins-bot [Wed, 17 Dec 2014 23:26:35 +0000 (23:26 +0000)]
Merge "ImagePage: Use $this->getContext()->msg() instead of wfMessage"
Timo Tijhof [Wed, 3 Dec 2014 02:10:50 +0000 (02:10 +0000)]
content: Refactor and fix various bugs in JsonContent
Follows-up
d2a82fcb60. These issues weren't previously exposed
as nothing uses JsonContent by default in core, and the extensions
using it (e.g. EventLogging) lock it down very early. As are
most of these methods were never really put to use (they were
called after the extension does its superset of checking, or
too early and WikiPage ignores it).
Bug fixes
* Empty JSON object was converted to an array by PST conversion.
The beautifyJSON method is intended for prettify purposes but
actually modified the content stored in the database and made
it no longer roundtrip ({} != []).
We can't change getJsonData to return an object since it's
a public method and people use it as an array. So we can't cast
it to a PHP object as that would break back-compat.
Turns out the class doesn't even support non-objects anyway (a
primitive in JSON can trivially cause a fatal as it wasn't
consistently considered invalid, though it didn't actually fatal
due to some lucky spaghetti code in WikiPage).
* Fix beautifyJSON by checking for empty objects to prevent
implicit {} to [] conversion.
* Add isValid() check to fillParserOutput() as it's called early
on. Otherwise it throws a warning that 'foreach' (in objectTable)
iterates over null. In practice it doesn't matter since the
entire parser output is rejected when WikiPage eventually
checks isValid (through Content::prepareSave).
* Consider all non- (PHP) array values invalid instead of just
non-null values.
Enhancements
* Display message "Empty object" instead of a completely blank page
for an empty object.
* Display message "Empty object" or "Empty array" instead of an
empty table cell.
* Render arrays as a list of values (without indices).
* Remove italics from table cells for values. The monospace font
should be enough. It also offsets it from the "Empty"
placeholders (which are italicised).
Refactoring and clean up
* Use FormatJson::parse so that we can use Status to distinguish
between null parse result and thus reliably cache it.
Ideally we wouldn't need to cache it, but right now this code
is pulled apart and called in so many strange ways that we end
up calling this several times.
* Improve fairly meaningless test (testBeautifyJson) that was
calling FormatJson in its data provider, exactly what the method
being tested did. It also provided the test with data that could
never end up in normal usage (a PHP-style associated array with
implied numerical indices).
* Document that this class rejects non-array values.
* Document the problem with WikiPage assumming PST can run on any
content. WikiPage fundamentally still assumes wikitext, in that
there's no concept of invalid content.
* Fix incorrect documentation for getJsonData's return value
(It may return null.)
* Fix incorrect documentation for beautifyJSON's return value.
(It never returned boolean.)
Bug: T76553
Change-Id: Ifed379ba4674a8289b554a95953951886bf2cbfd
Kunal Mehta [Wed, 17 Dec 2014 22:49:11 +0000 (14:49 -0800)]
ImagePage: Use $this->getContext()->msg() instead of wfMessage
For the GlobalTitleFail entries coming from ImagePage.
Change-Id: I54409b53a4b19f08848e8558877d069f69947393
jenkins-bot [Wed, 17 Dec 2014 22:28:27 +0000 (22:28 +0000)]
Merge "Fix some stuttering in comments and documentation"
Kunal Mehta [Wed, 17 Dec 2014 22:19:06 +0000 (14:19 -0800)]
Avoid GlobalTitleFail in HTMLFormField::__construct
Pass the HTMLForm parent instance in the constructor so context
is available when parsing a message.
Change-Id: I532c0d95698cbcc57294b9bd2725f33838f393a9
Aaron Schulz [Wed, 17 Dec 2014 21:16:06 +0000 (13:16 -0800)]
Made a new SectionProfileCallback class that extends ScopedCallback
* This is now used by SectionProfiler and avoids the high overhead of call_user_func_array().
Change-Id: I7ff2c9a35c7cd8ee462f2368b655e766ad33dd63
Translation updater bot [Wed, 17 Dec 2014 20:28:47 +0000 (21:28 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Icf1de242546dc5a459bc4de4ad1dd185a329f1d1
Ricordisamoa [Tue, 16 Dec 2014 00:41:45 +0000 (00:41 +0000)]
Fix some stuttering in comments and documentation
Change-Id: I9c0088b9aab37335203cad45a1d6fa8ac3f43321
Brad Jorsch [Mon, 8 Dec 2014 15:43:50 +0000 (10:43 -0500)]
SECURITY: Fix CORS origin matching in the API
Bug: T77028
Change-Id: I68c1ee5b5a048af2aba4e710bc301b09748389bf
Kunal Mehta [Thu, 4 Dec 2014 22:06:55 +0000 (14:06 -0800)]
thumb.php: Set proper output formats for messages going into HTML
* Use ->parse() instead of ->text() for wikitext messages that were
being treated as HTML
* Explicitly specify ->parse() if no output format was set
* Document that wfThumbError() takes HTML
Bug: T76686
Change-Id: Id6e7548b2e081cfda7803772ed0395a15feb1f84
jenkins-bot [Wed, 17 Dec 2014 16:37:11 +0000 (16:37 +0000)]
Merge "Logging related comment updates"
Antoine Musso [Wed, 17 Dec 2014 16:15:57 +0000 (17:15 +0100)]
Run structure tests on extensions
The tests in the structure PHPUnit testsuite are used to verify the
Autoloader, ResourceLoader definitions and some basic other tests.
They are not run by Jenkins for MediaWiki extensions since we invoke:
phpunit.php --testsuite extensions
Add the structure directory to the 'extensions' testsuite. That will
start enforcing them on all extensions, so need to be merged with care.
We will want to backport this patch on all release branches we support
and make sure they pass for all extensions/branches :-/
Bug: T78798
Change-Id: Icb88fb3f10d203cfcb61c36c9c92864b92d6739c
jenkins-bot [Wed, 17 Dec 2014 10:38:51 +0000 (10:38 +0000)]
Merge "Remove $wgJavaScriptTestConfig"
Ori Livneh [Wed, 17 Dec 2014 05:44:39 +0000 (21:44 -0800)]
Simplify JsonContent::beautifyJSON()
Change-Id: I406d5c2967615f818c9ac42abc19ab8a49e1da8d
Timo Tijhof [Tue, 16 Dec 2014 01:18:16 +0000 (01:18 +0000)]
Remove $wgJavaScriptTestConfig
The config variable itself and the documentation property were added
in MediaWiki 1.19 (r107919 /
c447423593).
The testswarm-injectjs propert was added in MediaWiki 1.20 (
5e590be3d6).
We never actually ended up using TestSwarm, and this variable
is not used anywhere I can see.
Having a configuration variable for a documentation page seems
odd. I can't find another instance of this. As it's tied to development
(not for users of the wiki), link to mediawiki.org direcly.
Change-Id: Ib16607683a293b6d6661ed0411dad9a3ff551a08
Bryan Davis [Wed, 17 Dec 2014 00:12:23 +0000 (17:12 -0700)]
Logging related comment updates
* Pretty up some logging related comments.
* Send wfDebugLog messages to logger at info level
Change-Id: I97b8629095e8d6168dbeb791dfb5e7753d281cbe
James D. Forrester [Tue, 16 Dec 2014 21:43:02 +0000 (13:43 -0800)]
Update OOjs UI to v0.6.0 in composer.json too
Change-Id: I0cbeaa6421a940b12ccc3a8df42b743537258e84
jenkins-bot [Tue, 16 Dec 2014 23:33:55 +0000 (23:33 +0000)]
Merge "Add findVariantLink to StubUserLang"
James D. Forrester [Tue, 16 Dec 2014 21:29:32 +0000 (13:29 -0800)]
Update OOjs UI to v0.6.0
Release notes:
https://git.wikimedia.org/blob/oojs%2Fui.git/v0.6.0/History.md
Change-Id: I0386c3f622355de2d5771427fbcaeedd6d3bff04
jenkins-bot [Tue, 16 Dec 2014 21:11:00 +0000 (21:11 +0000)]
Merge "Move Test files under same folder structure where class is (/includes/)"
jenkins-bot [Tue, 16 Dec 2014 21:10:56 +0000 (21:10 +0000)]
Merge "Destroy session after running api tests"
jenkins-bot [Tue, 16 Dec 2014 21:07:50 +0000 (21:07 +0000)]
Merge "Normalize "\r" newlines in preSaveTransform"
umherirrender [Mon, 8 Dec 2014 19:29:30 +0000 (20:29 +0100)]
Move Test files under same folder structure where class is (/includes/)
Change-Id: I95f1aa6f0ed2cc3306aa6e588a11f359854315c1
umherirrender [Tue, 9 Dec 2014 20:35:40 +0000 (21:35 +0100)]
Destroy session after running api tests
ApiLogin and ApiCreateAccount calling wfSetupSession, which leaks a
session over the test.
The test RequestContextText needs a clear session to work, so the api
tests should avoid leaking the session.
Doing this in the ApiTestCase because some tests calling ApiLogin over
FauxRequest and that also starts a session.
Change-Id: Icf5cb4d4a2c24c96698cac5bf32147c0c9149ef3
Translation updater bot [Tue, 16 Dec 2014 20:39:15 +0000 (20:39 +0000)]
Merge "Localisation updates from https://translatewiki.net."
jenkins-bot [Tue, 16 Dec 2014 20:35:31 +0000 (20:35 +0000)]
Merge "Move advanced search inputs back into the form"
Translation updater bot [Tue, 16 Dec 2014 20:32:35 +0000 (21:32 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Ibc0afaa9fdc8383545aac46f5b886c20a594a697
Rob Moen [Tue, 16 Dec 2014 19:34:40 +0000 (11:34 -0800)]
Move advanced search inputs back into the form
Follow up to Ic6ec29817ab7deadc6bc7125f8b4cd16686baa04
Bug: T78553
Change-Id: I6c8892e7742bac730154a66ab2bbb9c37ef3af9d
Timo Tijhof [Tue, 16 Dec 2014 19:03:16 +0000 (19:03 +0000)]
Minor clean up of release notes
* Consistently use 'Git' when referring to the system (not 'git').
https://github.com/git/git/blob/v2.1.3/Documentation/CodingGuidelines#L483-L486
* Remove angle brackets from a few urls. This is pseudo-wikitext.
And even as plain text, it only seems confusing. Most other
urls here, and in HISTORY, don't have it either.
* Remove version numbers from the "External libraries" message.
We generally announce upgrades in the "New features" section.
Having to keep this section up to date as we upgrade libraries
seems unnecessary.
Change-Id: I4a8a75193cf6723ae734067f5d91ffa75692b5fd
jenkins-bot [Tue, 16 Dec 2014 18:42:26 +0000 (18:42 +0000)]
Merge "Update RELEASE-NOTES for wikimedia/cdb package rename"
jenkins-bot [Tue, 16 Dec 2014 18:36:57 +0000 (18:36 +0000)]
Merge "Deprecate wfErrorLog"
Kunal Mehta [Tue, 16 Dec 2014 18:31:13 +0000 (10:31 -0800)]
Update RELEASE-NOTES for wikimedia/cdb package rename
Change-Id: Ic71087e3b72566771b184bbe31bf766886401ffc
jenkins-bot [Tue, 16 Dec 2014 18:01:28 +0000 (18:01 +0000)]
Merge "Create a generic UDP transport class"
Bryan Davis [Mon, 15 Dec 2014 23:12:57 +0000 (16:12 -0700)]
Deprecate wfErrorLog
When a logging service other than MWLoggerLegacySpi is used, the
behavior of wfErrorLog is not guaranteed.
Change-Id: I8543bfd556aa752665f7a3daa855d3c2f7fc8956
jenkins-bot [Mon, 15 Dec 2014 22:56:59 +0000 (22:56 +0000)]
Merge "Revert "SECURITY: Do not show log action if revdeleted" and fix UI message"
Bryan Davis [Mon, 15 Dec 2014 22:05:13 +0000 (15:05 -0700)]
Create a generic UDP transport class
Code moved from MWLoggerLegacyLogger::emit(), which was formerly
in wfErrorLog().
Bug: T74572
Bug: T78599
Change-Id: I9e0e63d41bed6ccb468f3a9f1d52f156acc355a8
Brad Jorsch [Mon, 15 Dec 2014 21:59:42 +0000 (16:59 -0500)]
Normalize "\r" newlines in preSaveTransform
The behavior of the different preprocessors differs when given \r or
\r\n newlines. We already normalize the latter here, so may as well do
the former here too.
Bug: T78488
Change-Id: Id6390f64a73ea01088729f25d79103388c1fe7e8
kaldari [Mon, 15 Dec 2014 21:46:02 +0000 (13:46 -0800)]
Fixing wikitable border formatting in shared.css
Order of parameters was wrong.
Change-Id: I55671add3b35aaa3a78dc7d8c6ec01bae90f0724
Translation updater bot [Mon, 15 Dec 2014 20:53:51 +0000 (21:53 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I9709428a8db4ec79a2471ff8ec835d186995c82c
umherirrender [Mon, 15 Dec 2014 20:04:54 +0000 (21:04 +0100)]
Use Context in Article::delete for messages
Also escape a 'word-separator' message while at the line
Change-Id: If6212dfa685378978b61755cc56fe6d88971d625
Kevin Israel [Fri, 12 Dec 2014 07:49:46 +0000 (02:49 -0500)]
EditPage: Don't warn if the page already redirects to itself
Follows-up
02660685708747d5.
Also improved the wording of the "selfredirect" message.
Change-Id: I89a4647c03ccc31db4812dedac107869b2721833
Niklas Laxström [Sat, 6 Dec 2014 09:50:10 +0000 (10:50 +0100)]
Skin: handle invalid titles gracefully
Linker::link throws a notice if given null instead of title. Title
is constructed based on messages, so it can easily be null.
Change-Id: I5451135966cbb3bbd09d2568cec6b936f3b88aa3
Kunal Mehta [Mon, 15 Dec 2014 18:32:38 +0000 (10:32 -0800)]
MessageCache: Improve GlobalTitleFail log message
Same as
18d952dbcb6c7
Change-Id: Iabb1eb7481026cfdf0610b0125d5b577febcc0f4
Brad Jorsch [Mon, 15 Dec 2014 16:04:57 +0000 (11:04 -0500)]
API: Don't use an empty LinkBatch in ApiOpenSearch, part 2.
While Ie4609b08 took care of the empty $titles case, we get the same
problem if $titles is non-empty but contains only Special-namespace
titles.
Bug: T78074
Change-Id: Ic6572628e1da9953ef8212e49d4944e94d799f44
jenkins-bot [Mon, 15 Dec 2014 16:45:25 +0000 (16:45 +0000)]
Merge "Fix prefix search for special pages"
Nik Everett [Fri, 12 Dec 2014 22:24:01 +0000 (17:24 -0500)]
Fix prefix search for special pages
Prefix search for special pages was returning only the first match.
Change-Id: I5849696de76ca588f7e626d7da319b8bddb3dce9
Roan Kattouw [Mon, 15 Dec 2014 15:34:21 +0000 (16:34 +0100)]
Followup
cf5f641: pass $params by reference again
&$params was changed to $params, but hooks.txt still documents
this parameter as being passed by reference, and VipsScaler expects this.
Giuseppe and I suspect this may be what's causing the HHVM segfaults
we're seeing in beta labs.
Change-Id: Ib018f23bc44c247aefc277a0c75ff8577f309ab4
jenkins-bot [Mon, 15 Dec 2014 15:24:25 +0000 (15:24 +0000)]
Merge "Made StashEdit log a bit less verbose"
jenkins-bot [Mon, 15 Dec 2014 08:58:23 +0000 (08:58 +0000)]
Merge "Add better error message for files which exceeds $wgMaxImageArea"
jenkins-bot [Mon, 15 Dec 2014 08:34:53 +0000 (08:34 +0000)]
Merge "Explaining why user groups are sometimes returned by getRestrictions"
umherirrender [Wed, 25 Jun 2014 19:30:08 +0000 (21:30 +0200)]
Add better error message for files which exceeds $wgMaxImageArea
Added a TransformTooBigImageAreaError to allow setting an extra message.
Added also size-*pixel messages to show the value of $wgMaxImageArea
with some formatting.
This error is still throwing for all files, to fix bug T34387 this needs
a follow up with a proper check. I am not sure, if a File::isLocal() is
okay, because files from a DBForeignRepo maybe transformed on the same
server, so the check needs to be done also for this. For APIForeignRepo
the check is done on the foreign server.
Change-Id: Ieba12e424c8bddb1961a30d3f9ea5c8ff241abb5
jenkins-bot [Mon, 15 Dec 2014 03:06:44 +0000 (03:06 +0000)]
Merge "SpecialBlockList: Remove unused message 'infiniteblock' in formatValue()"
umherirrender [Sun, 14 Dec 2014 11:32:02 +0000 (12:32 +0100)]
SpecialBlockList: Remove unused message 'infiniteblock' in formatValue()
Change-Id: I24bf357386366e1bbe3ec1e5463b7b6bba9df0e8
Bryan Davis [Sat, 13 Dec 2014 00:08:08 +0000 (17:08 -0700)]
Add findVariantLink to StubUserLang
Add the full signature of Language::findVariantLink to StubUserLang so
that pass-by-reference variables are properly passed to the un-stubbed
Language object.
Bug: T78427
Change-Id: I51f57a17c814c43742f514df0e42a1760c406c48
Translation updater bot [Sun, 14 Dec 2014 21:00:01 +0000 (22:00 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I6a7a02bb4f5a4f6be8d5af9a8bba62cd0e5d20e4
Niklas Laxström [Sat, 6 Dec 2014 09:48:23 +0000 (10:48 +0100)]
Escape parentheses message on watchlist pages
Change-Id: Ie9943d7da81d16fcd95558f681af68ef9d392bfe
kaldari [Fri, 12 Dec 2014 22:24:54 +0000 (14:24 -0800)]
Explaining why user groups are sometimes returned by getRestrictions
Title::getRestrictions is assumed to return user rights, but in most
real contexts it actually returns user groups. This is super
confusing and has caused serious permission bugs. Adding an
explanation to the function comments.
Change-Id: I58013ba5e553d1feecacf6bfef066e1569fcc236
Bartosz Dziewoński [Sat, 13 Dec 2014 19:19:05 +0000 (20:19 +0100)]
Correct documentation for $wgResourceModuleSkinStyles
Change-Id: I56195b2193477f8f7ff2b56b241702b0dbd7de0c