From: Antoine Musso <hashar@free.fr>
Date: Sat, 7 Jul 2012 18:09:45 +0000 (+0200)
Subject: CLI install exited with 0 status code
X-Git-Tag: 1.31.0-rc.0~23102^2
X-Git-Url: http://git.cyclocoop.org/%22%20.%20generer_url_ecrire%28%22articles%22%2C%22id_article=%24ze_article%22%29%20.%20%22?a=commitdiff_plain;h=406988f0993ec842a9a794fbc343be56aadeb070;p=lhc%2Fweb%2Fwiklou.git

CLI install exited with 0 status code

The CliInstaller used the '0' exit code whenever the status was not OK.
That makes third party script assuming the install actually ran fine
since a 0 exit code is mostly considered as a success. By sending an
error code > 0 (here 1), our automatic installers will be able to catch
the failure and stop proceeding.

I had that issue with a Jenkins job which ran the CLI installer and kept
continuing although there was an error about LocalSettings.php already
existing.

Change-Id: I4f4727df85c09c0a04e4630df91c6213dfce6e9a
---

diff --git a/includes/installer/CliInstaller.php b/includes/installer/CliInstaller.php
index 752e2149ba..28b34a8fe7 100644
--- a/includes/installer/CliInstaller.php
+++ b/includes/installer/CliInstaller.php
@@ -187,7 +187,7 @@ class CliInstaller extends Installer {
 
 		if ( !$status->isOk() ) {
 			echo "\n";
-			exit;
+			exit( 1 );
 		}
 	}