jenkins-bot [Wed, 28 Nov 2018 23:52:05 +0000 (23:52 +0000)]
Merge "Drop ct_tag column from change_tag table"
jenkins-bot [Wed, 28 Nov 2018 23:52:00 +0000 (23:52 +0000)]
Merge "Drop $wgChangeTagsSchemaMigrationStage"
jenkins-bot [Wed, 28 Nov 2018 22:32:50 +0000 (22:32 +0000)]
Merge "Default $wgCommentTableSchemaMigrationStage to MIGRATION_NEW"
jenkins-bot [Wed, 28 Nov 2018 22:32:44 +0000 (22:32 +0000)]
Merge "SQLite: Split actor and comment filearchive updates to a separate file"
Amir Sarabadani [Wed, 14 Nov 2018 20:20:11 +0000 (21:20 +0100)]
Drop ct_tag column from change_tag table
Bug: T194163
Change-Id: I05d43510b51a67733b0107f0a768e261fe8ddabd
Amir Sarabadani [Wed, 14 Nov 2018 22:04:29 +0000 (23:04 +0100)]
Drop $wgChangeTagsSchemaMigrationStage
Bug: T194163
Change-Id: Ieb6cc60cacf9dd0d86641b1be817249cdce42112
jenkins-bot [Wed, 28 Nov 2018 19:55:12 +0000 (19:55 +0000)]
Merge "Add block notice stats on EditPage."
jenkins-bot [Wed, 28 Nov 2018 19:31:08 +0000 (19:31 +0000)]
Merge "Don't indicate partial blocks on Special:ActiveUsers"
Brad Jorsch [Wed, 7 Nov 2018 19:50:27 +0000 (14:50 -0500)]
Default $wgCommentTableSchemaMigrationStage to MIGRATION_NEW
WRITE_NEW mode seems to be working well on Wikimedia sites. Let's change
the default to MIGRATION_NEW so existing installs and Wikimedia CI will
start using the new code rather than the old.
This also fixes some unit tests that were broken with MIGRATION_NEW, and
updates some that were forcing MIGRATION_OLD to force MIGRATION_NEW
instead.
Bug: T166733
Change-Id: I7bf4ad0105dd1f6cc49eba3ddcb7a51badcd5ed3
Depends-On: I30f7cdcc3875f3f7af116c1e41e88f62ab9e91d0
Brad Jorsch [Wed, 28 Nov 2018 18:53:17 +0000 (13:53 -0500)]
SQLite: Split actor and comment filearchive updates to a separate file
On a fresh install, update.php will apply patch-editsummary-length.sql
even though it doesn't need to. But this partially wipes out the new schema from
tables.sql, and the omnibus comment and actor table patches don't detect
this, leading to filearchive missing the new fields.
Unlike the case with patch-add-3d.sql in I335cb8d9, here the patch does
make a change (if only a tiny one): fa_deleted_reason changes from TEXT
to BLOB.
Change-Id: I08047ff1207d471660365c0eb3faabc0b47746bb
Thalia [Mon, 26 Nov 2018 14:00:35 +0000 (14:00 +0000)]
Don't indicate partial blocks on Special:ActiveUsers
Only indicate sitewide blocks here.
Bug: T210391
Change-Id: I01d2fa6e326722d85652d96842e968c80d034274
Ed Sanders [Wed, 28 Nov 2018 11:29:58 +0000 (11:29 +0000)]
Fix typo in mw.Title test
Change-Id: I344515458a5760f93be2294c431b27c8afae46c5
Dayllan Maza [Thu, 8 Nov 2018 04:03:53 +0000 (23:03 -0500)]
Add block notice stats on EditPage.
Monitoring block notices is behind $wgEnableBlockNoticeStats config
flag which is set to false by default.
The reason behind this metric is to get an idea on how
frequently blocked users attempt to edit a page. Similar tracking
is being added to MobileFrontend and VisualEditor.
Bug: T201718
Change-Id: I6bd1c95548616677e1f72ba6bcfc6f2b551c1ca6
jenkins-bot [Wed, 28 Nov 2018 01:42:12 +0000 (01:42 +0000)]
Merge "SQLite: Make patch-add-3d.sql a no-op"
Ed Sanders [Tue, 27 Nov 2018 22:36:25 +0000 (22:36 +0000)]
eslint: Drop 'dot-notation' rule
Bug: T210552
Change-Id: I07620ed2e3a1acfd3193e411c8369722ae751ffa
jenkins-bot [Tue, 27 Nov 2018 21:39:50 +0000 (21:39 +0000)]
Merge "SpecialPreferences: Make save button bar sticky"
jenkins-bot [Tue, 27 Nov 2018 21:20:40 +0000 (21:20 +0000)]
Merge "ApiSandbox: Fix sticky value for Webkit"
jenkins-bot [Tue, 27 Nov 2018 21:14:52 +0000 (21:14 +0000)]
Merge "Fix global variable name typo in LocalIdLookupTest.php"
jenkins-bot [Tue, 27 Nov 2018 20:59:37 +0000 (20:59 +0000)]
Merge "Don't indicate partial blocks on Special:ListUsers"
Translation updater bot [Tue, 27 Nov 2018 20:57:42 +0000 (21:57 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I1a1e1cf1ee78dc6cb1bafe95a6fae84a4aef558b
Volker E [Tue, 27 Nov 2018 20:26:27 +0000 (12:26 -0800)]
ApiSandbox: Fix sticky value for Webkit
Change-Id: I86dbfc259630f3e1f3de7d4f4f7bb4fc70588fb5
Ed Sanders [Tue, 6 Nov 2018 13:31:47 +0000 (13:31 +0000)]
SpecialPreferences: Make save button bar sticky
Enable `position: sticky` on preferences buttons and degrade
gracefully in unsupported browsers, where this results in no
change.
Bug: T205866
Change-Id: Ic98a9d94d3136a4003370cf0e2a8efb7ae1a3f38
Alangi Derick [Tue, 27 Nov 2018 15:47:07 +0000 (16:47 +0100)]
Fix global variable name typo in LocalIdLookupTest.php
Per @Thiemo and @Anomie's comments on the patch, droppping dependency
of the test value to not be a global, using "dummy" in this case.
Bug: T210512
Change-Id: I26aff5fe4782837a8f52a102ae1bdbac49b748bc
jenkins-bot [Tue, 27 Nov 2018 19:14:12 +0000 (19:14 +0000)]
Merge "API: Add exception class as data to internal_api_error codes"
jenkins-bot [Tue, 27 Nov 2018 19:08:25 +0000 (19:08 +0000)]
Merge "API: Validate API error codes"
jenkins-bot [Tue, 27 Nov 2018 18:49:25 +0000 (18:49 +0000)]
Merge "Accept BCP 47 codes in LanguageConverter rules"
jenkins-bot [Tue, 27 Nov 2018 18:04:46 +0000 (18:04 +0000)]
Merge "Implement Title.wantSignaturesNamespace in JS"
Ed Sanders [Tue, 27 Nov 2018 17:25:52 +0000 (17:25 +0000)]
Implement Title.wantSignaturesNamespace in JS
Change-Id: Ib2faa22c429096d545ddb829a6b4025427ad6071
Subramanya Sastry [Tue, 27 Nov 2018 17:05:36 +0000 (12:05 -0500)]
Sync up with Parsoid parserTests.txt
This now aligns with Parsoid commit
463678ed5c83764a3558fec13cea07825a4fddd4
Change-Id: I5bd67b9f20ee9cda2c1141670ab140d65f8a2cc0
jenkins-bot [Tue, 27 Nov 2018 16:28:01 +0000 (16:28 +0000)]
Merge "Do not ignore the 'Prevent this user from editing his own talk page while blocked' option on partial blocks."
jenkins-bot [Tue, 27 Nov 2018 16:21:41 +0000 (16:21 +0000)]
Merge "Quoted attributes don't need to be followed by a space"
jenkins-bot [Tue, 27 Nov 2018 15:47:50 +0000 (15:47 +0000)]
Merge "Parse wikitext in gallery caption"
jenkins-bot [Tue, 27 Nov 2018 15:32:44 +0000 (15:32 +0000)]
Merge "Protect legacy URL parameter syntax in link and alt options"
David Barratt [Tue, 27 Nov 2018 06:43:21 +0000 (01:43 -0500)]
Do not ignore the 'Prevent this user from editing his own talk page while
blocked' option on partial blocks.
Partial blocks currently ignore this option as it gets into an edge case. The
option should take precidence if it is true, but should be ignored if it is
false. On sitewide blocks, the option should always be honored.
Bug: T210475
Change-Id: I33177b48a5c261ec3f510ce01998c1b096077b85
C. Scott Ananian [Mon, 26 Nov 2018 17:53:51 +0000 (12:53 -0500)]
Protect legacy URL parameter syntax in link and alt options
HTML doesn't allow certain semicolon-less HTML entities in attribute
values to avoid breaking legacy markup like:
<a href="http://example.com?foo¶m=bar">...</a>
(Note that the & in that URL is not properly entity-escaped as `&`.)
Unlike wikitext, HTML generally allows semicolon-less legacy entities
in text.
Our alt and link option processing shove text through
Sanitizer::stripAllTags, which does entity decoding including these
legacy semicolon-less entities. Wikitext doesn't allow semicolon-less
entities, so escape & characters where appropriate to protect alt/link
options and avoid breaking URLs.
This was a "regression" in how alt options were handled starting in
ddb4913f53624c8ee0a2a91bd44bf750e378569d when we switched to using
Remex for Sanitizer::stripAllTags -- semicolon-less entities (previously
invalid in wikitext) were now being decoded when stripAllTags was
called on alt text. This change became a problem when
ad80f0bca27c2b0905b2b137977586bfab80db34 sent link option text through
Sanitizer::stripAllTags (with the new semicolon-less entity decode)
instead of PHP's strip_tags (which, in addition to its other faults,
doesn't do entity decode at all). This suddenly started decoding
"non-wikitext" entities like `¶` inside URLs, breaking links.
Filed T210437 as a follow-up to consider changing the behavior
of Sanitizer::stripAllTags() globally to prevent it from decoding
semicolon-less entities for all callers.
Bug: T209236
Change-Id: I5925e110e335d83eafa9de935c4e06806322f4a9
jenkins-bot [Tue, 27 Nov 2018 14:36:30 +0000 (14:36 +0000)]
Merge "Preferences: Remove unused message for RC/Watchlist opt-out section"
jenkins-bot [Tue, 27 Nov 2018 00:33:17 +0000 (00:33 +0000)]
Merge "Migrate ApiQueryLogEvents from tag_summary to change_tag"
jenkins-bot [Tue, 27 Nov 2018 00:33:11 +0000 (00:33 +0000)]
Merge "Split ChangeTags::modifyDisplayQuery() to two smaller functions"
jenkins-bot [Tue, 27 Nov 2018 00:27:32 +0000 (00:27 +0000)]
Merge "rdbms: rename setDomainPrefix to setLocalDomainPrefix in ILoadBalancer"
jenkins-bot [Mon, 26 Nov 2018 23:00:54 +0000 (23:00 +0000)]
Merge "Add logging for redundant parsing to WikitextContent."
jenkins-bot [Mon, 26 Nov 2018 22:53:34 +0000 (22:53 +0000)]
Merge "Use stashed ParserOutput during saving."
daniel [Thu, 15 Nov 2018 15:41:29 +0000 (16:41 +0100)]
Add logging for redundant parsing to WikitextContent.
Bug: T205369
Change-Id: I67bfdc0340e0ddc1ecdaf3323f2171b2e752c680
Translation updater bot [Mon, 26 Nov 2018 21:05:32 +0000 (22:05 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Ibc3a851342d0559915206fc3b9ef2ba47fb1a065
jenkins-bot [Mon, 26 Nov 2018 20:30:31 +0000 (20:30 +0000)]
Merge "mediawiki.ui: Remove unused `.mw-ui-checked` class"
jenkins-bot [Mon, 26 Nov 2018 19:09:30 +0000 (19:09 +0000)]
Merge "Install wikimedia/password-blacklist 0.1.3 (fix-up)"
Brad Jorsch [Wed, 21 Nov 2018 16:13:52 +0000 (11:13 -0500)]
SQLite: Make patch-add-3d.sql a no-op
On a fresh install, update.php will apply patch-add-3d.sql even though
it doesn't need to. But this partially wipes out the new schema from
tables.sql, and the omnibus comment and actor table patched don't detect
this, leading to image, oldimage, and filearchive missing the new
fields.
Since SQLite doesn't actually care about the values in the ENUM type
(it's just an alias for TEXT), let's just make patch-add-3d.sql do
nothing.
Change-Id: I335cb8d9626f535a66b0fe18e051640b22848ef7
Roan Kattouw [Mon, 26 Nov 2018 18:43:59 +0000 (10:43 -0800)]
Preferences: Remove unused message for RC/Watchlist opt-out section
Also remove the mapping from "optoutwatchlist" and "optoutrc" to
"opt-out".
Bug: T207741
Change-Id: I7aecf11496d2f13d11944b5ce1910362c4268ad4
Follows-Up: I8d6795f5e39fa5bceabd2da5e6a5b43d009a3bab
Brad Jorsch [Mon, 26 Nov 2018 18:31:41 +0000 (13:31 -0500)]
API: Add exception class as data to internal_api_error codes
The code for all uncaught exceptions will in the future be
"internal_api_error". If the client needs to know the class name for
some reason, it can check the new 'errorclass' data item on the error.
Change-Id: Ia9e32bbb8d17692203f4fbcee53a20e87be1776e
Brad Jorsch [Wed, 7 Nov 2018 16:25:40 +0000 (11:25 -0500)]
API: Validate API error codes
Validate them in ApiMessageTrait when the message is created, and again
in ApiMain before they're included in the header.
This also introduces an "api-warning" log channel, since "api" is too
spammy for real use, and converts a few existing things to use it.
Bug: T208926
Change-Id: Ib2d8bd4d4a5d58af76431835ba783c148de7792a
Depends-On: Iced44f2602d57eea9a2d15aee5b8c9a50092b49c
Depends-On: I5c2747f527c30ded7a614feb26f5777d901bd512
Depends-On: I9c9bd8f5309518fcbab7179fb71d209c005e5e64
Aaron Schulz [Tue, 20 Nov 2018 23:34:11 +0000 (15:34 -0800)]
rdbms: rename setDomainPrefix to setLocalDomainPrefix in ILoadBalancer
Update CloneDatabase and unit test callers, which are the only things
that are likely to call it.
Change-Id: Idbc6d2965cd3828c2c6d23012319bbf0fc3ffa4a
jenkins-bot [Mon, 26 Nov 2018 17:08:52 +0000 (17:08 +0000)]
Merge "Sync up with Parsoid parserTests.txt"
jenkins-bot [Mon, 26 Nov 2018 16:51:39 +0000 (16:51 +0000)]
Merge "rdbms: add ILBFactory::redefineLocalDomain method"
Thalia [Fri, 23 Nov 2018 15:56:42 +0000 (15:56 +0000)]
Don't indicate partial blocks on Special:ListUsers
Only indicate that a user is blocked if their block
is sitewide.
Bug:T208276
Change-Id: Iee032a126bf1a7a2aa1049196b79a9e269d83243
Subramanya Sastry [Mon, 26 Nov 2018 15:14:03 +0000 (10:14 -0500)]
Sync up with Parsoid parserTests.txt
This now aligns with Parsoid commit
c900a0c7dbd27cdba09d43971411e6849be73558
Change-Id: I7d7049e4cfbe50d7fe9c90894a6879e1694a3078
Kunal Mehta [Mon, 26 Nov 2018 02:35:43 +0000 (18:35 -0800)]
Install wikimedia/password-blacklist 0.1.3 (fix-up)
When rebasing/updating
519ff1a402992, I forgot to update composer.json to use
0.1.3 (mentioned in RELEASE-NOTES and the commit message) instead of 0.1.2.
mediawiki/vendor already has 0.1.3.
Change-Id: Ica042a6d2b99e1640b74dcb7290314bd3b0d27c7
Volker E [Mon, 26 Nov 2018 02:04:17 +0000 (18:04 -0800)]
mediawiki.ui: Remove unused `.mw-ui-checked` class
Removing `.mw-ui-checked` as it is unused in current codebase.
Change-Id: I7a03215fae0b17dac41d85ffe1bb2634ec09f5c2
Translation updater bot [Sun, 25 Nov 2018 21:17:43 +0000 (22:17 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I6bc49b217c97059665bc032641d01c1365c8e263
jenkins-bot [Sun, 25 Nov 2018 19:03:42 +0000 (19:03 +0000)]
Merge "mediawiki.ui: Move remaining mixin to buttons.less; remove mixins.less"
jenkins-bot [Sun, 25 Nov 2018 00:20:12 +0000 (00:20 +0000)]
Merge "Add PasswordPolicy to check the password isn't in the large blacklist"
Reedy [Mon, 26 Feb 2018 00:56:52 +0000 (00:56 +0000)]
Add PasswordPolicy to check the password isn't in the large blacklist
Add wikimedia/password-blacklist 0.1.3, which contains 100,000 common passwords
Bug: T151425
Change-Id: I80572fcee6d23ea04ad9ee683157bab9378b660e
Depends-On: I8aea5a44248da9bb9ff7b328679bff6fcf41750d
jenkins-bot [Sat, 24 Nov 2018 23:40:34 +0000 (23:40 +0000)]
Merge "ApiQueryBlocks.php: Call static function statically"
Bjornskjald [Wed, 21 Nov 2018 22:48:16 +0000 (23:48 +0100)]
Make "→" link to page section on History page larger by adding section name to it
Bug: T165189
Change-Id: I1f845592bd3de342fda84b60fc412055973950fd
jenkins-bot [Fri, 23 Nov 2018 23:16:10 +0000 (23:16 +0000)]
Merge "parser: Remove aliases for __EXPECTUNUSEDCATEGORY__"
jenkins-bot [Fri, 23 Nov 2018 23:15:42 +0000 (23:15 +0000)]
Merge "mediawiki.special.apisandbox: Fix code for ES5 environments (IE 11)"
jenkins-bot [Fri, 23 Nov 2018 23:15:37 +0000 (23:15 +0000)]
Merge "Remove unneeded "eslint-disable no-restricted-properties" from several files"
Volker E [Fri, 23 Nov 2018 19:24:53 +0000 (11:24 -0800)]
mediawiki.ui: Move remaining mixin to buttons.less; remove mixins.less
mediawiki.ui mixins are arbitrarily increasing code complexity.
Moving the remaining primary button mixin to the corresponding
buttons.less file and removing mixins.less as logical consequence.
Change-Id: I1299e210a7c8a403e859915bfed3ebecbf1f2f14
Timo Tijhof [Fri, 23 Nov 2018 21:13:51 +0000 (21:13 +0000)]
parser: Remove aliases for __EXPECTUNUSEDCATEGORY__
Follows-up
4985ce513469fa82a132139a41c2854504475e4a.
This is a brand new magic word, with no history or concerns for
backward-compatibility. Introducing it with four possible ways to
to use it, I think leads to less ideal experience for end-users.
I recognise that this is an attempt to make it easier for users
to get this magic word correctly working, even when a user guesses
the name incorrectly. This is a valid problem but, I do not think
adding more syntax is the right answer to that problem.
Introducing four ways to do the same thing I believe would make it
more difficult to learn the syntax, because they also have to
remember the other variations when encountering it from other users.
I also believe that the value we gain from a user getting it right
via an alias of this keyword is, shadowed by the loss in value
from a user when they get it wrong for all the other keywords.
This is because they'd likely expect the same four varations
(MULTIWORD, MULTI_WORD, MULTIPLE_WORD, MULTIPLEWORD) to apply
there as well. It creates expectations that we are not matching.
I think it is worth investigating this problem, and having four
extra aliases in the syntax could be one of the proposals to solve
that problem. However, we should discuss that on Phabricator and,
if we agree to it, apply it universally, not just to one keyword.
Bug: T96041
Change-Id: I5621cee70e6f791a161f21ebda8c5a7243e5947e
jenkins-bot [Fri, 23 Nov 2018 20:55:49 +0000 (20:55 +0000)]
Merge "Localisation updates from https://translatewiki.net."
Translation updater bot [Fri, 23 Nov 2018 20:54:38 +0000 (21:54 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I941735cac9508aa5825329ba77ca760bf7250769
Bartosz Dziewoński [Fri, 23 Nov 2018 19:45:19 +0000 (20:45 +0100)]
mediawiki.special.apisandbox: Fix code for ES5 environments (IE 11)
The method Array#findIndex was introduced in ES6 [1] and we still
support browsers that only implement ES5, like Internet Explorer 11.
[1] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/findIndex#Specifications
Change-Id: Idaebef7c91f2683099ab4980833ed76f0e3b51eb
Bartosz Dziewoński [Fri, 23 Nov 2018 19:39:13 +0000 (20:39 +0100)]
Remove unneeded "eslint-disable no-restricted-properties" from several files
This was added in
160fc196fe43300843cc6cb68ad912051b7fb1d9 to suppress
warnings about usage of jQuery utility methods.
In eslint-config-wikimedia v0.9.0, the jQuery utility methods got its
own warning code, and change
3e4e0a5774cb7531c8be7516e57550477489753d
updated all files that use them to suppress each individual warning,
but did not remove this now-unnecessary global suppression.
Currently (since
6ad73362f376a0399bd1568fe7bbf40425737311), these
comments are instead incorrectly suppressing warnings about usage of
JavaScript methods introduced in ES6 and later.
Change-Id: Ie70aeb325946c8e6b62333e1ca1515cd0f5f326b
Volker E [Wed, 21 Nov 2018 23:13:31 +0000 (15:13 -0800)]
mediawiki.ui: Fix quiet button styling and remove mixins
Quiet progressive and destructive buttons are applied right visual
properties.
Mixins make only sense when they are called several times, it
diminishes readability here and unnecessarily complicates the lookup
of values being set correctly. Therefore removing them.
Also introducing selected variables following WikimediaUI Base naming
convention in order to be replaced easily in future.
Bug: T210115
Change-Id: Iee1559ed185a12bf77fc68b6ef7f10e9a0536b07
jenkins-bot [Fri, 23 Nov 2018 17:28:51 +0000 (17:28 +0000)]
Merge "Replace mixin by inline styles"
jenkins-bot [Fri, 23 Nov 2018 17:28:47 +0000 (17:28 +0000)]
Merge "mediawiki.ui: Remove `.agora-inline-label-styling()` & `.mw-ui-radio-label`"
jenkins-bot [Fri, 23 Nov 2018 17:14:55 +0000 (17:14 +0000)]
Merge "Avoid HTML string parsing"
jenkins-bot [Fri, 23 Nov 2018 14:39:20 +0000 (14:39 +0000)]
Merge "build: Use eslint-config-wikimedia v0.9.0 and make pass"
Ed Sanders [Wed, 21 Nov 2018 21:14:26 +0000 (21:14 +0000)]
Avoid HTML string parsing
Identified using https://github.com/wikimedia/eslint-plugin-jquery/pull/12
Change-Id: Ic3ac53804085aa61be54793e7e5f27b23d99a560
Ed Sanders [Wed, 21 Nov 2018 11:28:28 +0000 (11:28 +0000)]
build: Use eslint-config-wikimedia v0.9.0 and make pass
Change-Id: I7b5d228a3de4b3006751a427dec907a5bebf2f51
Aaron Schulz [Mon, 19 Nov 2018 08:13:30 +0000 (00:13 -0800)]
rdbms: add ILBFactory::redefineLocalDomain method
This is intended for use with scripts like addWiki.php to avoid mismatched domain errors.
Bug: T209483
Change-Id: Ie24f83f4e0fad7b01690d2055e1529a4cb0275b5
jenkins-bot [Thu, 22 Nov 2018 22:51:28 +0000 (22:51 +0000)]
Merge "rdbms: add DBConnRef sanity check to LoadBalancer::closeConnection"
jenkins-bot [Thu, 22 Nov 2018 21:40:09 +0000 (21:40 +0000)]
Merge "Avoid post-send DBPerformance log warnings for page rollback"
jenkins-bot [Thu, 22 Nov 2018 21:13:30 +0000 (21:13 +0000)]
Merge "Differentiate comments with and without brackets"
Translation updater bot [Thu, 22 Nov 2018 20:54:27 +0000 (21:54 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I8237c9d63b01e92747608f9e226339db009fd601
jdlrobson [Thu, 22 Nov 2018 19:39:48 +0000 (11:39 -0800)]
Differentiate comments with and without brackets
Per T205581#
4768548 cached HTML might render a comment with
double brackets in the text. The CSS selector should not apply
there so a new class is used.
Using a BEM convention for the time being. This class can be
removed in future if needed.
Bug: T205581
Change-Id: If1552d6ddd4729b8beca45a1ca19ec6ce36e6118
Aaron Schulz [Mon, 19 Nov 2018 19:56:49 +0000 (11:56 -0800)]
Avoid post-send DBPerformance log warnings for page rollback
Change-Id: I3d4eafc7d9d04647955822d5100d8cf253d80c8a
daniel [Thu, 15 Nov 2018 16:40:53 +0000 (17:40 +0100)]
Use stashed ParserOutput during saving.
The code in DerivedPageDataUpdater that used the stashed ParserOutput from
ApiStashEdit::checkCache was accidentally broken when RevisionRenderer
was introduced in I871978bf79f67c9e7954fb3fc8528d6e365f2cc1.
This is likely the cause for the degraded save timing noted in T205369.
Bug: T205369
Change-Id: I6d8fdda73dccae08d18bfb528b948706f56ad2e0
Volker E [Thu, 22 Nov 2018 02:13:45 +0000 (18:13 -0800)]
Replace mixin by inline styles
Replacing `.agora-label-styling()` by inline styles.
It is not useful to have a mixin for this only used in two selectors
of forms.less
Change-Id: I807fdbdca11d2ad6fea120d76c3a56471260c8cb
Volker E [Thu, 22 Nov 2018 01:28:01 +0000 (17:28 -0800)]
mediawiki.ui: Remove `.agora-inline-label-styling()` & `.mw-ui-radio-label`
Removing unused `.agora-inline-label-styling()` & `.mw-ui-radio-label`.
CodeSearch shows no results for both aside of self-referencing.
Change-Id: Id339a979a49a0ceeaecb14b54735a198c95c6f13
jenkins-bot [Thu, 22 Nov 2018 01:22:05 +0000 (01:22 +0000)]
Merge "mediawiki.ui: Remove deprecated color variables"
Volker E [Thu, 22 Nov 2018 00:57:29 +0000 (16:57 -0800)]
mediawiki.ui: Remove deprecated color variables
They became deprecated in Iaef72470c59665. It's time to remove them.
Bug: T210118
Change-Id: Ibc761a2cdc8d04213d149851129cd51ee4661899
Translation updater bot [Wed, 21 Nov 2018 21:09:35 +0000 (22:09 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I52023afe0a2109f4f7acae9f15542b34aacd1a98
jenkins-bot [Wed, 21 Nov 2018 20:47:35 +0000 (20:47 +0000)]
Merge "mediawiki.ui: Let quiet button border remain"
jenkins-bot [Wed, 21 Nov 2018 20:31:08 +0000 (20:31 +0000)]
Merge "Remove hardcoded parentheticals from ChangesList "comments""
Volker E [Wed, 21 Nov 2018 19:44:49 +0000 (11:44 -0800)]
mediawiki.ui: Let quiet button border remain
It's a better approach to let quiet button `border-width` remain for layout
predictability, only changing `border-color`.
Similar approach is taken in OOUI.
Also add `@border-width-base` variable similar to WikimediaUI so it
is easily replacible in in future.
Change-Id: I68d6bde72181004fcd8a0d3e0dee7d9d8e892eeb
jdlrobson [Fri, 21 Sep 2018 18:11:23 +0000 (11:11 -0700)]
Remove hardcoded parentheticals from ChangesList "comments"
From now on, the edit summary in ContribsPager results
will be wrapped in brackets via CSS pseudo elements.
Changes:
* Linker::revComment and Linker::commentBlock now accept a parameter which
can be used to disable wrapping in the text
* ContribsPager makes use of it
Bug: T205581
Change-Id: I60403a4a23d89107b7a28f0c12326d828a76614e
Volker E [Wed, 21 Nov 2018 18:35:54 +0000 (10:35 -0800)]
mediawiki.ui: Remove obsolete `text-shadow` from quiet and disabled buttons
Those properties have been overrides to the normal buttons old look,
they haven't been removed when the buttons were changed in
I25e5ce7e6fafc19d8b925b6918c98dd61b423d64.
Change-Id: I3aac8683ae7bd5402721dba23d0dbaf9d9c2a1ac
jenkins-bot [Wed, 21 Nov 2018 16:41:46 +0000 (16:41 +0000)]
Merge "Update wording for RC and Watchlist UI opt-out option"
jenkins-bot [Wed, 21 Nov 2018 09:29:47 +0000 (09:29 +0000)]
Merge "Convert $archivedRevisionCount to integer."
Aaron Schulz [Wed, 21 Nov 2018 07:06:22 +0000 (23:06 -0800)]
rdbms: add DBConnRef sanity check to LoadBalancer::closeConnection
Change-Id: I0473ffb1f89301530518f1921fe9d5ca68eb194c
jenkins-bot [Wed, 21 Nov 2018 00:50:04 +0000 (00:50 +0000)]
Merge "RELEASE-NOTES: Move image_comment_temp note following
8107e47"