Roan Kattouw [Fri, 12 Oct 2018 22:18:03 +0000 (15:18 -0700)]
Linker: Document parseComment() as returning HTML
It's not entirely clear from the documentation whether this method
returns wikitext or HTML, so make it explicit.
Change-Id: I094e370e921c43dd8c5dc4376b3dddd803665d90
jenkins-bot [Tue, 9 Oct 2018 20:38:31 +0000 (20:38 +0000)]
Merge "Use <div> wrappers instead of <p> in ProtectionForm"
jenkins-bot [Tue, 9 Oct 2018 19:56:22 +0000 (19:56 +0000)]
Merge "Localisation updates from https://translatewiki.net."
Translation updater bot [Tue, 9 Oct 2018 19:54:03 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ia87e35c10f78bea2f7107605bb1adcc00acccbd6
jenkins-bot [Tue, 9 Oct 2018 19:52:34 +0000 (19:52 +0000)]
Merge "RCFilters: Apply `pointer` cursor on Hamburger menu"
jenkins-bot [Tue, 9 Oct 2018 19:17:20 +0000 (19:17 +0000)]
Merge "Clean up ApiLoginTest"
jenkins-bot [Tue, 9 Oct 2018 18:21:55 +0000 (18:21 +0000)]
Merge "Improve exception message in DatabaseDomain"
jenkins-bot [Tue, 9 Oct 2018 18:12:21 +0000 (18:12 +0000)]
Merge "Make unclosed transaction errors more useful"
jenkins-bot [Tue, 9 Oct 2018 18:03:01 +0000 (18:03 +0000)]
Merge "maintenance: Detect "unknown module name" error in manageForeignResources"
Gergő Tisza [Tue, 9 Oct 2018 02:04:59 +0000 (19:04 -0700)]
Make unclosed transaction errors more useful
Move unclosed transaction error reporting to Database so it can
include information about the caller that started the transaction.
Change-Id: I834d957f172c03005de522f3029bb634b3c7220e
Aaron Schulz [Tue, 9 Oct 2018 00:34:22 +0000 (17:34 -0700)]
Improve exception message in DatabaseDomain
Change-Id: Ib45497388d07b0531cfe1c06349105e47b9fad08
Aryeh Gregor [Mon, 8 Oct 2018 11:29:47 +0000 (14:29 +0300)]
Clean up ApiLoginTest
Change-Id: Icd77f8a5ee0c26cfbd3cc8f220412cfa1bf49d60
C. Scott Ananian [Tue, 9 Oct 2018 15:57:03 +0000 (11:57 -0400)]
Sync up with Parsoid parserTests.txt
This now aligns with Parsoid commit
f6c64caaf1becc5b5780c871d495a3d9f5aac7a8
Change-Id: I0d2722c100b522c68a8e35a8701d5bf7ef80dccb
Volker E [Tue, 9 Oct 2018 04:01:19 +0000 (21:01 -0700)]
RCFilters: Apply `pointer` cursor on Hamburger menu
Bug: T196900
Change-Id: I53310b54616622b214a0a30f3bf826f48d05c7b1
jenkins-bot [Tue, 9 Oct 2018 02:32:14 +0000 (02:32 +0000)]
Merge "Update OOUI to v0.29.2"
jenkins-bot [Tue, 9 Oct 2018 02:28:04 +0000 (02:28 +0000)]
Merge "Make RefreshLinksJob MCR compliant."
jenkins-bot [Tue, 9 Oct 2018 01:44:03 +0000 (01:44 +0000)]
Merge "Revert "Re-enable tests from TitlePermissionTest""
Krinkle [Tue, 9 Oct 2018 01:21:00 +0000 (01:21 +0000)]
Revert "Re-enable tests from TitlePermissionTest"
It's still broken, and 4 days passed with broken Travis CI builds.
Re-reverting for now.
This reverts commit
589741b5417adbf0e3b0d72640ff6ff297e50141.
Change-Id: I85a0b02d3f32303a90118e2705a7b2afc721cb57
Bartosz Dziewoński [Mon, 8 Oct 2018 23:50:33 +0000 (01:50 +0200)]
Update OOUI to v0.29.2
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.29.2
Bug: T206344
Depends-On: I607825c7df3d843f80f8d151c5c79c39cd629c17
Change-Id: I6db8fbb28ae1c190b1d9e2b4d4defdb20579a169
Bartosz Dziewoński [Tue, 9 Oct 2018 00:00:50 +0000 (02:00 +0200)]
Fix parser test failure due to changed translation
The 'sr-ec' translation of 'editsectionhint' message was changed
in
dff3fa2d4bf2c68b2020ffbf965459fb2e71c50f.
Change-Id: Ibb6ad22e3926406a3e8267b87ffd39ab51663e63
Translation updater bot [Mon, 8 Oct 2018 20:53:21 +0000 (22:53 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I787568a8746dd03db3f5c2d1c75e248c5c4ce809
jenkins-bot [Mon, 8 Oct 2018 19:17:39 +0000 (19:17 +0000)]
Merge "Make SpecialPageTestBase always call parent::tearDown"
jenkins-bot [Mon, 8 Oct 2018 19:17:33 +0000 (19:17 +0000)]
Merge "Fix guarding of MySQL's numRows()"
jenkins-bot [Mon, 8 Oct 2018 18:17:44 +0000 (18:17 +0000)]
Merge "Suppress "Headers already sent" in PHP 7.2 too"
daniel [Mon, 8 Oct 2018 12:32:03 +0000 (14:32 +0200)]
Make RefreshLinksJob MCR compliant.
So far, RefreshLinksJob re-generated the ParserOutput ba calling
Content::getParserOutput. This only works for the main slot. It
needs to instead get the parser output for all slots combiend,
by using RevisionRenderer and RenderedRevision.
Bug: T174035
Change-Id: I253dda26bfa5aefa15f8b1dcc59e69fc7e9d0cb7
Aryeh Gregor [Mon, 8 Oct 2018 17:10:36 +0000 (20:10 +0300)]
Suppress "Headers already sent" in PHP 7.2 too
The "h" is now capitalized, so we need to update the regex.
Change-Id: I1111e1228868ec66d930c7a3b0d7972e5c6356b9
Aryeh Gregor [Mon, 8 Oct 2018 16:54:32 +0000 (19:54 +0300)]
Make SpecialPageTestBase always call parent::tearDown
Change-Id: Ifc244d5117e7da4bf46cdf273eca9fc4ae5c3a42
jenkins-bot [Mon, 8 Oct 2018 16:03:07 +0000 (16:03 +0000)]
Merge "Improve ApiFormatJson test coverage"
jenkins-bot [Mon, 8 Oct 2018 16:03:02 +0000 (16:03 +0000)]
Merge "Deprecate MediaWikiTestCase::stashMwGlobals"
Aryeh Gregor [Mon, 8 Oct 2018 10:42:20 +0000 (13:42 +0300)]
Improve ApiFormatJson test coverage
The only thing missing is tests for the rawfm paths, which I don't
understand well enough to test easily.
Change-Id: I08779391798b9d2d5eeb7e19ec4764059336069c
Tim Starling [Mon, 8 Oct 2018 03:46:37 +0000 (14:46 +1100)]
Fix guarding of MySQL's numRows()
It can be true for successful write queries, not just false.
f3a197e49b785 introduced a caller which calls numRows() on the return
value of CREATE TEMPORARY TABLE queries, and it improved guarding of
numRows() in the PostgreSQL and SQLite cases accordingly, but it
neglected MySQL.
Bug: T201900
Change-Id: I8ae754a2518d9e47b093c31c20d98daaba913513
Translation updater bot [Sun, 7 Oct 2018 19:55:00 +0000 (21:55 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I37d7b1dfa4bbe393b32d62f8f8ac564ebb24d149
Aryeh Gregor [Sun, 7 Oct 2018 12:26:18 +0000 (15:26 +0300)]
Deprecate MediaWikiTestCase::stashMwGlobals
This method encourages directly editing configuration variables. It's a
better idea to use setMwGlobals() (or other set wrappers) so that we can
be intelligent in the future, for instance resetting services after the
config change. Plus, a lot of the callers come out cleaner this way
anyway.
Depends-On: I8a1e81acc5c42a8d7f30938a72cface0acea4a70
Depends-On: I4105dbcf9c5399fe7239478c460ec57c015a98d4
Depends-On: I1b220996acf2f66cf7b0f092b341584663df32f9
Depends-On: Ie2d1ea65c0cb334bbde1666d00781474b7ac4dab
Change-Id: I23d77398e401f4986b1d5bd1c9e11a8a40da16f8
Translation updater bot [Sat, 6 Oct 2018 19:54:18 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ib87a638392b5f4d20ce69a0af2895692f11197d4
jhsoby [Mon, 27 Aug 2018 21:53:46 +0000 (23:53 +0200)]
Fix numerals for Saraiki
Change numerals from Persian numerals to
Eastern Arabic numerals.
Bug: T202943
Change-Id: I9ef7c18d40b9aa3f1c3b3db7407d3f61feb7fd1d
jenkins-bot [Sat, 6 Oct 2018 03:21:47 +0000 (03:21 +0000)]
Merge "messagecache: use MergeableUpdate for the deferred replace() update"
Timo Tijhof [Sat, 6 Oct 2018 03:05:38 +0000 (04:05 +0100)]
maintenance: Detect "unknown module name" error in manageForeignResources
Previously, `manageForeignResources.php update foo` would output
"Done!", which is very similar to "... updating foo\nDone!".
The module argument is now validated, just like how the
action argument was validated already.
Change-Id: Ia7c87de5d86b9d1a411485cac43b1529fe88a59f
jenkins-bot [Sat, 6 Oct 2018 00:09:41 +0000 (00:09 +0000)]
Merge "Add link to protect log to action=info"
jenkins-bot [Fri, 5 Oct 2018 23:26:26 +0000 (23:26 +0000)]
Merge "Remove trailing spaces from IP addr in Special:DeletedContributions"
Alex Ezell [Fri, 5 Oct 2018 21:32:00 +0000 (17:32 -0400)]
Replace Media namespace redirects with File namespace
If a user creates a redirect that goes to a [[Media:example.jpg]]
page, then an exception is thrown because NS_MEDIA is a virtual
namespace. This change catches this case and changes the namespace
to an NS_FILE namespace and the redirect works correctly. This
change only happens when we are dealing with a redirect so other
uses of the NS_MEDIA namespace shouldn't be affected.
Bug: T203942
Change-Id: Ia744059650e16510732a65d51b138b11cbd43eb4
Aaron Schulz [Thu, 4 Oct 2018 20:14:32 +0000 (13:14 -0700)]
messagecache: use MergeableUpdate for the deferred replace() update
This combines the load loop for multiple messages for a language code.
Bug: T203925
Bug: T193271
Change-Id: Ie5e1e83d6740344b7ca641c99fb3bd4ad5718492
Translation updater bot [Fri, 5 Oct 2018 19:56:02 +0000 (21:56 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I16181fad87c2d0afe3c43188c9f7807b6a953698
jenkins-bot [Fri, 5 Oct 2018 19:29:40 +0000 (19:29 +0000)]
Merge "UIDGenerator: Remove the clock skew problem"
jenkins-bot [Fri, 5 Oct 2018 19:28:48 +0000 (19:28 +0000)]
Merge "Write Latin and other scripts with captial letter"
jenkins-bot [Fri, 5 Oct 2018 19:03:26 +0000 (19:03 +0000)]
Merge "search: Fix DYM typos in widget"
Fomafix [Fri, 5 Oct 2018 16:37:53 +0000 (18:37 +0200)]
Write Latin and other scripts with captial letter
Change-Id: I16c660e54191b63cd6eb3407cb00504665930c4e
Alangi Derick [Fri, 5 Oct 2018 14:22:15 +0000 (15:22 +0100)]
Remove trailing spaces from IP addr in Special:DeletedContributions
* Trim "target" to remove trailing spaces from IP address in
Special:DeletedContributions that triggers MW internal error.
Bug: T187619
Change-Id: Ic6b0d8020553ecce4dcf97f9c78487d3174444d8
jenkins-bot [Fri, 5 Oct 2018 08:04:08 +0000 (08:04 +0000)]
Merge "wdio-mediawiki: Add 'fragment' parameter to Page"
jenkins-bot [Fri, 5 Oct 2018 06:59:36 +0000 (06:59 +0000)]
Merge "Localisation updates from https://translatewiki.net."
jenkins-bot [Fri, 5 Oct 2018 00:43:56 +0000 (00:43 +0000)]
Merge "Test ApiUnblock"
jenkins-bot [Fri, 5 Oct 2018 00:29:50 +0000 (00:29 +0000)]
Merge "Fix List* in MessagesKo.php"
Aryeh Gregor [Thu, 4 Oct 2018 12:57:10 +0000 (15:57 +0300)]
Test ApiUnblock
Full coverage (except for the examples/help URL).
Change-Id: I4c618506b5446680f06fa9b605d3babe7194de94
jenkins-bot [Thu, 4 Oct 2018 23:22:13 +0000 (23:22 +0000)]
Merge "filebackend: Add normalization for stat errors"
Timo Tijhof [Thu, 4 Oct 2018 18:54:36 +0000 (19:54 +0100)]
filebackend: Add normalization for stat errors
Bug: T205567
Change-Id: I75f1eb6dc2cbff0ea0dc0706cca0ad79c54fc612
jenkins-bot [Thu, 4 Oct 2018 21:37:00 +0000 (21:37 +0000)]
Merge "Enforce no-session constraint in opensearch_desc.php and profileinfo.php"
Translation updater bot [Thu, 4 Oct 2018 20:03:30 +0000 (22:03 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Idf339b32a190b7a770c0465e4545948861ab979d
jenkins-bot [Thu, 4 Oct 2018 19:53:45 +0000 (19:53 +0000)]
Merge "Clean up UIDGenerator field comments"
Timo Tijhof [Thu, 4 Oct 2018 00:38:45 +0000 (01:38 +0100)]
UIDGenerator: Remove the clock skew problem
In a nutshell:
This commmit removes the use of drifting microtime()
in favour of non-drifting time(). Then, we increase the size of
the counter by x1000, and consider every 1000 increments as 1ms
for the purposes of UUID.
Why:
This means we eliminate the whole code that can produce a fatal
exception when the clock drifts by more than we can wait for,
which puts us in a logical conundrum we can't get out of, hence
it previously fatalled.
Not aborting random end-user requests and jobs is good.
This also means we avoid the vast majority of cases where
MediaWiki would busy-loop for upto 10ms in a likely-to-fail
attempt to sync the clock. This means the method runs faster,
which is a nice win, albeit not the main objective.
Bug: T94522
Change-Id: Ia8a847078ec76d633854db6823a20f0961c80f80
Martin Urbanec [Sat, 29 Sep 2018 17:03:12 +0000 (19:03 +0200)]
Add link to protect log to action=info
Bug: T52190
Change-Id: Id983d4585a253ebe34e07f07472548f6d1d20bce
jenkins-bot [Thu, 4 Oct 2018 18:31:32 +0000 (18:31 +0000)]
Merge "Update OOUI to v0.29.1"
jenkins-bot [Thu, 4 Oct 2018 18:11:58 +0000 (18:11 +0000)]
Merge "Avoid fatal when finding no base revision for a null revision."
daniel [Thu, 4 Oct 2018 10:49:50 +0000 (12:49 +0200)]
Avoid fatal when finding no base revision for a null revision.
Bug: T205675
Change-Id: Iae67649a1be9597086033ad34d9d00556ba35730
James D. Forrester [Thu, 4 Oct 2018 17:12:39 +0000 (10:12 -0700)]
Update OOUI to v0.29.1
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.29.1
Local fix to rcfilters for renamed parent method.
Bug: T130434
Bug: T165650
Bug: T183299
Bug: T196756
Bug: T205472
Bug: T205692
Bug: T205979
Bug: T206153
Bug: T206155
Depends-On: Ie847465af6762fd0322a5be4adf601cabda2d458
Change-Id: I704e3197e86d484be3ab91b9282d6ac1b7db2251
jenkins-bot [Thu, 4 Oct 2018 16:58:00 +0000 (16:58 +0000)]
Merge "ParserOutput::getCacheTime should stay the same after the first call."
jenkins-bot [Thu, 4 Oct 2018 16:53:20 +0000 (16:53 +0000)]
Merge "Ensure OutputPageTest works when Translate extension is loaded"
jenkins-bot [Thu, 4 Oct 2018 16:38:46 +0000 (16:38 +0000)]
Merge "Use Remex for TextContentTest subclasses"
jenkins-bot [Thu, 4 Oct 2018 16:20:25 +0000 (16:20 +0000)]
Merge "Disallow overriding services that were set"
jenkins-bot [Thu, 4 Oct 2018 15:54:57 +0000 (15:54 +0000)]
Merge "tests: Allow string to be passed to getTestUser() etc."
jenkins-bot [Thu, 4 Oct 2018 15:50:51 +0000 (15:50 +0000)]
Merge "Minor cleanup in ApiBlockTest"
jenkins-bot [Thu, 4 Oct 2018 15:43:12 +0000 (15:43 +0000)]
Merge "Only use "*Test.php" for actual PHPUnit tests"
jenkins-bot [Thu, 4 Oct 2018 15:40:48 +0000 (15:40 +0000)]
Merge "Re-enable tests from TitlePermissionTest"
jenkins-bot [Thu, 4 Oct 2018 15:38:58 +0000 (15:38 +0000)]
Merge "registration: Let extensions add PHP extension requirements"
Erik Bernhardson [Thu, 4 Oct 2018 14:44:09 +0000 (07:44 -0700)]
search: Fix DYM typos in widget
* DYM link was triggering the 'go' feature due to fulltext misspelled
* all ids are of the form mw-search-*, except one. Make it the same
(WikimediaEvents code was expecting everything to be mw-search-*)
Bug: T206232
Change-Id: Ib91ccf28879b8af2a8c0f2a40b9fe3ec4259a730
Aryeh Gregor [Thu, 4 Oct 2018 12:56:41 +0000 (15:56 +0300)]
tests: Allow string to be passed to getTestUser() etc.
If there's only one group, let's not require the brackets.
Change-Id: Ib46ef1facbbbf2ba01c13b8290ebbe3a8e08cb4f
Aryeh Gregor [Thu, 4 Oct 2018 12:55:55 +0000 (15:55 +0300)]
Minor cleanup in ApiBlockTest
Use tablesUsed instead of cleaning up ourselves.
Change-Id: Ibe470a8f292d65ceeaa098d5c033b8585501a9f3
Translation updater bot [Thu, 4 Oct 2018 12:12:04 +0000 (14:12 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I3a709a2ec2f0e13ca2b8015aa9de36e9e7d4e063
daniel [Thu, 4 Oct 2018 10:32:06 +0000 (12:32 +0200)]
ParserOutput::getCacheTime should stay the same after the first call.
Previously, getCacheTime would default to the current time, potentially
causing the return value to change over subsequent calls. With this change,
the value is determined on the first call, and then remembered for subsequent
calls.
Bug: T205464
Change-Id: If240161c71d523ad5b0d33b9378950e0bebceb6e
Timo Tijhof [Wed, 3 Oct 2018 23:49:53 +0000 (00:49 +0100)]
UIDGenerator: Misc clean up
Various miscellaneous clean ups with no change to any of the
logical code. This to make the next commit have a cleaner diff
for easier review.
* Make internal millitime() non-static.
* Improve documentation and add missing @covers annotations.
* Correct getTimestampedID88() documentation to state that
only two values need to be passed, not three.
This is significant because the Flow extension is actually
using this method in a subclass and passes only two values.
Bug: T94522
Change-Id: I2a0c51bea58df4cc0c253c1c10de3ac383f04c8e
WMDE-Fisch [Mon, 1 Oct 2018 14:29:56 +0000 (16:29 +0200)]
wdio-mediawiki: Add 'fragment' parameter to Page
In some cases it's useful adding a fragment to the url, e.g. when
accessing the beta features preference page. This patch adds support
for that on the Page object.
Change-Id: I4b6aa5e7e89e60f05e217fc557bf6786441855e6
Aaron Schulz [Thu, 4 Oct 2018 08:11:26 +0000 (01:11 -0700)]
Clean up UIDGenerator field comments
Change-Id: I0c6d125ec03a56fe0b3456cff7d498d231315e0d
Fomafix [Thu, 4 Oct 2018 07:06:00 +0000 (09:06 +0200)]
Phabricator: Use Tddddd instead of Bug ddddd in comments
Change-Id: Ic9fe03cab270bd6be738af346164ad5d31a0d780
jenkins-bot [Thu, 4 Oct 2018 02:46:25 +0000 (02:46 +0000)]
Merge "rdbms: clarfiy some comments about commitMasterChanges() methods"
jenkins-bot [Thu, 4 Oct 2018 02:46:19 +0000 (02:46 +0000)]
Merge "rdbms: clarify IDatabase::setTransactionListener() comment"
jenkins-bot [Thu, 4 Oct 2018 02:43:09 +0000 (02:43 +0000)]
Merge "MessageCache: do not store the EXCESSIVE array as it is only needed for HASH"
Aaron Schulz [Wed, 3 Oct 2018 22:39:55 +0000 (15:39 -0700)]
rdbms: clarfiy some comments about commitMasterChanges() methods
Change-Id: I2c9f3cb9b4dcd16f561e55d119849b526e9d402b
Aaron Schulz [Wed, 3 Oct 2018 19:38:46 +0000 (12:38 -0700)]
MessageCache: do not store the EXCESSIVE array as it is only needed for HASH
This saves space as the number of entries becomes larger.
Bug: T193271
Change-Id: I32d7512d7f05ae7c9a69b88cd19df64d7a21b4a1
jenkins-bot [Thu, 4 Oct 2018 01:29:14 +0000 (01:29 +0000)]
Merge "Fix option name in maintenance/importDump.php"
James D. Forrester [Wed, 26 Sep 2018 23:12:23 +0000 (16:12 -0700)]
Special:Preferences: Drop isOouiEnabled() before it gets released
Depends-On: Ic1df4e965df61c2d164b2ffd2fa07ed68b028ddf
Depends-On: If0e83751089d010d026a736040d77b9a0851ef42
Depends-On: Id9c840e979b723806883bb3e63d7f2f691fea629
Depends-On: I9d5dbf449c624233cef2ccf0e3e4200d9eb2b7c3
Change-Id: If2a21a6a40802ab187b30de78fb521f016dd10cd
jenkins-bot [Wed, 3 Oct 2018 23:57:26 +0000 (23:57 +0000)]
Merge "Special:Preferences: Drop non-OOUI legacy form version"
jenkins-bot [Wed, 3 Oct 2018 23:32:36 +0000 (23:32 +0000)]
Merge "Drop 'SpecialRecentChangesQuery' & 'SpecialWatchlistQuery' hooks, deprecated in 1.23"
jenkins-bot [Wed, 3 Oct 2018 23:25:22 +0000 (23:25 +0000)]
Merge "Database: close() should not commit transactions"
Aaron Schulz [Wed, 3 Oct 2018 22:01:29 +0000 (18:01 -0400)]
Make UID clock drift error have more details.
Change-Id: Ic682e48b06161c2a286f5da9016f4831ee72a31e
Kosta Harlan [Wed, 3 Oct 2018 20:42:55 +0000 (16:42 -0400)]
Move test assertion to mirror parameter order
Follow up from I2df0551c5837adc578b27082ab6ba2ac95d937f8
Bug: T206130
Change-Id: Ib669c77fdb709846d0182cb28796cf53914114c4
jenkins-bot [Wed, 3 Oct 2018 19:50:32 +0000 (19:50 +0000)]
Merge "SECURITY: Fix permissions check for patrol action"
Brad Jorsch [Wed, 3 Oct 2018 19:07:24 +0000 (15:07 -0400)]
Enforce no-session constraint in opensearch_desc.php and profileinfo.php
Attempts to use session data via these endpoints will now cause
exceptions to be thrown.
Bug: T127233
Change-Id: I28b080a84e7b928e4336a5a1ec770bb57b05d009
Kosta Harlan [Wed, 3 Oct 2018 16:47:14 +0000 (12:47 -0400)]
SECURITY: Fix permissions check for patrol action
Return existing errors instead of empty array in checkUserConfigPermissions().
Returning an empty array wiped out previously-found errors.
Also add test coverage for patrol action.
Bug: T206130
Change-Id: I2df0551c5837adc578b27082ab6ba2ac95d937f8
Brad Jorsch [Wed, 3 Oct 2018 17:38:19 +0000 (13:38 -0400)]
Database: close() should not commit transactions
Transactional databases normally roll back when a connection is closed
with an open transaction rather than committing them, so MediaWiki
committing them is unexpected.
There are two cases being changed here: automatic transactions without
writes and manual transactions. For the former it shouldn't make a
difference if we commit or roll back since no writes were done anyway.
The latter has logged a message since MW 1.31 (I0992f9a8), and that
warning has not been logged in Wikimedia production in the past 60 days
so we should be ok there too.
Bug: T206147
Change-Id: Ieceef4deb49044db8f0622d38ee76c9d9f39704c
Brad Jorsch [Mon, 23 Jul 2018 16:06:20 +0000 (12:06 -0400)]
Fix option name in maintenance/importDump.php
Bug: T200138
Change-Id: Icc5d9878bc3ebdf03efec9161b220ad0bf55dc9a
jenkins-bot [Wed, 3 Oct 2018 18:04:15 +0000 (18:04 +0000)]
Merge "Show copyright based on $output->hasCopyright()"
jenkins-bot [Wed, 3 Oct 2018 18:01:30 +0000 (18:01 +0000)]
Merge "Remove unused function: isStructuredFilterUiEnabledByDefault"