Gilles Dubuc [Tue, 23 May 2017 08:41:33 +0000 (10:41 +0200)]
Batch/pipeline backend operations in refreshFileHeaders
Bug: T150741
Change-Id: I44efd47e7eb3eba71ae39808ee8e6969e141c5cc
jenkins-bot [Tue, 23 May 2017 07:51:36 +0000 (07:51 +0000)]
Merge "Remove TestingAccessWrapper class (now available via composer)"
jenkins-bot [Tue, 23 May 2017 07:51:32 +0000 (07:51 +0000)]
Merge "Chinese Conversion Table Update 2017-3"
jenkins-bot [Tue, 23 May 2017 05:28:03 +0000 (05:28 +0000)]
Merge "GlobalFunctions: Avoid unnecessary fully-namespaced MediaWikiServices"
jenkins-bot [Tue, 23 May 2017 05:27:26 +0000 (05:27 +0000)]
Merge "Deprecate wfMemcKey() and wfGlobalCacheKey()"
Kunal Mehta [Tue, 23 May 2017 04:37:33 +0000 (21:37 -0700)]
ApiHelp: Avoid deprecated ObjectCache::getMainWANInstance()
And switch wfMemcKey() to $cache->makeKey() while we're at it.
Change-Id: I4e37fbe1ddd49cc7583dd0f2f950eaf21c9ef050
Kunal Mehta [Tue, 23 May 2017 04:32:52 +0000 (21:32 -0700)]
Deprecate wfMemcKey() and wfGlobalCacheKey()
For a while now these functions have called makeKey/makeGlobalKey() on
the default ObjectCache instances, and callers should now use those
functions directly instead.
There are other advantages to doing so, like in cases where the
ObjectCache instance being used has a different makeKey implementation
(e.g. memcache) than the default configured cache.
Change-Id: I9abf6badbf3ba800e591d2503b714433d5faf1e3
Kunal Mehta [Tue, 23 May 2017 04:28:41 +0000 (21:28 -0700)]
GlobalFunctions: Avoid unnecessary fully-namespaced MediaWikiServices
There's already a "use" statement for MediaWikiServices so the full
class name isn't required.
Change-Id: Idabdd406a7c4afa1312fb45dea8499236fe3d6fd
jenkins-bot [Tue, 23 May 2017 01:00:55 +0000 (01:00 +0000)]
Merge "resourceloader: Add tests for OutputPage::buildExemptModules"
Translation updater bot [Mon, 22 May 2017 20:08:39 +0000 (22:08 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I328e1ab3a6c6058838456ba3738537d3f918f86c
jenkins-bot [Mon, 22 May 2017 16:19:46 +0000 (16:19 +0000)]
Merge "Remove $wgExceptionHooks"
jenkins-bot [Mon, 22 May 2017 13:57:44 +0000 (13:57 +0000)]
Merge "Add 'show-multimedia-search-results' to SearchEngine feature data"
Gergő Tisza [Sun, 21 May 2017 08:29:41 +0000 (10:29 +0200)]
Remove $wgExceptionHooks
Skip deprecation period because it is very unlikely that anyone used this:
it does not appear anywhere on gerrit/git, no nontrivial google hits,
the documentation has been flat out wrong for 9 years and no one
noticed it, and the whole feature is fairly useless as you need to declare
it separately for every single exception class you expect.
Change-Id: I85844a238d3135d05eeba10331149624b04bafe2
Translation updater bot [Sun, 21 May 2017 20:08:00 +0000 (22:08 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I2bb6141b1dab503cdde3ea2165166bad2fa91351
jenkins-bot [Sun, 21 May 2017 17:28:31 +0000 (17:28 +0000)]
Merge "resourceloader: Allow modules to be registered via a factory callback"
daniel [Thu, 4 May 2017 16:10:28 +0000 (18:10 +0200)]
resourceloader: Allow modules to be registered via a factory callback
This should work the same way as registering API modules via a factory callback.
Point in case: Ifb8611473a971 could avoid global state using this mechanism.
Change-Id: Ifbf29006141ce2a2dff42efa352f406502a06bc6
jenkins-bot [Sun, 21 May 2017 15:45:41 +0000 (15:45 +0000)]
Merge "Put print click handler on link, not on list item"
jenkins-bot [Sun, 21 May 2017 15:20:55 +0000 (15:20 +0000)]
Merge "In Autopromote skip edit count lookup if requirement is 0 or invalid"
Brion Vibber [Sun, 21 May 2017 15:03:10 +0000 (17:03 +0200)]
Put print click handler on link, not on list item
Was responding to clicks outside the link, which was confusing.
Bug: T24256
Change-Id: I22f7cf20a08bb4204b0442defeb7cfb83899b969
TK-999 [Wed, 15 Feb 2017 10:34:52 +0000 (11:34 +0100)]
In Autopromote skip edit count lookup if requirement is 0 or invalid
Autopromote makes a DB call to fetch user edit count when checking edit count requirements. We can skip this call if requirement is set to 0 or invalid (less than 0).
Bug: T157718
Change-Id: I7bcfa6e7e4991fe7b48bef84ad24621564261abc
Timo Tijhof [Sun, 21 May 2017 14:18:36 +0000 (16:18 +0200)]
Update CREDITS
Also update mailmap to avoid duplicates.
Change-Id: Ic305027c47a96d6d7ea8892823c4ceb687f17e13
jenkins-bot [Sun, 21 May 2017 13:32:20 +0000 (13:32 +0000)]
Merge "Print: prefer JS print over printable version."
Derk-Jan Hartman [Tue, 25 Apr 2017 13:05:42 +0000 (15:05 +0200)]
Print: prefer JS print over printable version.
Bug: T24256
Change-Id: Ic3dc15e578ce4a94959285c9ae579e9088423544
jenkins-bot [Sun, 21 May 2017 12:28:57 +0000 (12:28 +0000)]
Merge "Fix EnhancedChangesList::getDiffHistLinks null exception"
jenkins-bot [Sun, 21 May 2017 11:57:06 +0000 (11:57 +0000)]
Merge "Match Parsoid's attribute sanitization for video elements"
jenkins-bot [Sun, 21 May 2017 10:07:20 +0000 (10:07 +0000)]
Merge "HTMLUsersMultiselectField: Make auto-infusable when used inside a legacy HTMLForm"
Brian Wolff [Fri, 19 May 2017 22:08:14 +0000 (22:08 +0000)]
Fix EnhancedChangesList::getDiffHistLinks null exception
If a page is deleted, rc_cur_id is missing, but it takes
a while before job queue deletes RC entries. If we encounter
something like that, just skip it since its bound for
deletion anyways.
Bug: T164059
Change-Id: I286109a9707e54939c0da31656ef54fd29acf481
jenkins-bot [Sun, 21 May 2017 08:02:22 +0000 (08:02 +0000)]
Merge "Allow namespaces defined in extension.json to be overwritten locally."
Translation updater bot [Sat, 20 May 2017 19:58:31 +0000 (21:58 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Id9a991314902c759c4fac6202896c582e346737c
jenkins-bot [Sat, 20 May 2017 19:35:34 +0000 (19:35 +0000)]
Merge "ApiSandbox: Fix HTTP error handling"
jenkins-bot [Sat, 20 May 2017 19:11:35 +0000 (19:11 +0000)]
Merge "Various test fixes for postgres"
Timo Tijhof [Fri, 12 May 2017 22:20:02 +0000 (23:20 +0100)]
resourceloader: Add tests for OutputPage::buildExemptModules
Bug: T147667
Change-Id: I40245359925ef5dc4e01ada396503a758d6b95fe
jenkins-bot [Sat, 20 May 2017 14:55:34 +0000 (14:55 +0000)]
Merge "Added increase editcount upon page move"
jenkins-bot [Sat, 20 May 2017 14:46:30 +0000 (14:46 +0000)]
Merge "Improve grammar of message on Special:GoToInterwiki"
jenkins-bot [Sat, 20 May 2017 14:40:38 +0000 (14:40 +0000)]
Merge "Remove untranslated "editinguser" message from tyv (tuvinian)"
jenkins-bot [Sat, 20 May 2017 14:37:07 +0000 (14:37 +0000)]
Merge "Typofixes in two apihelp messages for search and templates"
TTO [Sun, 9 Apr 2017 12:30:38 +0000 (12:30 +0000)]
Improve grammar of message on Special:GoToInterwiki
Change-Id: Idd19a8455b82c86cf5a891efb17199fc9f625286
Ad Huikeshoven [Sat, 20 May 2017 13:36:52 +0000 (15:36 +0200)]
Added increase editcount upon page move
Bug: T163966
Change-Id: Ie055f676534e98963c68f8b8185cca65fa8e76b1
Federico Leva [Sat, 20 May 2017 14:18:54 +0000 (16:18 +0200)]
Typofixes in two apihelp messages for search and templates
Spotted by Dgstranz:
* https://translatewiki.net/wiki/Thread:Support/MediaWiki:Apihelp-query%2Bsearch-param-enablerewrites/en
* https://translatewiki.net/wiki/Thread:Support/MediaWiki:Apihelp-query%2Btemplates-param-namespace/en
Change-Id: I5655d95c6cdd74433d358f15873d4a3a30738f50
Bartosz Dziewoński [Sat, 20 May 2017 14:07:35 +0000 (16:07 +0200)]
HTMLUsersMultiselectField: Make auto-infusable when used inside a legacy HTMLForm
Change-Id: I23b3a86f06a10b066e6671e398da37c62e3e61b1
Federico Leva [Sat, 20 May 2017 14:11:30 +0000 (16:11 +0200)]
Remove untranslated "editinguser" message from tyv (tuvinian)
https://translatewiki.net/wiki/Thread:Support/MediaWiki:Editinguser/tyv
Change-Id: I7ac5da1d7bfeca09e88a8f7dc13073eed0195e69
Moritz Oberhauser [Thu, 6 Apr 2017 10:43:18 +0000 (12:43 +0200)]
Allow more customization on the default toggle system
The naming convention remains unchainched. Default toggles are added if no mw-collapsible-toggle child element is present. Premade toggles have already one ore more mw-collapsible-toggle elements defined.
Default and premade toggles (mw-collapsible-toggle) still cannot be mixed/combined with remote toggles (mw-customtoggle).
* The default toggle got less rigid by removing dependency on <a> elements.
* Support for multiple premade toggles was introduced.
* The expand/collapse messages can be used by premade toggles via mw-collapsible-text.
* Removed the linksPassthru option. This step allowed merging premadeToggleHandler into actionHandler.
* The pass through functionality is now applied to all <a> elements since the default toggle does no longer depends on those.
* Removed mw-collapsible-bracket because it was not used and is deprecated by mw-collapsible-text.
* The test suite was adapted to reflect the latest changes.
Change-Id: Ic8627c4c185e8e4175e6fef1c8e1c2190e54edaa
jenkins-bot [Sat, 20 May 2017 12:01:13 +0000 (12:01 +0000)]
Merge "Disable broken TemplateCategoriesTest unit test"
jenkins-bot [Sat, 20 May 2017 11:43:22 +0000 (11:43 +0000)]
Merge "Add HHVM version check"
Timo Tijhof [Sat, 20 May 2017 11:35:43 +0000 (13:35 +0200)]
Disable broken TemplateCategoriesTest unit test
Bug: T165099
Change-Id: I370e48965fdfc948aa02533ebfeb0a540fb53c12
Brad Jorsch [Sat, 20 May 2017 10:09:20 +0000 (12:09 +0200)]
ApiSandbox: Fix HTTP error handling
Since
bf69459, ApiSandbox seems to stall out when an API request
results in an HTTP error (e.g. due to a PHP fatal error). Before that
revision, it displayed the 'apisandbox-results-error' message in this
situation.
Apparently the jQuery 3 changes to Deferred behavior caused it to be
impossible to have a then() filter return `this` (or anything else) in
order to avoid replacing the existing promise that's being resolved or
rejected.
Bug: T165857
Change-Id: I3f646cdfe7fe8987437980790788821f51e728d1
jenkins-bot [Sat, 20 May 2017 10:54:26 +0000 (10:54 +0000)]
Merge "Make sure all functions in Database.php are documented"
jenkins-bot [Sat, 20 May 2017 10:48:43 +0000 (10:48 +0000)]
Merge "Fix Closure detection in MediaWikiTestCase"
jenkins-bot [Sat, 20 May 2017 10:24:55 +0000 (10:24 +0000)]
Merge "Add \b to regexes in BlockLevelPass to avoid confusing tr & track"
jenkins-bot [Sat, 20 May 2017 10:15:01 +0000 (10:15 +0000)]
Merge "More magic word translations for Catalan (ca)"
Sébastien Santoro [Sat, 20 May 2017 09:35:45 +0000 (09:35 +0000)]
Add release notes for T151633
This is a follow-up for
f87b3b68860e.
Thanks to @Sfic to have submitted this solution.
Bug: T151633
Change-Id: Ia87d925f81be68a69b9b5f9893b7fc71afe950db
jenkins-bot [Sat, 20 May 2017 06:22:41 +0000 (06:22 +0000)]
Merge "Use Devanagari digits for list items on ne.wikipedia"
jenkins-bot [Sat, 20 May 2017 02:06:26 +0000 (02:06 +0000)]
Merge "Fix the web updater"
Brion Vibber [Fri, 19 May 2017 22:45:48 +0000 (00:45 +0200)]
Add \b to regexes in BlockLevelPass to avoid confusing tr & track
With TimedMediaHandler in video.js mode, videos can be inline,
without a wrapper div.
Previously, in this mode two paragraphs where one contained a
video would end up merged into one paragraph, due to BlockLevelPass
matching "<track .../>" against "<tr" in its regexes.
Added \b to a couple of the regexes to protect against such errors,
and corrected a parser test case that had bad output listed, where
"<link .../>" matched against "<li".
Bug: T165817
Change-Id: I06e82b881f5ebddae5e7df7fb940adfa54f6b659
Brian Wolff [Fri, 19 May 2017 21:32:00 +0000 (21:32 +0000)]
Hack around icu breakage for fa sorting
Bug: T139110
Change-Id: I35bcdaf309f595258289f01bbe5713ce6d1ffad1
Marius Hoch [Fri, 19 May 2017 21:06:58 +0000 (23:06 +0200)]
Fix Closure detection in MediaWikiTestCase
Sometimes the closure are hidden in arrays, catch this.
The $maxDepth check is just for sanity, I don't think it's
actually needed.
Follows-Up:
c2c7452577e
Bug: T111641
Change-Id: Id5e036ce4949b8106873fd938f54c2774d3d6a4a
Paladox [Fri, 19 May 2017 20:43:26 +0000 (20:43 +0000)]
Fix the web updater
It kept failing with Error: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'ESCAPE '`'' at line 1 (localhost)
Bug: T165805
Change-Id: I2671415fc34b1e6226104c88ca21fafc860bb7fb
Translation updater bot [Fri, 19 May 2017 20:08:33 +0000 (22:08 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Icd2487d8cf826e9736277723e84e2520106b2a5c
jenkins-bot [Fri, 19 May 2017 19:40:45 +0000 (19:40 +0000)]
Merge "Add type hint to ThumbnailRenderJob::hitThumbUrl"
jenkins-bot [Fri, 19 May 2017 19:33:48 +0000 (19:33 +0000)]
Merge "Add workaround for HHVM issue 6206"
jenkins-bot [Fri, 19 May 2017 19:33:36 +0000 (19:33 +0000)]
Merge "Add missing doUpdates() call to refreshLinks.php"
jenkins-bot [Fri, 19 May 2017 19:33:33 +0000 (19:33 +0000)]
Merge "Avoid postgres PrefixSearchTest failures due to collation differences"
Aaron Schulz [Fri, 19 May 2017 19:17:27 +0000 (12:17 -0700)]
Add type hint to ThumbnailRenderJob::hitThumbUrl
Change-Id: Ifab9d74ae9147349b0a3417f35088b96ee47b6fa
Aaron Schulz [Wed, 17 May 2017 18:56:40 +0000 (11:56 -0700)]
Add missing doUpdates() call to refreshLinks.php
Follows-up
b8b01aa589ce which accidentally removed this call.
Bug: T157545
Change-Id: Id4efdccb60e7829269df601b83f64288f6190db4
Marius Hoch [Fri, 19 May 2017 18:50:58 +0000 (20:50 +0200)]
Add workaround for HHVM issue 6206
Just use the actual global on HHVM, like we do on
Zend, but avoid hitting the warning.
This is a workaround for https://github.com/facebook/hhvm/issues/6206
Bug: T111641
Change-Id: I15ef0e90827c94a8b2609484b0dddcb78f04284c
Sébastien Santoro [Fri, 19 May 2017 13:17:20 +0000 (13:17 +0000)]
Use Devanagari digits for list items on ne.wikipedia
Nepalese uses Devanagari, so we wish to use this alphabet for
list items' digits.
Bug: T151633
Change-Id: Id9cb42932fd8b8aa2cfb5418c4a3cd16ec37a60e
jenkins-bot [Fri, 19 May 2017 16:25:39 +0000 (16:25 +0000)]
Merge "MediaSearchWidget: Only resize new results"
Kaldari [Sat, 13 May 2017 01:10:47 +0000 (18:10 -0700)]
Make sure all functions in Database.php are documented
Will add @inheritdoc in a follow-up commit for functions
documented in the parent classes.
Part of 2017 MediaWiki Documentation Day
Change-Id: I002a1f6451940ecbcacea7b3ca2fc6ad0f4eba47
jenkins-bot [Fri, 19 May 2017 15:48:47 +0000 (15:48 +0000)]
Merge "Improve HTTP logging"
Thalia [Wed, 17 May 2017 17:13:17 +0000 (19:13 +0200)]
MediaSearchWidget: Only resize new results
When repositioning images based on the "change" event,
ignore images that have already been assigned to a row.
Bug: T163727
Change-Id: Ida7556d8848f98d97d82aef9caf5c1d43bb47d7b
jenkins-bot [Fri, 19 May 2017 12:47:11 +0000 (12:47 +0000)]
Merge "Tests: correct order of assertEquals arguments"
jenkins-bot [Fri, 19 May 2017 12:14:27 +0000 (12:14 +0000)]
Merge "MimeAnalyzer: Detect magic bytes for mp3"
Derk-Jan Hartman [Fri, 19 May 2017 10:38:36 +0000 (12:38 +0200)]
Tests: correct order of assertEquals arguments
Change-Id: Ib8d1e8aa92172a9abc0495dc0c18ea5df850dd5e
Derk-Jan Hartman [Fri, 19 May 2017 11:33:25 +0000 (13:33 +0200)]
MimeAnalyzer: Detect magic bytes for mp3
Unit tests in follow up patch
Bug: T115170
Change-Id: Ie1a63aa319cebbb2efb3cdc478416f5947078cbe
jenkins-bot [Fri, 19 May 2017 10:08:15 +0000 (10:08 +0000)]
Merge "ContribsPager: Use one TemplateParser instance"
jenkins-bot [Fri, 19 May 2017 10:08:12 +0000 (10:08 +0000)]
Merge "EnhancedChangesList: Use one TemplateParser instance"
Florian Schmidt [Tue, 13 Sep 2016 16:17:11 +0000 (18:17 +0200)]
Add HHVM version check
HHVM brings it's own version number, so relying on the PHP version
string in the PHP_VERSION const on an hhvm server maybe does not
increase in different versions of hhvm. Therefore, this change
implements a hhvm server version check, if MediaWiki runs on an
hhvm server, instead of checking the php version.
Bug: T123436
Change-Id: I91b0a4e1eded61d3ba63ecbd14cdc85c57295892
jenkins-bot [Fri, 19 May 2017 09:14:06 +0000 (09:14 +0000)]
Merge "TemplateParser: Improve cache integrity check failure scenario"
Tim Starling [Fri, 28 Apr 2017 01:32:44 +0000 (11:32 +1000)]
Improve HTTP logging
* Log HTTP debug lines to the "http" channel instead of wfDebug()
* Add the ability to do debug logging to MultiHttpClient
* Add a static method Http::createMultiClient() which provides a
MultiHttpClient configured similarly to the way individual requests
are configured, respecting the wiki's $wgHTTPTimeout and writing debug
logs.
* In EtcdConfig, pass the logger instance through to the MultiHttpClient
backend.
Change-Id: Ic5bdcb0cae95d7b3715ab5261758be082751c3ff
Aaron Schulz [Fri, 19 May 2017 00:40:06 +0000 (17:40 -0700)]
Avoid postgres PrefixSearchTest failures due to collation differences
Bug: T75174
Change-Id: I6b1df27ca6ae5c2da46134be3dbd7aed404d9601
Aaron Schulz [Wed, 17 May 2017 01:36:58 +0000 (18:36 -0700)]
Various test fixes for postgres
* Add another TS_MW timestamp coercion to WatchedItemStore.
* Do not expect timestamp conversion for pager mOffset.
They have been used in Pager URLs for ages.
* Do not assume the user_id for UTSysop is 1; use the row value.
Bug: T75174
Change-Id: I590a4b7363ccff26d9ac9f51b95fc1aa072503b2
Translation updater bot [Thu, 18 May 2017 19:58:13 +0000 (21:58 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I9a4201e523e0e37756d4b70c7b85fc670a6fa1d7
jenkins-bot [Thu, 18 May 2017 18:09:25 +0000 (18:09 +0000)]
Merge "Make sure unique keys carry over to postgres table duplicates"
jenkins-bot [Thu, 18 May 2017 16:01:26 +0000 (16:01 +0000)]
Merge "Introduce wgRelevantPageIsProbablyEditable"
James D. Forrester [Mon, 15 May 2017 10:12:44 +0000 (11:12 +0100)]
Introduce wgRelevantPageIsProbablyEditable
This is equivalent to the existing variable wgIsProbablyEditable and in
keeping with wgRelevantPageName/wgRelevantArticleId; this is done as an
alternative to making a breaking change to the semantics of the former,
as that might cause issues for users who expect wgIsProbablyEditable to
return true on [[Foo]], but false on [[Special:Move/Foo]] and similar.
Change-Id: I6c6ca1cfd93e7be917952980f1e1d57aec3a1292
Željko Filipin [Tue, 21 Mar 2017 11:10:46 +0000 (12:10 +0100)]
Remove Selenium tests written in Ruby
New Selenium tests in Node.js are in tests/selenium.
Bug: T164004
Change-Id: I3ddeecb4f012ba4a614b3ada81c5926da28556f4
Depends-On: I062d68458d8f472d636f1ae15f4fc37110460854
Translation updater bot [Wed, 17 May 2017 20:37:00 +0000 (22:37 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ie2f793b769f66378edf72e616dfdd2a344e95987
jenkins-bot [Wed, 17 May 2017 19:34:42 +0000 (19:34 +0000)]
Merge "Apply EXIF rotation to X-Content-Dimensions"
jenkins-bot [Wed, 17 May 2017 18:00:53 +0000 (18:00 +0000)]
Merge "ApiLogin: i18n for 'Aborted' reasons"
Fomafix [Wed, 17 May 2017 16:20:20 +0000 (18:20 +0200)]
Resources.php: Add missing dependencies to module 'mediawiki.user'
Change-Id: Ie68418a47d4b4b98fac2b275def392294bd01909
jenkins-bot [Wed, 17 May 2017 09:40:09 +0000 (09:40 +0000)]
Merge "RCFilters UI: Actually backwards-compat instead of overriding false"
Aaron Schulz [Wed, 17 May 2017 02:20:42 +0000 (19:20 -0700)]
Make sure unique keys carry over to postgres table duplicates
This fixes BotPasswordTest failures.
Change-Id: I81003187af0c57020f9fc4cbcd2606e71907a903
Moriel Schottlender [Wed, 17 May 2017 00:35:43 +0000 (17:35 -0700)]
RCFilters UI: Actually backwards-compat instead of overriding false
Another typo in the code made highlight feature always load as false
when you loaded a saved filter.
Bug: T165437
Change-Id: I0e0efa3576659e4145b20013e4af7a06e4e7c0ff
Kunal Mehta [Tue, 16 May 2017 22:49:03 +0000 (15:49 -0700)]
ContribsPager: Use one TemplateParser instance
TemplateParser has an instance cache to avoid reading from APC
repeatedly for the same template, but that only works if the code uses
the same TemplateParser object.
Change-Id: I59e37306c5a3216cf8ed3bfef9c80d50934a9146
Kunal Mehta [Tue, 16 May 2017 22:43:35 +0000 (15:43 -0700)]
EnhancedChangesList: Use one TemplateParser instance
TemplateParser has an instance cache to avoid reading from APC
repeatedly for the same template, but that only works if the code uses
the same TemplateParser object.
Noticed while investigating T163154.
Change-Id: I645895a0965f7150e9a5aebc5a7788f27aa5a26d
Kunal Mehta [Tue, 16 May 2017 22:40:08 +0000 (15:40 -0700)]
TemplateParser: Improve cache integrity check failure scenario
Previously, if the cache integrity check failed then it would emit a
warning but then continue to use the code. The integrity check could
genuinely fail if the secret key was changed, if the cache was
truncated, or other edge case scenarios.
Now TemplateParser will recompile if the cache fails the integrity
check, and then update the cache with the newly compiled version.
Bug: T163154
Change-Id: I9a6c8d528f84cfbabf402cfaf6468c162fab1f15
James D. Forrester [Tue, 16 May 2017 22:34:01 +0000 (23:34 +0100)]
Update OOjs UI to v0.21.4
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.21.4
Depends-On: I676c9aadbf4739437b94ec729cc4fe47ed19c886
Change-Id: Ie9f8e42c46948688495cbd80e778b484c7b03982
jenkins-bot [Tue, 16 May 2017 19:47:22 +0000 (19:47 +0000)]
Merge "Sync up with Parsoid parserTests.txt"
C. Scott Ananian [Tue, 16 May 2017 19:12:22 +0000 (15:12 -0400)]
Sync up with Parsoid parserTests.txt
This now aligns with Parsoid commit
d163deefa3aaeb0926af09a91075d6a611b36363
Change-Id: I9e543f0803247ffc264e634bf66b6bd0e143f187
jenkins-bot [Tue, 16 May 2017 19:12:02 +0000 (19:12 +0000)]
Merge "Improve output of refreshImageMetadata and refreshFileHeaders"