From cbc4fd7a5b81f7fec171d78670af453e2882e891 Mon Sep 17 00:00:00 2001 From: umherirrender Date: Thu, 9 May 2013 20:06:03 +0200 Subject: [PATCH] print is not a function Removed parenthesis after print Change-Id: I1343872de7aa7c64952a3d86a63aaa091e46bda3 --- includes/Import.php | 4 ++-- includes/OutputPage.php | 2 +- includes/db/DatabaseMssql.php | 6 +++--- maintenance/Maintenance.php | 2 +- maintenance/language/checkDupeMessages.php | 14 +++++++------- .../api/query/ApiQueryContinueTestBase.php | 4 ++-- .../includes/api/query/ApiQueryTestBase.php | 6 +++--- 7 files changed, 19 insertions(+), 19 deletions(-) diff --git a/includes/Import.php b/includes/Import.php index 7b078dbf10..8b7af02a0f 100644 --- a/includes/Import.php +++ b/includes/Import.php @@ -428,11 +428,11 @@ class WikiImporter { } } - print( var_dump( + print var_dump( $lookup[$this->reader->nodeType], $this->reader->name, $this->reader->value - ) . "\n\n" ); + ) . "\n\n"; } /** diff --git a/includes/OutputPage.php b/includes/OutputPage.php index 4a2b17a380..746cd0e709 100644 --- a/includes/OutputPage.php +++ b/includes/OutputPage.php @@ -2076,7 +2076,7 @@ class OutputPage extends ContextSource { } /** - * Actually output something with print(). + * Actually output something with print. * * @param string $ins the string to output */ diff --git a/includes/db/DatabaseMssql.php b/includes/db/DatabaseMssql.php index 293557fa0d..130ac70537 100644 --- a/includes/db/DatabaseMssql.php +++ b/includes/db/DatabaseMssql.php @@ -674,7 +674,7 @@ class DatabaseMssql extends DatabaseBase { $res = sqlsrv_query( $this->mConn, "SELECT * FROM information_schema.tables WHERE table_type='BASE TABLE' AND table_name = '$table'" ); if ( $res === false ) { - print( "Error in tableExists query: " . $this->getErrors() ); + print "Error in tableExists query: " . $this->getErrors(); return false; } if ( sqlsrv_fetch( $res ) ) { @@ -693,7 +693,7 @@ class DatabaseMssql extends DatabaseBase { $res = sqlsrv_query( $this->mConn, "SELECT DATA_TYPE FROM INFORMATION_SCHEMA.Columns WHERE TABLE_NAME = '$table' AND COLUMN_NAME = '$field'" ); if ( $res === false ) { - print( "Error in fieldExists query: " . $this->getErrors() ); + print "Error in fieldExists query: " . $this->getErrors(); return false; } if ( sqlsrv_fetch( $res ) ) { @@ -708,7 +708,7 @@ class DatabaseMssql extends DatabaseBase { $res = sqlsrv_query( $this->mConn, "SELECT * FROM INFORMATION_SCHEMA.Columns WHERE TABLE_NAME = '$table' AND COLUMN_NAME = '$field'" ); if ( $res === false ) { - print( "Error in fieldInfo query: " . $this->getErrors() ); + print "Error in fieldInfo query: " . $this->getErrors(); return false; } $meta = $this->fetchRow( $res ); diff --git a/maintenance/Maintenance.php b/maintenance/Maintenance.php index 2162869062..94f94022db 100644 --- a/maintenance/Maintenance.php +++ b/maintenance/Maintenance.php @@ -327,7 +327,7 @@ abstract class Maintenance { } if ( $channel === null ) { $this->cleanupChanneled(); - print( $out ); + print $out; } else { $out = preg_replace( '/\n\z/', '', $out ); $this->outputChanneled( $out, $channel ); diff --git a/maintenance/language/checkDupeMessages.php b/maintenance/language/checkDupeMessages.php index 55e34be50d..190b2371b1 100644 --- a/maintenance/language/checkDupeMessages.php +++ b/maintenance/language/checkDupeMessages.php @@ -95,22 +95,22 @@ if ( $run ) { if ( ( $messageExist ) && ( $messageCExist ) ) { if ( !strcmp( $runMode, 'php' ) ) { - print( " $value ) { foreach ( $wgMessages[$langCode] as $ckey => $cvalue ) { if ( !strcmp( $key, $ckey ) ) { if ( ( !strcmp( $key, $ckey ) ) && ( !strcmp( $value, $cvalue ) ) ) { if ( !strcmp( $runMode, 'raw' ) ) { - print( "$key\n" ); + print "$key\n"; } elseif ( !strcmp( $runMode, 'php' ) ) { - print( "'$key' => '',\n" ); + print "'$key' => '',\n"; } elseif ( !strcmp( $runMode, 'wiki' ) ) { $uKey = ucfirst( $key ); - print( "* MediaWiki:$uKey/$langCode\n" ); + print "* MediaWiki:$uKey/$langCode\n"; } else { - print( "* $key\n" ); + print "* $key\n"; } $count++; } @@ -118,7 +118,7 @@ if ( $run ) { } } if ( !strcmp( $runMode, 'php' ) ) { - print( ");\n" ); + print ");\n"; } if ( !strcmp( $runMode, 'text' ) ) { if ( $count == 1 ) { diff --git a/tests/phpunit/includes/api/query/ApiQueryContinueTestBase.php b/tests/phpunit/includes/api/query/ApiQueryContinueTestBase.php index 0acbe9f2a0..fbb1e640da 100644 --- a/tests/phpunit/includes/api/query/ApiQueryContinueTestBase.php +++ b/tests/phpunit/includes/api/query/ApiQueryContinueTestBase.php @@ -75,7 +75,7 @@ abstract class ApiQueryContinueTestBase extends ApiQueryTestBase { //$reqStr = str_replace( '&', ' & ', $reqStr ); $this->assertLessThan( $expectedCount, $count, "$id more data: $reqStr" ); if ( $this->mVerbose ) { - print ( "$id (#$count): $reqStr\n" ); + print "$id (#$count): $reqStr\n"; } try { $data = $this->doApiRequest( $request ); @@ -145,7 +145,7 @@ abstract class ApiQueryContinueTestBase extends ApiQueryTestBase { self::GetItems( $q, 'allpages', 'Pages', $print ); self::GetItems( $q, 'alllinks', 'Links', $print ); self::GetItems( $q, 'alltransclusions', 'Trnscl', $print ); - print( ' ' . implode( ' ', $print ) . "\n" ); + print ' ' . implode( ' ', $print ) . "\n"; } private static function GetItems( $q, $moduleName, $name, &$print ) { diff --git a/tests/phpunit/includes/api/query/ApiQueryTestBase.php b/tests/phpunit/includes/api/query/ApiQueryTestBase.php index d712bc08e1..8ee8ea9628 100644 --- a/tests/phpunit/includes/api/query/ApiQueryTestBase.php +++ b/tests/phpunit/includes/api/query/ApiQueryTestBase.php @@ -109,10 +109,10 @@ STR; if ( is_array( $message ) ) { $message = http_build_query( $message ); } - print( "\nRequest: $message\n" ); - print( "\nExpected:\n" ); + print "\nRequest: $message\n"; + print "\nExpected:\n"; print_r( $exp ); - print( "\nResult:\n" ); + print "\nResult:\n"; print_r( $result ); throw $e; // rethrow it } -- 2.20.1