From c6a135cf0c936c41bc40e40b8304e354c9c6e06d Mon Sep 17 00:00:00 2001 From: Nikerabbit Date: Sun, 27 Jul 2014 12:23:18 +0000 Subject: [PATCH] Revert "Make a hidden form field to keep the language code" This reverts commit f3d9e7137ed19dbe1944567909e1f117eba0fade. Breaks the core functionality of the special page. Change-Id: I4a4b01e16763a7b418ff137112d2db2d42293ed1 --- includes/specials/SpecialPageLanguage.php | 8 +------- .../mediawiki.special/mediawiki.special.pageLanguage.js | 8 +------- 2 files changed, 2 insertions(+), 14 deletions(-) diff --git a/includes/specials/SpecialPageLanguage.php b/includes/specials/SpecialPageLanguage.php index 3fe66b5452..a432f104db 100644 --- a/includes/specials/SpecialPageLanguage.php +++ b/includes/specials/SpecialPageLanguage.php @@ -75,7 +75,7 @@ class SpecialPageLanguage extends FormSpecialPage { $options["$code - $name"] = $code; } - $page['languageSelector'] = array( + $page['language'] = array( 'id' => 'mw-pl-languageselector', 'type' => 'select', 'options' => $options, @@ -83,12 +83,6 @@ class SpecialPageLanguage extends FormSpecialPage { 'default' => $wgLanguageCode ); - $page['language'] = array( - 'id' => 'mw-pl-languagevalue', - 'type' => 'hidden', - 'default' => $wgLanguageCode - ); - return $page; } diff --git a/resources/src/mediawiki.special/mediawiki.special.pageLanguage.js b/resources/src/mediawiki.special/mediawiki.special.pageLanguage.js index f27518a88a..ba7f7342c4 100644 --- a/resources/src/mediawiki.special/mediawiki.special.pageLanguage.js +++ b/resources/src/mediawiki.special/mediawiki.special.pageLanguage.js @@ -1,15 +1,9 @@ ( function ( $ ) { $( document ).ready( function () { + // Select the 'Language select' option if user is trying to select language $( '#mw-pl-languageselector' ).on( 'click', function () { - var langCode; - - // Select the 'Language select' option if user is trying to select language $( '#mw-pl-options-2' ).prop( 'checked', true ); - - // Get the language code in the hidden form field - langCode = $( '#mw-pl-languageselector' ).val(); - $( '#mw-pl-languagevalue' ).val( langCode ); } ); } ); } ( jQuery ) ); -- 2.20.1