From ae2f5d62328f20ac24ba956f0753e6800eb906f7 Mon Sep 17 00:00:00 2001 From: Umherirrender Date: Wed, 27 Jun 2018 20:49:23 +0200 Subject: [PATCH] Add missing use statements Swap some ResultWrapper/Database to interface IResultWrapper/IDatabase Change-Id: I312cb3cca5742f72efdb0965ba35362f2eb1129d --- includes/GlobalFunctions.php | 1 + includes/OutputPage.php | 3 ++- includes/search/SearchMssql.php | 6 ++++-- includes/session/SessionProviderInterface.php | 1 + includes/specials/pagers/DeletedContribsPager.php | 1 + maintenance/storage/recompressTracked.php | 3 ++- 6 files changed, 11 insertions(+), 4 deletions(-) diff --git a/includes/GlobalFunctions.php b/includes/GlobalFunctions.php index d9996f426f..d87fd28a39 100644 --- a/includes/GlobalFunctions.php +++ b/includes/GlobalFunctions.php @@ -31,6 +31,7 @@ use MediaWiki\MediaWikiServices; use MediaWiki\Shell\Shell; use Wikimedia\ScopedCallback; use Wikimedia\Rdbms\DBReplicationWaitError; +use Wikimedia\WrappedString; /** * Load an extension diff --git a/includes/OutputPage.php b/includes/OutputPage.php index 0b2ba407eb..4ce49fd9eb 100644 --- a/includes/OutputPage.php +++ b/includes/OutputPage.php @@ -24,6 +24,7 @@ use MediaWiki\Linker\LinkTarget; use MediaWiki\Logger\LoggerFactory; use MediaWiki\MediaWikiServices; use MediaWiki\Session\SessionManager; +use Wikimedia\Rdbms\IResultWrapper; use Wikimedia\RelPath; use Wikimedia\WrappedString; use Wikimedia\WrappedStringList; @@ -1337,7 +1338,7 @@ class OutputPage extends ContextSource { /** * @param array $categories - * @return bool|ResultWrapper + * @return bool|IResultWrapper */ protected function addCategoryLinksToLBAndGetResult( array $categories ) { # Add the links to a LinkBatch diff --git a/includes/search/SearchMssql.php b/includes/search/SearchMssql.php index 43bd3bed27..30ac92da09 100644 --- a/includes/search/SearchMssql.php +++ b/includes/search/SearchMssql.php @@ -21,6 +21,8 @@ * @ingroup Search */ +use Wikimedia\Rdbms\IResultWrapper; + /** * Search engine hook base class for Mssql (ConText). * @ingroup Search @@ -168,7 +170,7 @@ class SearchMssql extends SearchDatabase { * @param int $id * @param string $title * @param string $text - * @return bool|ResultWrapper + * @return bool|IResultWrapper */ function update( $id, $title, $text ) { // We store the column data as UTF-8 byte order marked binary stream @@ -191,7 +193,7 @@ class SearchMssql extends SearchDatabase { * * @param int $id * @param string $title - * @return bool|ResultWrapper + * @return bool|IResultWrapper */ function updateTitle( $id, $title ) { $table = $this->db->tableName( 'searchindex' ); diff --git a/includes/session/SessionProviderInterface.php b/includes/session/SessionProviderInterface.php index 02ae23d551..896e62fb1b 100644 --- a/includes/session/SessionProviderInterface.php +++ b/includes/session/SessionProviderInterface.php @@ -24,6 +24,7 @@ namespace MediaWiki\Session; use Language; +use Message; /** * This exists to make IDEs happy, so they don't see the diff --git a/includes/specials/pagers/DeletedContribsPager.php b/includes/specials/pagers/DeletedContribsPager.php index b5ced1348e..f261b72d8d 100644 --- a/includes/specials/pagers/DeletedContribsPager.php +++ b/includes/specials/pagers/DeletedContribsPager.php @@ -23,6 +23,7 @@ * @ingroup Pager */ use MediaWiki\MediaWikiServices; +use Wikimedia\Rdbms\IDatabase; use Wikimedia\Rdbms\IResultWrapper; use Wikimedia\Rdbms\FakeResultWrapper; diff --git a/maintenance/storage/recompressTracked.php b/maintenance/storage/recompressTracked.php index 271cbf3dd6..7f3644288b 100644 --- a/maintenance/storage/recompressTracked.php +++ b/maintenance/storage/recompressTracked.php @@ -24,6 +24,7 @@ use MediaWiki\Logger\LegacyLogger; use MediaWiki\MediaWikiServices; +use Wikimedia\Rdbms\IDatabase; $optionsWithArgs = RecompressTracked::getOptionsWithArgs(); require __DIR__ . '/../commandLine.inc'; @@ -640,7 +641,7 @@ class RecompressTracked { /** * Gets a DB master connection for the given external cluster name * @param string $cluster - * @return Database + * @return IDatabase */ function getExtDB( $cluster ) { $lbFactory = MediaWikiServices::getInstance()->getDBLoadBalancerFactory(); -- 2.20.1