From 9a16d3a37e0a00951139bc5e8b62bfa16306a6e4 Mon Sep 17 00:00:00 2001
From: Hashar <hashar@free.fr>
Date: Wed, 11 Feb 2015 15:03:02 +0000
Subject: [PATCH] Revert "Add AvailableRightsTest for User::getAllRights
 completeness"

This change has not been advertised and cause random extensions
to start failing giving little clue to users.

Please have this change discussed on wikitech-l and announced
ahead of time to minimize disruptions. It brokes MathSearch at least:

https://gerrit.wikimedia.org/r/#/c/189442/

This reverts commit d333cd8f7be190d7e296721caa79478ab7ef1b20.

Change-Id: If9a28b1386fca946d8ba351c16134cdf7da8a148
---
 includes/User.php                             |  2 +-
 .../phpunit/structure/AvailableRightsTest.php | 45 -------------------
 2 files changed, 1 insertion(+), 46 deletions(-)
 delete mode 100644 tests/phpunit/structure/AvailableRightsTest.php

diff --git a/includes/User.php b/includes/User.php
index 961c510b19..c2db67a2a7 100644
--- a/includes/User.php
+++ b/includes/User.php
@@ -4399,7 +4399,7 @@ class User implements IDBAccessObject {
 
 	/**
 	 * Get a list of all available permissions.
-	 * @return string[] Array of permission names
+	 * @return array Array of permission names
 	 */
 	public static function getAllRights() {
 		if ( self::$mAllRights === false ) {
diff --git a/tests/phpunit/structure/AvailableRightsTest.php b/tests/phpunit/structure/AvailableRightsTest.php
deleted file mode 100644
index 9737e82848..0000000000
--- a/tests/phpunit/structure/AvailableRightsTest.php
+++ /dev/null
@@ -1,45 +0,0 @@
-<?php
-
-/**
- * Try to make sure that extensions register all rights in $wgAvailableRights
- * or via the 'UserGetAllRights' hook.
- *
- * @author Marius Hoch < hoo@online.de >
- */
-class AvailableRightsTest extends PHPUnit_Framework_TestCase {
-
-	/**
-	 * Returns all rights that should be in $wgAvailableRights + all rights
-	 * registered via the 'UserGetAllRights' hook + all "core" rights.
-	 *
-	 * @return string[]
-	 */
-	private function getAllVisibleRights() {
-		global $wgGroupPermissions, $wgRevokePermissions;
-
-		$rights = User::getAllRights();
-
-		foreach( $wgGroupPermissions as $permissions ) {
-			$rights = array_merge( $rights, array_keys( $permissions ) );
-		}
-
-		foreach( $wgRevokePermissions as $permissions ) {
-			$rights = array_merge( $rights, array_keys( $permissions ) );
-		}
-
-		$rights = array_unique( $rights );
-		sort( $rights );
-
-		return $rights;
-	}
-
-	public function testAvailableRights() {
-		$missingRights = array_diff( $this->getAllVisibleRights(), User::getAllRights() );
-
-		$this->assertEquals(
-			array(),
-			array_values( $missingRights ), // Re-Index to produce nicer output, keys are meaningless
-			'Additional user rights need to be added to $wgAvailableRights or via the "UserGetAllRights" hook'
-		);
-	}
-}
-- 
2.20.1