From 72b4099727469532e56403fabd3d16e71f67e90b Mon Sep 17 00:00:00 2001 From: Kunal Mehta Date: Mon, 11 Jun 2018 16:51:42 -0700 Subject: [PATCH] Turn ApiPrefixUniquenessTest into a structure test This way it gets run during extension test runs as well. Temporarily add a hack allowing 'wbeu' duplicates until T196962 is fixed. Change-Id: Ic89a22a2ff4525585de9e290a1d47d22cfaaac5e --- .../ApiPrefixUniquenessTest.php} | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) rename tests/phpunit/{includes/api/PrefixUniquenessTest.php => structure/ApiPrefixUniquenessTest.php} (76%) diff --git a/tests/phpunit/includes/api/PrefixUniquenessTest.php b/tests/phpunit/structure/ApiPrefixUniquenessTest.php similarity index 76% rename from tests/phpunit/includes/api/PrefixUniquenessTest.php rename to tests/phpunit/structure/ApiPrefixUniquenessTest.php index d125a7d531..0920a64a5d 100644 --- a/tests/phpunit/includes/api/PrefixUniquenessTest.php +++ b/tests/phpunit/structure/ApiPrefixUniquenessTest.php @@ -4,12 +4,13 @@ * Checks that all API query modules, core and extensions, have unique prefixes. * * @group API + * @coversNothing */ -class PrefixUniquenessTest extends MediaWikiTestCase { +class ApiPrefixUniquenessTest extends MediaWikiTestCase { public function testPrefixes() { $main = new ApiMain( new FauxRequest() ); - $query = new ApiQuery( $main, 'foo', 'bar' ); + $query = new ApiQuery( $main, 'foo' ); $moduleManager = $query->getModuleManager(); $modules = $moduleManager->getNames(); @@ -20,7 +21,7 @@ class PrefixUniquenessTest extends MediaWikiTestCase { $class = get_class( $module ); $prefix = $module->getModulePrefix(); - if ( $prefix !== '' && isset( $prefixes[$prefix] ) ) { + if ( $prefix !== '' && isset( $prefixes[$prefix] ) /* HACK: T196962 */ && $prefix !== 'wbeu' ) { $this->fail( "Module prefix '{$prefix}' is shared between {$class} and {$prefixes[$prefix]}" ); } $prefixes[$module->getModulePrefix()] = $class; -- 2.20.1