From 588880c5f0567fca144a37066e87db3712ef32ac Mon Sep 17 00:00:00 2001 From: "This, that and the other" Date: Mon, 21 Jul 2014 17:38:39 +1000 Subject: [PATCH] Preferences: Turn stubthreshold back into a combo box Currently it's an insanely tall list box. All the other settings on this page use combo boxes, so we should be consistent. After it was changed from 'selectorother' to 'select' in I88212703 and support for 'size' in HTMLSelectField was enabled in I7ac345e1, the size defines the height of the select box instead of the width of the text input field. Bug: 68313 Change-Id: Id42a62e78fc2fee741bb02b88dc14cbb1b63635a --- includes/Preferences.php | 1 - 1 file changed, 1 deletion(-) diff --git a/includes/Preferences.php b/includes/Preferences.php index 482c24b64b..b4bb6de638 100644 --- a/includes/Preferences.php +++ b/includes/Preferences.php @@ -750,7 +750,6 @@ class Preferences { 'type' => 'select', 'section' => 'rendering/advancedrendering', 'options' => $stubThresholdOptions, - 'size' => 20, 'label-raw' => $context->msg( 'stub-threshold' )->text(), // Raw HTML message. Yay? ); -- 2.20.1