From 371a23a35f686a0ff9140821401ac99408ffe31d Mon Sep 17 00:00:00 2001
From: Aaron Schulz <aaron@users.mediawiki.org>
Date: Sun, 16 Nov 2008 23:18:43 +0000
Subject: [PATCH] Refactor getCharacterDifference()

---
 includes/ChangesList.php  | 24 ++++++++++++++++++++++++
 includes/RecentChange.php | 24 +-----------------------
 2 files changed, 25 insertions(+), 23 deletions(-)

diff --git a/includes/ChangesList.php b/includes/ChangesList.php
index 469b067428..7cdd2d0cee 100644
--- a/includes/ChangesList.php
+++ b/includes/ChangesList.php
@@ -99,6 +99,30 @@ class ChangesList {
 		$this->rclistOpen = false;
 		return '';
 	}
+	
+	/**
+	 * Show formatted char difference
+	 * @param int $old bytes
+	 * @param int $new bytes
+	 * @returns string
+	 */
+	public static function showCharacterDifference( $old, $new ) {
+		global $wgRCChangedSizeThreshold, $wgLang;
+		$szdiff = $new - $old;
+		$formatedSize = wfMsgExt( 'rc-change-size', array( 'parsemag', 'escape'), $wgLang->formatNum($szdiff) );
+		if( abs( $szdiff ) > abs( $wgRCChangedSizeThreshold ) ) {
+			$tag = 'strong';
+		} else {
+		    $tag = 'span';
+		}
+		if( $szdiff === 0 ) {
+			return "<$tag class='mw-plusminus-null'>($formatedSize)</$tag>";
+		} elseif( $szdiff > 0 ) {
+			return "<$tag class='mw-plusminus-pos'>(+$formatedSize)</$tag>";
+	    } else {
+			return "<$tag class='mw-plusminus-neg'>($formatedSize)</$tag>";
+		}
+	}
 
 	/**
  	 * Returns text for the end of RC
diff --git a/includes/RecentChange.php b/includes/RecentChange.php
index d0714668da..f628fdc95d 100644
--- a/includes/RecentChange.php
+++ b/includes/RecentChange.php
@@ -668,37 +668,15 @@ class RecentChange
 	 * The lengths can be given optionally.
 	 */
 	public function getCharacterDifference( $old = 0, $new = 0 ) {
-		global $wgRCChangedSizeThreshold, $wgLang;
-
 		if( $old === 0 ) {
 			$old = $this->mAttribs['rc_old_len'];
 		}
 		if( $new === 0 ) {
 			$new = $this->mAttribs['rc_new_len'];
 		}
-
 		if( $old === NULL || $new === NULL ) {
 			return '';
 		}
-
-		$szdiff = $new - $old;
-		$formatedSize = wfMsgExt( 'rc-change-size', array( 'parsemag', 'escape'),
-			$wgLang->formatNum($szdiff) );
-
-		
-		if( abs( $szdiff ) > abs( $wgRCChangedSizeThreshold ) ) {
-			$tag = 'strong';
-		} 
-		else{
-		    $tag = 'span';
-		}
-
-		if( $szdiff === 0 ) {
-			return "<$tag class='mw-plusminus-null'>($formatedSize)</$tag>";
-		} elseif( $szdiff > 0 ) {
-			return "<$tag class='mw-plusminus-pos'>(+$formatedSize)</$tag>";
-	    } else {
-			return "<$tag class='mw-plusminus-neg'>($formatedSize)</$tag>";
-		}
+		return ChangesList::showCharacterDifference( $old, $new );
 	}
 }
-- 
2.20.1