From 159dbdc06f214f3fed3f86808312012cf2099e4f Mon Sep 17 00:00:00 2001 From: Kunal Mehta Date: Sun, 10 Jan 2016 22:47:16 -0800 Subject: [PATCH] Remove IE8 support from mediawiki.js Change-Id: Ifec1e04baa59564632881c594f8a57d8be2c8250 --- resources/src/mediawiki/mediawiki.js | 36 ++++++++++++---------------- 1 file changed, 15 insertions(+), 21 deletions(-) diff --git a/resources/src/mediawiki/mediawiki.js b/resources/src/mediawiki/mediawiki.js index 82b45881fe..b04e01c2a2 100644 --- a/resources/src/mediawiki/mediawiki.js +++ b/resources/src/mediawiki/mediawiki.js @@ -632,27 +632,21 @@ obj[ key ] = val; } : function ( obj, key, val, msg ) { msg = 'Use of "' + key + '" is deprecated.' + ( msg ? ( ' ' + msg ) : '' ); - // Support: IE8 - // Can throw on Object.defineProperty. - try { - Object.defineProperty( obj, key, { - configurable: true, - enumerable: true, - get: function () { - mw.track( 'mw.deprecate', key ); - mw.log.warn( msg ); - return val; - }, - set: function ( newVal ) { - mw.track( 'mw.deprecate', key ); - mw.log.warn( msg ); - val = newVal; - } - } ); - } catch ( err ) { - // Fallback to creating a copy of the value to the object. - obj[ key ] = val; - } + Object.defineProperty( obj, key, { + configurable: true, + enumerable: true, + get: function () { + mw.track( 'mw.deprecate', key ); + mw.log.warn( msg ); + return val; + }, + set: function ( newVal ) { + mw.track( 'mw.deprecate', key ); + mw.log.warn( msg ); + val = newVal; + } + } ); + }; return log; -- 2.20.1