From 0269ae0fe57f5192743e99ccd67970db989b542d Mon Sep 17 00:00:00 2001 From: =?utf8?q?Bartosz=20Dziewo=C5=84ski?= Date: Mon, 19 Jun 2017 21:50:59 +0200 Subject: [PATCH] mw.action.edit: Restore modifier keys for accesskey in tooltip for summary field .updateTooltipAccessKeys() is called automatically after the page loads (from mediawiki.page.ready), but infusing the field blows away these changes. This is a poor workaround, the same issue will appear if e.g. the buttons are infused. The functionality provided by jquery.accessKeyLabel should be an OOjs UI feature, or we should somehow call it automatically after infusing widgets. Bug: T168042 Change-Id: I2b166be34b8394c296fbc7326570cd732284888f --- resources/Resources.php | 1 + resources/src/mediawiki.action/mediawiki.action.edit.js | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/resources/Resources.php b/resources/Resources.php index f4149ea679..864f93eabe 100644 --- a/resources/Resources.php +++ b/resources/Resources.php @@ -1415,6 +1415,7 @@ return [ 'styles' => 'resources/src/mediawiki.action/mediawiki.action.edit.css', 'dependencies' => [ 'mediawiki.action.edit.styles', + 'jquery.accessKeyLabel', 'jquery.textSelection', 'jquery.byteLimit', 'mediawiki.api', diff --git a/resources/src/mediawiki.action/mediawiki.action.edit.js b/resources/src/mediawiki.action/mediawiki.action.edit.js index 49e64b5254..8cde703e74 100644 --- a/resources/src/mediawiki.action/mediawiki.action.edit.js +++ b/resources/src/mediawiki.action/mediawiki.action.edit.js @@ -23,6 +23,10 @@ mw.loader.using( 'oojs-ui-core' ).then( function () { var wpSummary = OO.ui.infuse( $( '#wpSummaryWidget' ) ); + // Restore appropriate modifier keys for the accesskey in the 'title' attribute + // TODO: This should be an OOjs UI feature, or somehow happen automatically after infusing. + wpSummary.$input.updateTooltipAccessKeys(); + // Make sure edit summary does not exceed byte limit wpSummary.$input.byteLimit( 255 ); -- 2.20.1