From: Catrope <roan@wikimedia.org>
Date: Mon, 20 Mar 2017 21:43:32 +0000 (+0000)
Subject: Revert "RCFilters: Change reset button title when it changes state"
X-Git-Tag: 1.31.0-rc.0~3746^2
X-Git-Url: http://git.cyclocoop.org/%22%2C%20generer_url_ecrire%28?a=commitdiff_plain;h=ef41ed0e80474ca9ac84e7bc73a5096520689b28;p=lhc%2Fweb%2Fwiklou.git

Revert "RCFilters: Change reset button title when it changes state"

It makes no sense to add a tooltip to a button that already
has text, especially if the tooltip text is (almost)
the same as the button text.

This reverts commit 31047fb1bf03944158fe4f7da99686e7955a3b5c.

Change-Id: I2f9c819a85fc05f37c7c0c5acf2d72319bdb0d76
---

diff --git a/languages/i18n/en.json b/languages/i18n/en.json
index ea60fc82be..ccfa91b096 100644
--- a/languages/i18n/en.json
+++ b/languages/i18n/en.json
@@ -1366,7 +1366,6 @@
 	"rcfilters-activefilters": "Active filters",
 	"rcfilters-restore-default-filters": "Restore default filters",
 	"rcfilters-clear-all-filters": "Clear all filters",
-	"rcfilters-clear-filters-to-defaults": "Set filters to defaults",
 	"rcfilters-search-placeholder": "Filter recent changes (browse or start typing)",
 	"rcfilters-invalid-filter": "Invalid filter",
 	"rcfilters-empty-filter": "No active filters. All contributions are shown.",
diff --git a/languages/i18n/qqq.json b/languages/i18n/qqq.json
index 3116163234..f123189c2e 100644
--- a/languages/i18n/qqq.json
+++ b/languages/i18n/qqq.json
@@ -1553,7 +1553,6 @@
 	"rcfilters-activefilters": "Title for the filters selection showing the active filters.",
 	"rcfilters-restore-default-filters": "Label for the button that resets filters to defaults",
 	"rcfilters-clear-all-filters": "Title for the button that clears all filters",
-	"rcfilters-clear-filters-to-defaults": "Title for the button that sets filters to default",
 	"rcfilters-search-placeholder": "Placeholder for the filter search input.",
 	"rcfilters-invalid-filter": "A label for an invalid filter.",
 	"rcfilters-empty-filter": "Placeholder for the filter list when no filters were chosen.",
diff --git a/resources/Resources.php b/resources/Resources.php
index f57f8c826c..392cdb3ff8 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -1795,7 +1795,6 @@ return [
 			'rcfilters-activefilters',
 			'rcfilters-restore-default-filters',
 			'rcfilters-clear-all-filters',
-			'rcfilters-clear-filters-to-defaults',
 			'rcfilters-search-placeholder',
 			'rcfilters-invalid-filter',
 			'rcfilters-empty-filter',
diff --git a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterCapsuleMultiselectWidget.js b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterCapsuleMultiselectWidget.js
index 3f461c76f0..944ebaa120 100644
--- a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterCapsuleMultiselectWidget.js
+++ b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterCapsuleMultiselectWidget.js
@@ -183,11 +183,6 @@
 		this.resetButton.setLabel(
 			currFiltersAreEmpty ? mw.msg( 'rcfilters-restore-default-filters' ) : ''
 		);
-		this.resetButton.setTitle(
-			currFiltersAreEmpty ?
-				mw.msg( 'rcfilters-clear-filters-to-defaults' ) :
-				mw.msg( 'rcfilters-clear-all-filters' )
-		);
 
 		this.resetButton.toggle( !hideResetButton );
 		this.emptyFilterMessage.toggle( currFiltersAreEmpty );