From: Aaron Schulz <aschulz@wikimedia.org>
Date: Thu, 26 Apr 2018 21:18:43 +0000 (+0100)
Subject: resourceloader: Use plain arrays instead of $.Callbacks() in addEmbeddedCSS
X-Git-Tag: 1.34.0-rc.0~5580^2
X-Git-Url: http://git.cyclocoop.org/%22%2C%20generer_url_ecrire%28?a=commitdiff_plain;h=79af472b2b41fc845a3e8e42219c46a270e37f44;p=lhc%2Fweb%2Fwiklou.git

resourceloader: Use plain arrays instead of $.Callbacks() in addEmbeddedCSS

Bug: T192623
Change-Id: I00c9571d353980d853cc8e92b2b508ad7271ab87
---

diff --git a/resources/src/mediawiki/mediawiki.js b/resources/src/mediawiki/mediawiki.js
index 3fe276bbef..7e02f241ae 100644
--- a/resources/src/mediawiki/mediawiki.js
+++ b/resources/src/mediawiki/mediawiki.js
@@ -871,7 +871,7 @@
 				// For addEmbeddedCSS()
 				cssBuffer = '',
 				cssBufferTimer = null,
-				cssCallbacks = $.Callbacks(),
+				cssCallbacks = [],
 				rAF = window.requestAnimationFrame || setTimeout;
 
 			function getMarker() {
@@ -923,15 +923,18 @@
 			 */
 			function addEmbeddedCSS( cssText, callback ) {
 				function fireCallbacks() {
-					var oldCallbacks = cssCallbacks;
+					var i,
+						oldCallbacks = cssCallbacks;
 					// Reset cssCallbacks variable so it's not polluted by any calls to
 					// addEmbeddedCSS() from one of the callbacks (T105973)
-					cssCallbacks = $.Callbacks();
-					oldCallbacks.fire().empty();
+					cssCallbacks = [];
+					for ( i = 0; i < oldCallbacks.length; i++ ) {
+						oldCallbacks[ i ]();
+					}
 				}
 
 				if ( callback ) {
-					cssCallbacks.add( callback );
+					cssCallbacks.push( callback );
 				}
 
 				// Yield once before creating the <style> tag. This lets multiple stylesheets