From: Brad Jorsch <bjorsch@wikimedia.org>
Date: Wed, 9 Mar 2016 21:12:15 +0000 (-0500)
Subject: ApiSandbox: Specify a $overlay for menu-using widgets
X-Git-Tag: 1.31.0-rc.0~3355^2
X-Git-Url: http://git.cyclocoop.org/%22%2C%20generer_url_ecrire%28?a=commitdiff_plain;h=4a44ba6eca79adb2cc574964902d45096f3d2bd0;p=lhc%2Fweb%2Fwiklou.git

ApiSandbox: Specify a $overlay for menu-using widgets

This makes the menu work more sensibly when the widget is inside a
scrolling box of some sort.

Bug: T129308
Change-Id: Ic3b26883984030bb0ab37fcca8acd8b8c4535c2d
---

diff --git a/resources/src/mediawiki.special/mediawiki.special.apisandbox.js b/resources/src/mediawiki.special/mediawiki.special.apisandbox.js
index 7cb67b0084..d228149a1b 100644
--- a/resources/src/mediawiki.special/mediawiki.special.apisandbox.js
+++ b/resources/src/mediawiki.special/mediawiki.special.apisandbox.js
@@ -337,7 +337,8 @@
 					} else if ( Util.apiBool( pi.multi ) ) {
 						widget = new OO.ui.CapsuleMultiselectWidget( {
 							allowArbitrary: true,
-							allowDuplicates: Util.apiBool( pi.allowsduplicates )
+							allowDuplicates: Util.apiBool( pi.allowsduplicates ),
+							$overlay: $( '#mw-apisandbox-ui' )
 						} );
 						widget.paramInfo = pi;
 						$.extend( widget, WidgetMethods.capsuleWidget );
@@ -459,13 +460,15 @@
 						}
 
 						widget = new OO.ui.CapsuleMultiselectWidget( {
-							menu: { items: items }
+							menu: { items: items },
+							$overlay: $( '#mw-apisandbox-ui' )
 						} );
 						widget.paramInfo = pi;
 						$.extend( widget, WidgetMethods.capsuleWidget );
 					} else {
 						widget = new OO.ui.DropdownWidget( {
-							menu: { items: items }
+							menu: { items: items },
+							$overlay: $( '#mw-apisandbox-ui' )
 						} );
 						widget.paramInfo = pi;
 						$.extend( widget, WidgetMethods.dropdownWidget );
@@ -489,7 +492,8 @@
 						}
 
 						widget = new OO.ui.CapsuleMultiselectWidget( {
-							menu: { items: items }
+							menu: { items: items },
+							$overlay: $( '#mw-apisandbox-ui' )
 						} );
 						widget.paramInfo = pi;
 						$.extend( widget, WidgetMethods.capsuleWidget );
@@ -499,7 +503,8 @@
 						}
 					} else {
 						widget = new OO.ui.DropdownWidget( {
-							menu: { items: items }
+							menu: { items: items },
+							$overlay: $( '#mw-apisandbox-ui' )
 						} );
 						widget.paramInfo = pi;
 						$.extend( widget, WidgetMethods.dropdownWidget );
@@ -535,6 +540,7 @@
 				widget = new OO.ui.CapsuleMultiselectWidget( {
 					allowArbitrary: true,
 					allowDuplicates: Util.apiBool( pi.allowsduplicates ),
+					$overlay: $( '#mw-apisandbox-ui' ),
 					popup: {
 						classes: [ 'mw-apisandbox-popup' ],
 						$content: $content
@@ -1031,7 +1037,8 @@
 
 				if ( !formatDropdown ) {
 					formatDropdown = new OO.ui.DropdownWidget( {
-						menu: { items: [] }
+						menu: { items: [] },
+						$overlay: $( '#mw-apisandbox-ui' )
 					} );
 					formatDropdown.getMenu().on( 'choose', Util.onFormatDropdownChange );
 				}