From: Tobias Gritschacher <tobias.gritschacher@wikimedia.de>
Date: Mon, 4 Sep 2017 11:58:49 +0000 (+0200)
Subject: Check for Wikidiff2 version 0.3 NOT for 0.3.0
X-Git-Tag: 1.31.0-rc.0~2217^2
X-Git-Url: http://git.cyclocoop.org/%22%2C%20generer_url_ecrire%28?a=commitdiff_plain;h=286245181ddbf5f4b80e3da11dfa170354316573;p=lhc%2Fweb%2Fwiklou.git

Check for Wikidiff2 version 0.3 NOT for 0.3.0

version_compare( '0.3', '0.3.0', '>=' ) gives false, so we need to check
for 0.3 since the Wikidiff2 version is defined as 0.3 in
https://gerrit.wikimedia.org/r/#/c/319866/60/Wikidiff2.h

Bug: T166571
Change-Id: Id6e9f402af2fab784a3db2444f201022e2d0de3e
---

diff --git a/includes/diff/DifferenceEngine.php b/includes/diff/DifferenceEngine.php
index 7f9af604fd..34f285235a 100644
--- a/includes/diff/DifferenceEngine.php
+++ b/includes/diff/DifferenceEngine.php
@@ -918,7 +918,7 @@ class DifferenceEngine extends ContextSource {
 			$wikidiff2Version = phpversion( 'wikidiff2' );
 			if (
 				$wikidiff2Version !== false &&
-				version_compare( $wikidiff2Version, '0.3.0', '>=' )
+				version_compare( $wikidiff2Version, '0.3', '>=' )
 			) {
 				$text = wikidiff2_do_diff(
 					$otext,