Merge "resourceloader: Add test for getVersionHash parent-definition requirement"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Wed, 27 Jun 2018 07:25:45 +0000 (07:25 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Wed, 27 Jun 2018 07:25:45 +0000 (07:25 +0000)
tests/phpunit/includes/resourceloader/ResourceLoaderModuleTest.php

index 0ea4e2b..c925339 100644 (file)
@@ -64,6 +64,19 @@ class ResourceLoaderModuleTest extends ResourceLoaderTestCase {
                );
        }
 
+       /**
+        * @covers ResourceLoaderModule::getVersionHash
+        */
+       public function testGetVersionHash_parentDefinition() {
+               $context = $this->getResourceLoaderContext();
+               $module = $this->getMockBuilder( ResourceLoaderModule::class )
+                       ->setMethods( [ 'getDefinitionSummary' ] )->getMock();
+               $module->method( 'getDefinitionSummary' )->willReturn( [ 'a' => 'summary' ] );
+
+               $this->setExpectedException( LogicException::class, 'must call parent' );
+               $module->getVersionHash( $context );
+       }
+
        /**
         * @covers ResourceLoaderModule::validateScriptFile
         */