Actually set the $res field via doQuery() in setVisibility

* Otherwise, it is thrown away and redone on a slave

Change-Id: I1252fa5bc98d908cf289f4d93cbdd8d6d33828ea

diff --git a/includes/revisiondelete/RevDelList.php b/includes/revisiondelete/RevDelList.php
index 7a3ddfe..1ce9691 100644 (file)
--- a/includes/revisiondelete/RevDelList.php
+++ b/includes/revisiondelete/RevDelList.php
@@ -89,9 +89,10 @@ abstract class RevDelList extends RevisionListBase {
                $comment = $params['comment'];
                $perItemStatus = isset( $params['perItemStatus'] ) ? $params['perItemStatus'] : false;
 
-               $this->res = false;
+               // CAS-style checks are done on the _deleted fields so the select
+               // does not need to use FOR UPDATE nor be in the atomic section
                $dbw = wfGetDB( DB_MASTER );
-               $this->doQuery( $dbw );
+               $this->res = $this->doQuery( $dbw );
 
                $dbw->startAtomic( __METHOD__ );