From: Amir E. Aharoni Date: Thu, 21 May 2015 22:21:09 +0000 (+0300) Subject: Cleanup the code of Language::hebrewNumeral() X-Git-Tag: 1.31.0-rc.0~11217 X-Git-Url: http://git.cyclocoop.org/%22%24script/%7B%7B%20url_for%28?a=commitdiff_plain;h=f21537f8f2c23cd432313b847b39f86592896422;p=lhc%2Fweb%2Fwiklou.git Cleanup the code of Language::hebrewNumeral() Change == to === and add empty lines for readability. Change-Id: Ifeabbf0d6adca25d8a797bd423f1bbdc0f8223ee --- diff --git a/languages/Language.php b/languages/Language.php index 18f4594173..ce779f7a05 100644 --- a/languages/Language.php +++ b/languages/Language.php @@ -2046,26 +2046,30 @@ class Language { $s = ''; for ( $pow10 = 1000, $i = 3; $i >= 0; $pow10 /= 10, $i-- ) { if ( $num >= $pow10 ) { - if ( $num == 15 || $num == 16 ) { + if ( $num === 15 || $num === 16 ) { $s .= $table[0][9] . $table[0][$num - 9]; $num = 0; } else { $s .= $table[$i][intval( ( $num / $pow10 ) )]; - if ( $pow10 == 1000 ) { + if ( $pow10 === 1000 ) { $s .= "'"; } } } + $num = $num % $pow10; } - if ( strlen( $s ) == 2 ) { + + if ( strlen( $s ) === 2 ) { $str = $s . "'"; } else { $str = substr( $s, 0, strlen( $s ) - 2 ) . '"'; $str .= substr( $s, strlen( $s ) - 2, 2 ); } + $start = substr( $str, 0, strlen( $str ) - 2 ); $end = substr( $str, strlen( $str ) - 2 ); + switch ( $end ) { case 'כ': $str = $start . 'ך'; @@ -2083,6 +2087,7 @@ class Language { $str = $start . 'ץ'; break; } + return $str; }