From: Max Semenik <maxsem.wiki@gmail.com>
Date: Sat, 24 Feb 2018 01:41:20 +0000 (-0800)
Subject: Don't suggest using extract()
X-Git-Tag: 1.31.0-rc.0~512
X-Git-Url: http://git.cyclocoop.org/%22%24script/%7B%7B%20url_for%28?a=commitdiff_plain;h=29c6ce7a9e3e78c9a93312a6284993c0d5916b40;p=lhc%2Fweb%2Fwiklou.git

Don't suggest using extract()

Especially for things as trivial as this.

Bug: T28496
Change-Id: Id4bc7f0e6411e943dff45e45964c08d44e6ccb96
---

diff --git a/includes/libs/rdbms/database/IMaintainableDatabase.php b/includes/libs/rdbms/database/IMaintainableDatabase.php
index 66012dae43..d0c398e3e8 100644
--- a/includes/libs/rdbms/database/IMaintainableDatabase.php
+++ b/includes/libs/rdbms/database/IMaintainableDatabase.php
@@ -62,8 +62,8 @@ interface IMaintainableDatabase extends IDatabase {
 	 * This is handy when you need to construct SQL for joins
 	 *
 	 * Example:
-	 * extract( $dbr->tableNames( 'user', 'watchlist' ) );
-	 * $sql = "SELECT wl_namespace,wl_title FROM $watchlist,$user
+	 * list( $user, $watchlist ) = $dbr->tableNames( 'user', 'watchlist' ) );
+	 * $sql = "SELECT wl_namespace, wl_title FROM $watchlist, $user
 	 *         WHERE wl_user=user_id AND wl_user=$nameWithQuotes";
 	 *
 	 * @return array