From 4e4e4ec14392715f81a03429080e2b57348604ea Mon Sep 17 00:00:00 2001 From: Trevor Parscal Date: Tue, 21 Feb 2012 22:08:23 +0000 Subject: [PATCH] Adds a supportsURLLoading method which returns false to user tokens and user options modules. This prevents them from being linked to direction which fixes an issue where in debug mode logged in users were being served anon tokens and options. This should resolve bug #34469. --- .../resourceloader/ResourceLoaderUserOptionsModule.php | 7 +++++++ includes/resourceloader/ResourceLoaderUserTokensModule.php | 7 +++++++ 2 files changed, 14 insertions(+) diff --git a/includes/resourceloader/ResourceLoaderUserOptionsModule.php b/includes/resourceloader/ResourceLoaderUserOptionsModule.php index 84932adddf..96b791e2bf 100644 --- a/includes/resourceloader/ResourceLoaderUserOptionsModule.php +++ b/includes/resourceloader/ResourceLoaderUserOptionsModule.php @@ -79,6 +79,13 @@ class ResourceLoaderUserOptionsModule extends ResourceLoaderModule { array( $this->contextUserOptions( $context ) ) ); } + /** + * @return bool + */ + public function supportsURLLoading() { + return false; + } + /** * @return string */ diff --git a/includes/resourceloader/ResourceLoaderUserTokensModule.php b/includes/resourceloader/ResourceLoaderUserTokensModule.php index e1a52388ba..852cc2c1d7 100644 --- a/includes/resourceloader/ResourceLoaderUserTokensModule.php +++ b/includes/resourceloader/ResourceLoaderUserTokensModule.php @@ -54,6 +54,13 @@ class ResourceLoaderUserTokensModule extends ResourceLoaderModule { array( $this->contextUserTokens( $context ) ) ); } + /** + * @return bool + */ + public function supportsURLLoading() { + return false; + } + /** * @return string */ -- 2.20.1