Merge "jquery.tablesorter: Remove dead node check in getElementSortKey()"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Fri, 8 Mar 2019 20:52:52 +0000 (20:52 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Fri, 8 Mar 2019 20:52:52 +0000 (20:52 +0000)
resources/src/jquery.tablesorter/jquery.tablesorter.js

index 6107af1..a5a1783 100644 (file)
                return false;
        }
 
+       /**
+        * @param {HTMLElement} node
+        * @return {string}
+        */
        function getElementSortKey( node ) {
                var $node = $( node ),
                        // Use data-sort-value attribute.
@@ -71,9 +75,6 @@
                        // like charAt, toLowerCase and split are expected.
                        return String( data );
                }
-               if ( !node ) {
-                       return $node.text();
-               }
                if ( node.tagName.toLowerCase() === 'img' ) {
                        return $node.attr( 'alt' ) || ''; // handle undefined alt
                }