Avoid master queries in Title::getLinksFrom()

All callers only hit this case by accident (e.g. limit/offset)

Bug: T92357
Change-Id: I4b5d1b62b2e564b40c65c82cfd4788093d61fc98

diff --git a/includes/Title.php b/includes/Title.php
index 55c7179..a962ea6 100644 (file)
--- a/includes/Title.php
+++ b/includes/Title.php
@@ -3427,7 +3427,7 @@ class Title implements LinkTarget {
         * WARNING: do not use this function on arbitrary user-supplied titles!
         * On heavily-used templates it will max out the memory.
         *
-        * @param array $options May be FOR UPDATE
+        * @param array $options Query option to Database::select()
         * @return Title[] Array of Title the Title objects linking here
         */
        public function getTemplateLinksTo( $options = array() ) {
@@ -3441,7 +3441,7 @@ class Title implements LinkTarget {
         * WARNING: do not use this function on arbitrary user-supplied titles!
         * On heavily-used templates it will max out the memory.
         *
-        * @param array $options May be FOR UPDATE
+        * @param array $options Query option to Database::select()
         * @param string $table Table name
         * @param string $prefix Fields prefix
         * @return array Array of Title objects linking here
@@ -3454,11 +3454,7 @@ class Title implements LinkTarget {
                        return array();
                }
 
-               if ( count( $options ) > 0 ) {
-                       $db = wfGetDB( DB_MASTER );
-               } else {
-                       $db = wfGetDB( DB_SLAVE );
-               }
+               $db = wfGetDB( DB_SLAVE );
 
                $blNamespace = "{$prefix}_namespace";
                $blTitle = "{$prefix}_title";