From c10b4698f0ce79d57620d628f74d8fca7b60ab2b Mon Sep 17 00:00:00 2001
From: =?utf8?q?Thiemo=20M=C3=A4ttig?= <thiemo.maettig@wikimedia.de>
Date: Sat, 24 May 2014 22:06:01 +0200
Subject: [PATCH] Fix broken @return documentation

I found one of these in Wikibase and run a global search.

Change-Id: I76c1519a47d7222f136272c59ea454b650808a86
---
 includes/EditPage.php                 | 2 +-
 includes/WebRequest.php               | 2 +-
 includes/api/ApiMain.php              | 2 +-
 includes/utils/ZipDirectoryReader.php | 3 +++
 4 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/includes/EditPage.php b/includes/EditPage.php
index 7be6274d9d..e6186c613f 100644
--- a/includes/EditPage.php
+++ b/includes/EditPage.php
@@ -1254,7 +1254,7 @@ class EditPage {
 	 * @param array|bool $resultDetails
 	 *
 	 * @throws ErrorPageError
-	 * return bool false, if output is done, true if rest of the form should be displayed
+	 * @return bool false, if output is done, true if rest of the form should be displayed
 	 */
 	private function handleStatus( Status $status, $resultDetails ) {
 		global $wgUser, $wgOut;
diff --git a/includes/WebRequest.php b/includes/WebRequest.php
index 391b49ed44..ecc2372c2f 100644
--- a/includes/WebRequest.php
+++ b/includes/WebRequest.php
@@ -489,7 +489,7 @@ class WebRequest {
 	 * @param float $default
 	 * @return float
 	 */
-	public function getFloat( $name, $default = 0 ) {
+	public function getFloat( $name, $default = 0.0 ) {
 		return floatval( $this->getVal( $name, $default ) );
 	}
 
diff --git a/includes/api/ApiMain.php b/includes/api/ApiMain.php
index ccf91dd348..df56735439 100644
--- a/includes/api/ApiMain.php
+++ b/includes/api/ApiMain.php
@@ -957,7 +957,7 @@ class ApiMain extends ApiBase {
 	/**
 	 * Encode a value in a format suitable for a space-separated log line.
 	 * @param string $s
-	 * return string
+	 * @return string
 	 */
 	protected function encodeRequestLogValue( $s ) {
 		static $table;
diff --git a/includes/utils/ZipDirectoryReader.php b/includes/utils/ZipDirectoryReader.php
index 1419bbb332..6be186fc21 100644
--- a/includes/utils/ZipDirectoryReader.php
+++ b/includes/utils/ZipDirectoryReader.php
@@ -546,6 +546,9 @@ class ZipDirectoryReader {
 	 * If there are not enough bytes in the file to satisfy the request, the
 	 * return value will be truncated. If a request is made for a segment beyond
 	 * the end of the file, an empty string will be returned.
+	 *
+	 * @param int $segIndex
+	 *
 	 * @return string
 	 */
 	function getSegment( $segIndex ) {
-- 
2.20.1