From a2ecfbc9452987c020c3c72c902f273954685cfd Mon Sep 17 00:00:00 2001 From: Roan Kattouw Date: Sat, 23 Jul 2011 03:48:35 +0000 Subject: [PATCH] Change != {} to !$.isEmptyObject(): the former always returned true because objects are compared by reference. This didn't cause any realistic problems, though: the worst that could happen is that if you have a module name longer than the query string request limit (which is extremely unusual), mediawiki.js would probably go into an infinite loop. --- resources/mediawiki/mediawiki.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/mediawiki/mediawiki.js b/resources/mediawiki/mediawiki.js index 28a57a285f..1644f1c2e8 100644 --- a/resources/mediawiki/mediawiki.js +++ b/resources/mediawiki/mediawiki.js @@ -788,7 +788,7 @@ window.mediaWiki = new ( function( $ ) { // If the request would become too long, create a new one, // but don't create empty requests - if ( limit > 0 && reqs[r] != {} && l + bytesAdded > limit ) { + if ( limit > 0 && !$.isEmptyObject( reqs[r] ) && l + bytesAdded > limit ) { // This request would become too long, create a new one r++; reqs[r] = {}; -- 2.20.1