From 34e890772afcfd4a1f1257fe3d8a0abfdfb22118 Mon Sep 17 00:00:00 2001 From: Brion Vibber Date: Mon, 12 Dec 2005 00:25:44 +0000 Subject: [PATCH] * (bug 4001) Use local variables properly in wikibits.js akeytt() --- RELEASE-NOTES | 1 + skins/common/wikibits.js | 8 +++++--- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/RELEASE-NOTES b/RELEASE-NOTES index baf14d0f02..94c6f95ca3 100644 --- a/RELEASE-NOTES +++ b/RELEASE-NOTES @@ -310,6 +310,7 @@ fully support the editing toolbar, but was found to be too confusing. * (bug 4233) Update LanguageJa.php * Fix regression: old version missing from edit links in Nostalgia skin * (bug 1600) Trigger edit conflict on duplicate section=new submissions +* (bug 4001) Use local variables properly in wikibits.js akeytt() === Caveats === diff --git a/skins/common/wikibits.js b/skins/common/wikibits.js index bdbea3848d..46bc4dbbf0 100644 --- a/skins/common/wikibits.js +++ b/skins/common/wikibits.js @@ -413,16 +413,18 @@ function insertTags(tagOpen, tagClose, sampleText) { function akeytt() { if (typeof ta == "undefined" || !ta) return; - pref = 'alt-'; + var pref = 'alt-'; if (is_safari || navigator.userAgent.toLowerCase().indexOf('mac') + 1 || navigator.userAgent.toLowerCase().indexOf('konqueror') + 1 ) pref = 'control-'; if (is_opera) pref = 'shift-esc-'; - for (id in ta) { - n = document.getElementById(id); + for (var id in ta) { + var n = document.getElementById(id); if (n) { + var a = null; + var ak = ''; // Are we putting accesskey in it if (ta[id][0].length > 0) { // Is this object a object? If not assume it's the next child. -- 2.20.1