From 3364af388703e94e482611a5b033dfdc0d1e265d Mon Sep 17 00:00:00 2001 From: "Mark A. Hershberger" Date: Thu, 20 Oct 2011 14:46:29 +0000 Subject: [PATCH] Revert r79363, r79364, and r79369 to disable datalists support entirely based on Bug 31602, Bug 31697, Bug 31654, Bug 31658, and even Aryeh Gregor's comments in http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2010-December/029593.html --- RELEASE-NOTES-1.18 | 2 -- resources/Resources.php | 2 +- skins/common/mwsuggest.js | 19 ++++++++----------- 3 files changed, 9 insertions(+), 14 deletions(-) diff --git a/RELEASE-NOTES-1.18 b/RELEASE-NOTES-1.18 index f70935c5b7..46c1fefe7c 100644 --- a/RELEASE-NOTES-1.18 +++ b/RELEASE-NOTES-1.18 @@ -95,8 +95,6 @@ Now the "This is a minor edit" checkbox is not available when you create a page or new section. * (bug 8130) Query pages should limit to content namespaces, not just main namespace. -* Search suggestions (other than in the Vector skin) will now use the HTML5 - datalist feature where supported, currently only Firefox 4. * Special:Contribs now redirects to Special:Contributions. * (bug 6672) Images are now autorotated according to their EXIF orientation. This only affects thumbnails; the source remains unrotated. diff --git a/resources/Resources.php b/resources/Resources.php index 7b948360d8..d0be64f307 100644 --- a/resources/Resources.php +++ b/resources/Resources.php @@ -719,7 +719,7 @@ return array( 'scripts' => 'common/mwsuggest.js', 'remoteBasePath' => $GLOBALS['wgStylePath'], 'localBasePath' => $GLOBALS['wgStyleDirectory'], - 'dependencies' => array( 'mediawiki.legacy.wikibits', 'jquery.client' ), + 'dependencies' => 'mediawiki.legacy.wikibits', 'messages' => array( 'search-mwsuggest-enabled', 'search-mwsuggest-disabled' ), ), 'mediawiki.legacy.preview' => array( diff --git a/skins/common/mwsuggest.js b/skins/common/mwsuggest.js index 6971d30df1..6dbce050cb 100644 --- a/skins/common/mwsuggest.js +++ b/skins/common/mwsuggest.js @@ -50,18 +50,15 @@ window.os_animation_timer = null; window.os_enabled = true; /** - * is a new HTML5 element that allows you to manually supply - * suggestion lists and have them rendered according to the right platform - * conventions. Opera as of version 11 has a fatal problem: the suggestion - * lags behind what the user types by one keypress. (Reported as DSK-276870 to - * Opera's secret bug tracker.) However, Firefox 4 supports it without - * problems, so Opera is just blacklisted here. Ideally we wouldn't blacklist - * future versions, in case they fix it, but the fallback isn't bad at all and - * the failure if they don't fix it is very annoying, so in this case we'll - * blacklist future versions too. + * is a new HTML5 element that allows you to manually + * supply suggestion lists and have them rendered according to the + * right platform conventions. Opera as of version 11 has a fatal + * problem: the suggestion lags behind what the user types by one + * keypress. (Reported as DSK-276870 to Opera's secret bug tracker.) + * There are also problems with other browsers, including Firefox and + * Safari: See bug 31602 for details. */ -window.os_use_datalist = 'list' in document.createElement( 'input' ) - && $.client.profile().name != 'opera'; +window.os_use_datalist = false; /** Timeout timer class that will fetch the results */ window.os_Timer = function( id, r, query ) { -- 2.20.1