jenkins-bot [Sat, 17 Sep 2016 15:05:11 +0000 (15:05 +0000)]
Merge "mw.widgets.CategorySelector: Add client-side caching"
Amir Sarabadani [Sat, 27 Aug 2016 17:26:40 +0000 (21:56 +0430)]
Rework UserContribs options section
It will make it more mobile friendly and fixes several issues.
Bug: T143518
Bug: T50544
Change-Id: Ie353af860aaec7d6921ae83fa59980ab0a5c8d9b
Aaron Schulz [Fri, 16 Sep 2016 03:33:25 +0000 (20:33 -0700)]
Cleanups to DatabaseMysqlBase
* Avoid global methods
* Inject global variables
* Remove $wgAllDBsAreLocalhost hack
Change-Id: I54b23654def1f83518764ad697434aebfc6cef73
jenkins-bot [Sat, 17 Sep 2016 05:48:25 +0000 (05:48 +0000)]
Merge "Move all of the reasonable DatabaseBase methods to Database class"
jenkins-bot [Sat, 17 Sep 2016 04:13:13 +0000 (04:13 +0000)]
Merge "PrefixSearch: Implement searching in multiple namespaces"
Aaron Schulz [Fri, 16 Sep 2016 03:14:58 +0000 (20:14 -0700)]
Move all of the reasonable DatabaseBase methods to Database class
The Database class was previously just a short-hand for "Database::",
and such calls should still work. The class now resides in /libs/rdbms.
The subclasses now extend DatabaseBase to avoid breaking type hints
that use that (hints use either IDatabase or DatabaseBase).
Also, use CASCADE with DROP TABLE for MySQL as with other DBs.
Keep SQLite excempt due to lack of support.
Added getDomainID() methods to avoid mentioning the word "wiki".
Change-Id: Ibd05d786cb26c21dcc9cb9601f6b2b52056af9ae
jenkins-bot [Sat, 17 Sep 2016 02:41:14 +0000 (02:41 +0000)]
Merge "Fix type doc in StatusValue"
Aaron Schulz [Fri, 16 Sep 2016 18:32:23 +0000 (11:32 -0700)]
Make LoadBalancer domain handling more robust
* Cleanup setDomainPrefix() methods to handle existing LBs/DBs.
* This also makes it set just the prefix as the prefix rather
than as the whole domain.
* Fix regression from
789a54a5f1 where "read" mode of
tablePrefix()/dbSchema() still set the field.
* Make getConnectionRef() always have the domain set.
* Add a check in openConnection() for explicit local
connections, treating $domain as false and avoiding
openForeignConnection().
Bug: T145840
Change-Id: Idf392bd9992a215c4fa3bddf275562f3916596aa
Aaron Schulz [Fri, 16 Sep 2016 18:22:10 +0000 (11:22 -0700)]
Rename domain => localDomain in LBFactory for consistency
Change-Id: I2fb66f98dddb4acc38958a7b8beec002970d43f7
Aaron Schulz [Sat, 17 Sep 2016 00:38:10 +0000 (17:38 -0700)]
Fix type doc in StatusValue
Change-Id: Ib0a3282083b2fd08ea76022b74b21b55da9b8a46
Translation updater bot [Fri, 16 Sep 2016 21:21:44 +0000 (23:21 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ic5673e78a0257e8c8c1cd93d8450f6f7293e0b5d
jenkins-bot [Fri, 16 Sep 2016 20:03:59 +0000 (20:03 +0000)]
Merge "resourceloader: Move 'site' and 'user' logic to makeModuleResponse"
jenkins-bot [Fri, 16 Sep 2016 19:20:57 +0000 (19:20 +0000)]
Merge "Avoid triggering SiteConfiguration lookup in JobQueueGroup::push()"
Aaron Schulz [Fri, 16 Sep 2016 18:16:19 +0000 (11:16 -0700)]
Avoid triggering SiteConfiguration lookup in JobQueueGroup::push()
Just use $wgJobTypesExcludedFromDefaultQueue directly
Bug: T145819
Change-Id: I0d978cdbef40ced98880c1a7d7524fd2b7438bfc
Fomafix [Mon, 9 Nov 2015 05:43:11 +0000 (05:43 +0000)]
Apply wfBCP47() to HTTP response header Content-Language
See https://tools.ietf.org/html/rfc7231#section-3.1.3 for Content-Language.
This references https://tools.ietf.org/html/rfc5646 aka BCP 47.
Example:
curl -I https://crh.wikipedia.org/wiki/Ba%C5%9F_Saife | grep -i '^content-language:'
should contain
Content-language: crh-Latn
instead of
Content-language: crh-latn
Change-Id: Ice4f40911c3761c2542430935bc1898bc4e7a4d4
jenkins-bot [Fri, 16 Sep 2016 13:40:20 +0000 (13:40 +0000)]
Merge "Add SearchEngineFactory::getSearchEngineClass() instead of using the DB"
Aaron Schulz [Fri, 16 Sep 2016 02:33:52 +0000 (19:33 -0700)]
Add SearchEngineFactory::getSearchEngineClass() instead of using the DB
Change-Id: I46207cafec737cb830adc2bdf1b501a0d138b40d
jenkins-bot [Fri, 16 Sep 2016 03:07:28 +0000 (03:07 +0000)]
Merge "Split out ConvertableTimestamp class"
Aaron Schulz [Thu, 15 Sep 2016 22:46:01 +0000 (15:46 -0700)]
Split out ConvertableTimestamp class
* Make TimestampException a regular exception.
* Make DatabaseBase use ConvertableTimestamp.
Change-Id: I849737c9c187e8e0c6e080887ec0656e034f80d2
Aaron Schulz [Wed, 14 Sep 2016 20:07:22 +0000 (13:07 -0700)]
Fix $wgFileCache DB outage fallback
Change-Id: I5c41b4669ca29d119de5c08a2c61dbadae7cf55c
jenkins-bot [Fri, 16 Sep 2016 01:49:23 +0000 (01:49 +0000)]
Merge "Rephrase tooltip-rollback for clarity"
jenkins-bot [Fri, 16 Sep 2016 01:45:33 +0000 (01:45 +0000)]
Merge "API: Force straight join for prop=linkshere|transcludedin|fileusage"
jenkins-bot [Fri, 16 Sep 2016 01:44:00 +0000 (01:44 +0000)]
Merge "Make DB snapshot commit errors include active methods"
jenkins-bot [Fri, 16 Sep 2016 01:34:01 +0000 (01:34 +0000)]
Merge "mediawiki.user: Minor clean up of code and unit tests"
Timo Tijhof [Thu, 15 Sep 2016 04:01:09 +0000 (21:01 -0700)]
resourceloader: Move 'site' and 'user' logic to makeModuleResponse
* Keep this out of makeLoaderImplementScript() to keep it more generic
and to simplify future refactoring.
* Remove now-broken test case that asserted that the output varies
by global debug mode.
* Make the test responsible for wrapping in XmlJsCode. Previously
this magically happened because the module name was "user" in the
last test case.
* Make makeLoaderImplementScript protected. It's not used anywhere
outside ResourceLoader and we should keep it that way.
Test plan:
* Verify output unchanged:
- load.php?modules=user&only=scripts&user=Admin (raw code)
- load.php?modules=user&user=Admin (implement with unwrapped string)
- load.php?modules=jquery.client (implement with closure)
Change-Id: I527d01926fb6e4ce68c931695d830cdb9ceb608c
jenkins-bot [Fri, 16 Sep 2016 01:25:53 +0000 (01:25 +0000)]
Merge "Avoid global state in DatabaseBase::factory()/query()"
jenkins-bot [Fri, 16 Sep 2016 01:04:07 +0000 (01:04 +0000)]
Merge "Remove wfSetBit()/wfSetVar() calls in DatabaseBase"
Aaron Schulz [Thu, 15 Sep 2016 17:51:13 +0000 (10:51 -0700)]
Remove wfSetBit()/wfSetVar() calls in DatabaseBase
Change-Id: I4f1269d3a4e26c766f181208942042fdf768e0af
jenkins-bot [Fri, 16 Sep 2016 00:44:35 +0000 (00:44 +0000)]
Merge "Remove wfRandomString() dependency in DatabaseBase"
jenkins-bot [Fri, 16 Sep 2016 00:41:43 +0000 (00:41 +0000)]
Merge "Move LoadMonitorMySQL to LoadMonitor"
jenkins-bot [Fri, 16 Sep 2016 00:41:12 +0000 (00:41 +0000)]
Merge "Move database constants to their own file"
Aaron Schulz [Thu, 15 Sep 2016 09:21:21 +0000 (02:21 -0700)]
Avoid global state in DatabaseBase::factory()/query()
Change-Id: Ibb4f1c0dafea071a1c34e0cd5b5c15b8b4bb7bc6
Aaron Schulz [Wed, 14 Sep 2016 17:09:36 +0000 (10:09 -0700)]
Make DB snapshot commit errors include active methods
Change-Id: I59e501528b104e797b36103fa18792f539d92a14
Aaron Schulz [Thu, 15 Sep 2016 22:02:53 +0000 (15:02 -0700)]
Remove wfRandomString() dependency in DatabaseBase
Change-Id: I9a889e120bd665683e53dfbc8729a7c484ea507c
Timo Tijhof [Fri, 16 Sep 2016 00:05:25 +0000 (17:05 -0700)]
mediawiki.user: Minor clean up of code and unit tests
* Clarify getRegistration() return documentation and minor
optimisation of code order.
* Fix typo in test name for getUserInfo().
* Remove redundant test expect numbers.
Follows-up
7c363752ed.
* Separate getter assertions for anonymous and logged-in.
Avoid changing the fixture mid-test. Let setup/teardown
clean up in the middle.
Change-Id: If777d44a571ac590e91ed84060ea714df67f8f2f
Aaron Schulz [Thu, 15 Sep 2016 23:17:40 +0000 (16:17 -0700)]
Move database constants to their own file
Change-Id: I47e067687bbce7b89e02a0e732ee27368beddb61
jenkins-bot [Fri, 16 Sep 2016 00:21:43 +0000 (00:21 +0000)]
Merge "Remove wfGetCaller() dependency from DatabaseBase"
jenkins-bot [Fri, 16 Sep 2016 00:17:30 +0000 (00:17 +0000)]
Merge "resourceloader: Set a Title on context-created messages"
jenkins-bot [Fri, 16 Sep 2016 00:16:45 +0000 (00:16 +0000)]
Merge "Deprecate jquery.arrowSteps module"
Aaron Schulz [Thu, 15 Sep 2016 05:38:47 +0000 (22:38 -0700)]
Move LoadMonitorMySQL to LoadMonitor
* The LoadMonitor interface is now ILoadMonitor.
* Nothing in this code was MySQL specific.
Now any DB type can benefit from a LoadMonitor.
Change-Id: I272a72cd55a70f99a866d518d44cb3bcaca91b9e
jenkins-bot [Thu, 15 Sep 2016 23:09:45 +0000 (23:09 +0000)]
Merge "Infrastructure for augmenting search results"
Stanislav Malyshev [Tue, 26 Apr 2016 22:19:58 +0000 (15:19 -0700)]
Infrastructure for augmenting search results
Bug: T117493
Change-Id: Ia5413a7846cc961026a2dc3542b619493bc76a23
Kunal Mehta [Thu, 15 Sep 2016 22:41:11 +0000 (15:41 -0700)]
Add one more level for GlobalTitleFail logging
htmlspecialchars/Message->__toString/Message->toString/Message->parseText/MessageCache->parse
is useless without the caller of htmlspecialchars().
Change-Id: I2dad5a487225a11b98149610f1c775057f8baad2
Kunal Mehta [Thu, 15 Sep 2016 22:11:59 +0000 (15:11 -0700)]
resourceloader: Set a Title on context-created messages
Ensure that messages created using ResourceLoaderContext::msg() have a
title set so they don't trigger the GlobalTitleFail log. We use a dummy
title since there is no real title we can use here, and the cache
doesn't vary on a title anyways. This particular title was picked
especially for Roan.
This patch should quiet the GlobalTitleFail logs for
MFResourceLoaderParsedMessageModule and VisualEditorDataModule.
Change-Id: I502faa22776e1cb34a6ef17be96567f121c80081
Chad Horohoe [Wed, 7 Sep 2016 17:28:13 +0000 (10:28 -0700)]
EditPage: Generate all messages using $this->context so we have titles
Change-Id: I5ba13f1677e1a1b4160e14357a483b5e1f11ea1c
Aaron Schulz [Thu, 15 Sep 2016 21:40:00 +0000 (14:40 -0700)]
Remove wfGetCaller() dependency from DatabaseBase
Change-Id: I3e240b2eb5c1f6a21f1bc974c3d28f5755c7451a
jenkins-bot [Thu, 15 Sep 2016 21:38:10 +0000 (21:38 +0000)]
Merge "Replace WikiPage::doEdit() usages"
jenkins-bot [Thu, 15 Sep 2016 21:10:53 +0000 (21:10 +0000)]
Merge "Allow quotes in $wgDebugComments HTML comments"
L10n-bot [Thu, 15 Sep 2016 20:25:54 +0000 (20:25 +0000)]
Merge "Localisation updates from https://translatewiki.net."
Reedy [Thu, 15 Sep 2016 20:13:22 +0000 (21:13 +0100)]
Replace WikiPage::doEdit() usages
Update/add some comments
Bug: T145737
Change-Id: Ib3b2b69906074cbb51917dc57204c989fd6c58b2
jenkins-bot [Thu, 15 Sep 2016 20:23:27 +0000 (20:23 +0000)]
Merge "benchmarkParse: Add option to clear link cache"
jenkins-bot [Thu, 15 Sep 2016 20:20:32 +0000 (20:20 +0000)]
Merge "Emit deprecation warnigns for Article::getText()"
jenkins-bot [Thu, 15 Sep 2016 20:18:46 +0000 (20:18 +0000)]
Merge "Linker: Deprecate formatSize()"
Translation updater bot [Thu, 15 Sep 2016 20:18:46 +0000 (22:18 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ic6504bfa03dfb50c40231151255bc0297f28275c
Aaron Schulz [Thu, 15 Sep 2016 19:53:43 +0000 (12:53 -0700)]
Allow quotes in $wgDebugComments HTML comments
Change-Id: Id1fbab9ad3d6d645b6efea1d1e66a18ab4fe0b89
jenkins-bot [Thu, 15 Sep 2016 18:43:22 +0000 (18:43 +0000)]
Merge "Fix default "srvCache" BagOStuff in DatabaseBase"
jenkins-bot [Thu, 15 Sep 2016 18:19:14 +0000 (18:19 +0000)]
Merge "Dependency inject $wgSharedTables into DatabaseBase"
Aaron Schulz [Thu, 15 Sep 2016 17:07:47 +0000 (10:07 -0700)]
Dependency inject $wgSharedTables into DatabaseBase
Change-Id: I3e659b56c587d2059fc3d3f922bc38dec7685df4
Aaron Schulz [Thu, 15 Sep 2016 18:06:31 +0000 (11:06 -0700)]
Fix default "srvCache" BagOStuff in DatabaseBase
Follow up to
4660b56f
Change-Id: I19975ce66ddc318fd494d5c4a3807c62d04fad70
jenkins-bot [Thu, 15 Sep 2016 17:55:14 +0000 (17:55 +0000)]
Merge "Move updater/installer specific methods out of DatabaseBase"
jenkins-bot [Thu, 15 Sep 2016 17:39:35 +0000 (17:39 +0000)]
Merge "Rename LBFactory => LBFactoryMW and make LBFactory in /libs"
jenkins-bot [Thu, 15 Sep 2016 17:35:50 +0000 (17:35 +0000)]
Merge "docs: mw.widgets.CategorySelector: Fix example code"
Aaron Schulz [Wed, 14 Sep 2016 11:34:17 +0000 (04:34 -0700)]
Rename LBFactory => LBFactoryMW and make LBFactory in /libs
The former extends the later with MW-specific logic.
Also removed a wf* method call from ChronologyProtector.
Change-Id: I325f59b7467ab9c2137731d1ce69816f5a020f03
jenkins-bot [Thu, 15 Sep 2016 17:09:34 +0000 (17:09 +0000)]
Merge "Remove global state from DatabaseBase::__construct()"
jenkins-bot [Thu, 15 Sep 2016 16:52:10 +0000 (16:52 +0000)]
Merge "Move Linker::formatTemplates() to separate class, remove global usage"
jenkins-bot [Thu, 15 Sep 2016 16:39:36 +0000 (16:39 +0000)]
Merge "Fix broken wincache merge() implementation"
jenkins-bot [Thu, 15 Sep 2016 16:39:32 +0000 (16:39 +0000)]
Merge "OutputPage: Don't set 'user' module state if filtered out"
jenkins-bot [Thu, 15 Sep 2016 16:36:51 +0000 (16:36 +0000)]
Merge "Revert "Remove jquery.arrowSteps module""
Bartosz Dziewoński [Thu, 15 Sep 2016 16:29:14 +0000 (16:29 +0000)]
Deprecate jquery.arrowSteps module
Bug: T144974
Change-Id: I765902082e6a71ca69983a2e67dcc856ad8b6ca8
Bartosz Dziewoński [Thu, 15 Sep 2016 16:28:42 +0000 (16:28 +0000)]
Revert "Remove jquery.arrowSteps module"
It should probably be deprecated first after all.
This reverts commit
6fba9a7dc6ac969676c57f85b09bbdac9067a2bd.
Bug: T144974
Change-Id: I830fbfc2e453be6b18d43775a8aa1a366690907c
jenkins-bot [Thu, 15 Sep 2016 13:02:29 +0000 (13:02 +0000)]
Merge "Set fallback language for lzh to zh-hant"
Niklas Laxström [Mon, 2 Jun 2014 18:34:52 +0000 (18:34 +0000)]
PrefixSearch: Implement searching in multiple namespaces
I thought there was just an issue with capitalization, but in fact the
code explicitly only searched one namespace anyway. Fixed that while
taking capitalization differences in namespaces into account.
This by extend also brings support for multiple namespaces to the
opensearch API.
Follows-up I3487bb69.
Bug: T67752
Bug: T32323
Change-Id: I4bec7b5548fc27ac51a1b4d4961c3bbc31eb7337
zppix1 [Thu, 11 Aug 2016 21:31:17 +0000 (16:31 -0500)]
Change wording, change grammar in lang/en.json
Bug: T142756
Depends-On: I233ce58fd82a1dbc57b3ab58ce669b23a5781b57
Change-Id: I164d397d6ea41ea6b88bb0d84604b52419dadd0f
Aaron Schulz [Thu, 15 Sep 2016 11:50:25 +0000 (04:50 -0700)]
Fix broken wincache merge() implementation
Bug: T145664
Change-Id: I2f841779108df281e24003c586775b71aa176909
zppix1 [Sat, 30 Jul 2016 23:06:28 +0000 (18:06 -0500)]
Cleaned up some un needed wording in the English i18n file
Changed messages:
* noindex-category
* morenotlisted
Change-Id: I233ce58fd82a1dbc57b3ab58ce669b23a5781b57
Aaron Schulz [Thu, 15 Sep 2016 11:22:57 +0000 (04:22 -0700)]
Remove global state from DatabaseBase::__construct()
Change-Id: Iba347fce8f0f531aa7e565bb8806260bcbf04a98
MarcoAurelio [Tue, 2 Aug 2016 09:27:55 +0000 (11:27 +0200)]
Set fallback language for lzh to zh-hant
Bug: T125373
Change-Id: Ie39d03efce0997c928ac0bc7f4a97ee8e047df45
Aaron Schulz [Thu, 15 Sep 2016 09:25:16 +0000 (02:25 -0700)]
Move updater/installer specific methods out of DatabaseBase
Change-Id: I995799fc15d2797ce7ab9ce2aca8beeef409447c
Kunal Mehta [Thu, 15 Sep 2016 08:45:43 +0000 (01:45 -0700)]
Emit deprecation warnigns for Article::getText()
Deprecated since 1.21.
Bug: T145747
Change-Id: I6fe620702fcc455dbe229abca1145b0c8ea3f8d2
Kunal Mehta [Thu, 15 Sep 2016 06:55:35 +0000 (23:55 -0700)]
benchmarkParse: Add option to clear link cache
For performance testing the lookup of links (e.g. LinkHolderArray),
allow resetting the LinkCache after every parse.
Change-Id: I75c2cad9a8cf1b41d192708773194f799673ce83
Aaron Schulz [Thu, 15 Sep 2016 05:02:43 +0000 (22:02 -0700)]
Remove unused LBFactoryFake class
Change-Id: I88acf72fc32c7e3c9bead81d11c5adfd8dff6151
jenkins-bot [Thu, 15 Sep 2016 04:26:27 +0000 (04:26 +0000)]
Merge "Avoid MWException and wf* log methods in DatabaseBase"
Aaron Schulz [Thu, 15 Sep 2016 01:37:35 +0000 (18:37 -0700)]
Avoid MWException and wf* log methods in DatabaseBase
Change-Id: Idc418ae1088f87d6416e2552976d94f7d1e8f5db
Aaron Schulz [Wed, 14 Sep 2016 10:11:41 +0000 (03:11 -0700)]
Move various DB helper classes to /libs/rdbms
Change-Id: I0724f1acce4f6c43b1f0983fa119e628e7c53ba5
Aaron Schulz [Wed, 14 Sep 2016 09:40:29 +0000 (02:40 -0700)]
Move LoadBalancer to /libs/rdbms
Change-Id: Ic87f1cc84ba44be20f345944406e1d8a34be1c96
Aaron Schulz [Thu, 15 Sep 2016 02:04:21 +0000 (19:04 -0700)]
Change DatabaseBase => IDatabase in /db where possible
Change-Id: Ia0a049cd4294c5a39aa9ed228d4eb5b15736ea1f
jenkins-bot [Thu, 15 Sep 2016 02:24:05 +0000 (02:24 +0000)]
Merge "Change $wiki => $domain in LoadBalancer"
jenkins-bot [Thu, 15 Sep 2016 02:19:03 +0000 (02:19 +0000)]
Merge "Exception cleanups for LoadBalancer"
Aaron Schulz [Thu, 15 Sep 2016 02:13:41 +0000 (19:13 -0700)]
Change $wiki => $domain in LoadBalancer
Change-Id: I97f96383c501e9b3262c11d143795b82ae36aca5
Timo Tijhof [Wed, 14 Sep 2016 22:51:05 +0000 (15:51 -0700)]
phpunit: Simplify mock object syntax in includes/db/ tests
* Omit redundant `expects( $this->any() )`.
* Use willReturn() instead of `will( $this->returnValue() )`.
Change-Id: If90ac651748af8a78a720992240e40ba53cec79c
Aaron Schulz [Wed, 14 Sep 2016 09:28:18 +0000 (02:28 -0700)]
Exception cleanups for LoadBalancer
* Make the error message itself be dumb/raw.
* Make the exception exposer show the same GUI message.
* Remove overzelous wgLang check in MWExceptionRenderer.
Change-Id: Ifffff3b3cc785ea3080e4975efe33b3c2cf304d6
jenkins-bot [Thu, 15 Sep 2016 00:46:03 +0000 (00:46 +0000)]
Merge "Move DBConnRef and ChronologyProtector to /libs/rdbms"
jenkins-bot [Thu, 15 Sep 2016 00:43:34 +0000 (00:43 +0000)]
Merge "Move TransactionProfiler to /libs/rdbms"
jenkins-bot [Thu, 15 Sep 2016 00:31:04 +0000 (00:31 +0000)]
Merge "Make WikiPage::getRevision() make use of Revision::newKnownCurrent()"
Aaron Schulz [Wed, 14 Sep 2016 09:21:18 +0000 (02:21 -0700)]
Move DBConnRef and ChronologyProtector to /libs/rdbms
Change-Id: If2c4b314a5c39311328843f534d91bf90823e179
jenkins-bot [Thu, 15 Sep 2016 00:15:15 +0000 (00:15 +0000)]
Merge "More DB related class cleanups to prepare files for /libs"
jenkins-bot [Thu, 15 Sep 2016 00:09:16 +0000 (00:09 +0000)]
Merge "Re-add parser tests to the ParserTests group"
jenkins-bot [Thu, 15 Sep 2016 00:09:12 +0000 (00:09 +0000)]
Merge "Fix broken select() call in rebuildFileCache.php"
Aaron Schulz [Wed, 14 Sep 2016 07:22:35 +0000 (00:22 -0700)]
More DB related class cleanups to prepare files for /libs
* Cleaned up some related logging bits.
* Avoid some wf* methods in LoadBalancer.
Change-Id: I5da97174441c086e61ffc120889c068e241ebfd2
Aaron Schulz [Wed, 14 Sep 2016 23:57:54 +0000 (16:57 -0700)]
Make WikiPage::getRevision() make use of Revision::newKnownCurrent()
Change-Id: Id06319b31bc523a5d514930c3d609af4d991453b