jenkins-bot [Fri, 29 Dec 2017 00:20:56 +0000 (00:20 +0000)]
Merge "[MCR] pass $queryFlags into RevisionStore::getTitle"
jenkins-bot [Thu, 28 Dec 2017 23:48:21 +0000 (23:48 +0000)]
Merge "Remove leading backslashes from "use \…" tags"
jenkins-bot [Thu, 28 Dec 2017 16:53:39 +0000 (16:53 +0000)]
Merge "Add @covers tags API tests without them"
jenkins-bot [Thu, 28 Dec 2017 16:47:45 +0000 (16:47 +0000)]
Merge "Add @covers tags to languages tests"
jenkins-bot [Thu, 28 Dec 2017 16:45:17 +0000 (16:45 +0000)]
Merge "Add @covers tags to miscellaneous tests (#2)"
jenkins-bot [Thu, 28 Dec 2017 16:39:10 +0000 (16:39 +0000)]
Merge "Add @coversNothing in places where @covers does not apply"
Fomafix [Thu, 21 Apr 2016 05:39:08 +0000 (05:39 +0000)]
Simplify autocomplete attribute in HTMLForm
Follows-up
7489a3e8
Change-Id: Ifb17c88e39df7031054b3bee83772172c64d0a6b
Thiemo Mättig [Thu, 28 Dec 2017 15:30:05 +0000 (16:30 +0100)]
Remove leading backslashes from "use \…" tags
Change-Id: I494b029de089a07e3b946ee78293a12d5036f63e
addshore [Thu, 28 Dec 2017 13:14:39 +0000 (13:14 +0000)]
[MCR] pass $queryFlags into RevisionStore::getTitle
Bug: T183716
Bug: T183717
Bug: T183505
Change-Id: I15e4663902e2cbfe15b0da2e46449330e313bd0d
jenkins-bot [Thu, 28 Dec 2017 11:08:09 +0000 (11:08 +0000)]
Merge "Add @covers tags to database tests"
jenkins-bot [Thu, 28 Dec 2017 11:05:51 +0000 (11:05 +0000)]
Merge "tests: Complete test coverage of HtmlArmor"
jenkins-bot [Thu, 28 Dec 2017 10:42:14 +0000 (10:42 +0000)]
Merge "Remove useless StatusTest::testCanConstruct()"
jenkins-bot [Thu, 28 Dec 2017 10:40:10 +0000 (10:40 +0000)]
Merge "Remove resolved todo from MWNamespace test"
jenkins-bot [Thu, 28 Dec 2017 10:34:47 +0000 (10:34 +0000)]
Merge "Improve @covers for TemplateParserTest"
jenkins-bot [Thu, 28 Dec 2017 09:59:10 +0000 (09:59 +0000)]
Merge "make 7zip wrapper usable for dumping text revisions again"
jenkins-bot [Thu, 28 Dec 2017 09:44:58 +0000 (09:44 +0000)]
Merge "Change php extract() to explicit code"
jenkins-bot [Thu, 28 Dec 2017 09:37:47 +0000 (09:37 +0000)]
Merge "Add HTML attributes lang and dir to toctitle"
jenkins-bot [Thu, 28 Dec 2017 09:22:01 +0000 (09:22 +0000)]
Merge "maintenance: Add unit test for Benchmarker class"
Kunal Mehta [Thu, 28 Dec 2017 03:22:51 +0000 (19:22 -0800)]
tests: Complete test coverage of HtmlArmor
Change-Id: I3c50ea56721226ddb37bcf4778a7d71e9b56d0f7
Kunal Mehta [Thu, 28 Dec 2017 08:38:21 +0000 (00:38 -0800)]
Add @coversNothing in places where @covers does not apply
These tests apply to things that are not relevant to PHP code coverage,
such as testing presence of messages, JSON files, or the PHPUnit tests
themselves.
Using @coversNothing indicates that there is no code here to be covered,
and prevents warnings when using --strict-coverage mode (T152923).
Change-Id: Id89ee2c15a3ce3f10e34b13fb677cd1af75af9e6
Kunal Mehta [Thu, 28 Dec 2017 08:31:08 +0000 (00:31 -0800)]
Improve @covers for TemplateParserTest
The current @covers tags for TemplateParserTest are an incomplete call
stack for TemplateParser::processTemplate, and miss out on some
functions that are called. Those functions could be repeated in @covers
tags, but it would be burdensome to keep it up to date.
Instead, just use class level @covers for the whole test case. This also
takes care of the previously uncovered testEnableRecursivePartials().
Change-Id: I475ceba26b70a115b40d7735834a07f298f7bf99
Kunal Mehta [Thu, 28 Dec 2017 08:28:45 +0000 (00:28 -0800)]
Add @covers tags to database tests
Change-Id: Ic46bb961b41856d390ffe0e3632790c506f5655b
Kunal Mehta [Thu, 28 Dec 2017 08:27:40 +0000 (00:27 -0800)]
Remove resolved todo from MWNamespace test
The todo was added by Addshore in
aea1b27db02 at the same time he added
all the @covers tags, so it appears to all be resolved.
Change-Id: I03d866fdd1ca382ca2b1699e01a0dd9a28eef1ec
Kunal Mehta [Thu, 28 Dec 2017 08:25:25 +0000 (00:25 -0800)]
Remove useless StatusTest::testCanConstruct()
Neither Status, nor StatusValue have constructors, so there's not much
point testing whether the object can be constructed.
Change-Id: I170940889b5da5198ef4576d04786f84c293dd01
Kunal Mehta [Thu, 28 Dec 2017 08:24:40 +0000 (00:24 -0800)]
Add @covers tags to languages tests
I removed comments that merely repeated the location of the class being
tested. There are other tests in this directory that don't have a
corresponding class and need further investigation.
Change-Id: Ic16f0887b5030ac53fab4382cfaedfb5426cdb08
Kunal Mehta [Thu, 28 Dec 2017 08:22:35 +0000 (00:22 -0800)]
Add @covers tags to miscellaneous tests (#2)
Change-Id: I9116598bee4f4917e02290d273644c13475ff721
Translation updater bot [Thu, 28 Dec 2017 08:04:14 +0000 (09:04 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Icc11f7ae67c7a70f4c59eec632c74926700a69c9
Timo Tijhof [Wed, 27 Dec 2017 20:44:38 +0000 (21:44 +0100)]
maintenance: Add unit test for Benchmarker class
Change-Id: I3f835fc07741fd42b8adb5b019f72589429cc14f
jenkins-bot [Wed, 27 Dec 2017 22:04:37 +0000 (22:04 +0000)]
Merge "phpunit: Remove outdated comment about calling of LinkCache::clear()"
jenkins-bot [Wed, 27 Dec 2017 21:39:36 +0000 (21:39 +0000)]
Merge "mw.rcfilters.ui.SaveFiltersPopupButtonWidget: Remove pointless option"
jenkins-bot [Wed, 27 Dec 2017 21:14:54 +0000 (21:14 +0000)]
Merge "Add grep comment for js vars wgRestriction*"
Timo Tijhof [Wed, 27 Dec 2017 20:52:44 +0000 (21:52 +0100)]
phpunit: Remove outdated comment about calling of LinkCache::clear()
This is actually being called now, from resetDB() between tests.
Change-Id: I5aa15ce3fd57b6fc90b424fde8691ff33c7ddf45
Fomafix [Fri, 29 May 2015 17:07:55 +0000 (17:07 +0000)]
Add HTML attributes lang and dir to toctitle
The toctitle is in user interface language. This change add the
HTML attributes lang and dir to the toctitle.
This allows to copy (a part of) the rendered HTML to a word processing
and the language for spell checking has the right language.
Change-Id: I17730869f81744560672d7d0acb67ced71e69c4e
Kunal Mehta [Sun, 24 Dec 2017 23:44:36 +0000 (15:44 -0800)]
Add @covers tags API tests without them
Change-Id: Ida0f954cb0a44719af3a3d0c6bda4587c9ca42b6
Kunal Mehta [Mon, 25 Dec 2017 01:35:00 +0000 (17:35 -0800)]
Add tests for TextboxBuilder
Change-Id: I305e0bce902fb027bf02cc8a28e8846808f6437c
Kunal Mehta [Mon, 25 Dec 2017 01:08:48 +0000 (17:08 -0800)]
Add @covers tags to ContentHandler tests
Change-Id: I4d0994e91f63a0921343f34ef81a82463b4ab969
Kunal Mehta [Mon, 25 Dec 2017 04:06:06 +0000 (20:06 -0800)]
Add @covers tags to jobqueue tests
Change-Id: I030634ac87139011e5b3d461064a8c10f10cea84
Kunal Mehta [Mon, 25 Dec 2017 04:05:52 +0000 (20:05 -0800)]
Add @covers tags to HTMLForm test
Change-Id: I41cc4867b071ee9a58a43760fc4a8b301cda558e
Kunal Mehta [Mon, 25 Dec 2017 04:05:41 +0000 (20:05 -0800)]
Add @covers tags to filerepo tests
Change-Id: I696e03f9ab3934b6cd04e88e1d611060846d32a4
Kunal Mehta [Mon, 25 Dec 2017 04:04:47 +0000 (20:04 -0800)]
Add @covers tags to LinksUpdate test
Change-Id: I65ebce434f00a42e06be5168acbaa8fbf637995f
Kunal Mehta [Mon, 25 Dec 2017 04:04:36 +0000 (20:04 -0800)]
Add @covers tags to includes/debug tests
Change-Id: Ida6562c87204f1680239d0bdbfde4d6fdc9bf748
Kunal Mehta [Mon, 25 Dec 2017 04:04:11 +0000 (20:04 -0800)]
Add @covers tags for RevisionStoreDbTest
Change-Id: Ie7ce23d5ad67816c1ae8c2c838f8263fca17b4f8
jenkins-bot [Wed, 27 Dec 2017 17:40:44 +0000 (17:40 +0000)]
Merge "Add @covers tags to miscellaneous tests"
jenkins-bot [Wed, 27 Dec 2017 17:36:14 +0000 (17:36 +0000)]
Merge "Add @covers tags to utils tests"
jenkins-bot [Wed, 27 Dec 2017 17:36:11 +0000 (17:36 +0000)]
Merge "Add @covers tags to user tests"
jenkins-bot [Wed, 27 Dec 2017 17:30:27 +0000 (17:30 +0000)]
Merge "Add @covers tags to specials tests"
jenkins-bot [Wed, 27 Dec 2017 17:27:02 +0000 (17:27 +0000)]
Merge "Add @covers tags to parser tests"
jenkins-bot [Wed, 27 Dec 2017 17:26:59 +0000 (17:26 +0000)]
Merge "Add @covers tags to page tests"
jenkins-bot [Wed, 27 Dec 2017 17:19:57 +0000 (17:19 +0000)]
Merge "Add @covers tags to objectcache tests"
jenkins-bot [Wed, 27 Dec 2017 17:19:28 +0000 (17:19 +0000)]
Merge "Add @covers tags to media tests"
jenkins-bot [Wed, 27 Dec 2017 17:19:25 +0000 (17:19 +0000)]
Merge "Add @covers tags to logging tests"
Thiemo Mättig [Wed, 27 Dec 2017 11:40:19 +0000 (12:40 +0100)]
Document "arrays of UserGroupMembership objects" as such
Change-Id: I3c60fb977a329e39933d50e275a738296bc17599
jenkins-bot [Wed, 27 Dec 2017 12:51:53 +0000 (12:51 +0000)]
Merge "Simplify ApiQueryRecentChangesIntegrationTest"
jenkins-bot [Wed, 27 Dec 2017 12:33:27 +0000 (12:33 +0000)]
Merge "Integration tests for ApiQueryRecentChanges"
Thiemo Mättig [Wed, 27 Dec 2017 12:23:17 +0000 (13:23 +0100)]
Simplify ApiQueryRecentChangesIntegrationTest
This patch does two major things to the newly introduced
ApiQueryRecentChangesIntegrationTest:
* It rips the confusingly complicated assertArraySubsetsEqual appart.
* It removes all wikitext content. Note that no assertion is done on this
content (not even in the test that is about adding a category). The tests
run just fine with automatically generated content. I had to introduce the
$i counter to make sure consecutive edits are done with different content.
Otherwise the later edit is not stored.
Change-Id: Iae585be86f3fd9bff7d2b4b7b218d5b0b4258603
James D. Forrester [Mon, 27 Nov 2017 23:44:40 +0000 (15:44 -0800)]
resources: Upgrade jquery.chosen from 0.9.14 to 1.8.2
Change-Id: If9c720ebca8ca663869d0f73b0cd3ea415262cff
Thiemo Mättig [Wed, 27 Dec 2017 11:33:38 +0000 (12:33 +0100)]
Fix inconsistent capitalization of different method calls
Change-Id: I9f5b9e59e8cdadf65e80077fe2d3a9822b4592fe
Umherirrender [Wed, 27 Dec 2017 02:04:45 +0000 (03:04 +0100)]
Add grep comment for js vars wgRestriction*
Change-Id: I974841acf97e9426ed2338f210821e91d7f94286
jenkins-bot [Wed, 27 Dec 2017 10:38:08 +0000 (10:38 +0000)]
Merge "Special:ProtectedPages: Use HTMLForm"
Prateek Saxena [Fri, 8 Sep 2017 12:57:07 +0000 (22:57 +1000)]
Special:ProtectedPages: Use HTMLForm
We could easily get rid of functions like getExpiryCheck
and getCascadeCheck if required.
Bug: T117722
Change-Id: Ia964192b50464ebec00e0812e14b804fe91132ca
Translation updater bot [Wed, 27 Dec 2017 09:01:20 +0000 (10:01 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I9f3aca4cca70f4e0d747eeec0020948298cc14fc
Translation updater bot [Tue, 26 Dec 2017 09:00:05 +0000 (10:00 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I495ab349530db87303fc33f06b2610681ba3efc5
Kunal Mehta [Mon, 25 Dec 2017 03:13:51 +0000 (19:13 -0800)]
tests: Use checkPHPExtension() instead of re-implementing it
Change-Id: I7f5e8684d556befc0aefa302187c573e7a3cff62
Kunal Mehta [Mon, 25 Dec 2017 03:10:14 +0000 (19:10 -0800)]
Add @covers tags for Collation tests
Change-Id: I8b0623a6b716acdc9d369349fd4e306dbdc91d18
Amir Sarabadani [Mon, 25 Dec 2017 02:41:49 +0000 (03:41 +0100)]
Integration tests for ApiQueryRecentChanges
It looks big but it's mostly copy from ApiQueryWatchlistIntegrationTest
Change-Id: I96ccd3e2813e77f47a4432ca434c1c6a212d90ea
Translation updater bot [Mon, 25 Dec 2017 08:31:53 +0000 (09:31 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I69b50503f8a9db7b3883f664f2703ab16f9132dc
Kunal Mehta [Mon, 25 Dec 2017 07:28:03 +0000 (23:28 -0800)]
Add @covers tags to miscellaneous tests
Change-Id: I7e65c1734aef01cd6395ee65204a0158d1635b0c
Kunal Mehta [Mon, 25 Dec 2017 07:27:22 +0000 (23:27 -0800)]
Add @covers tags to utils tests
Change-Id: Iee44762696120c63fec986de1da76f12849f5957
Kunal Mehta [Mon, 25 Dec 2017 07:27:12 +0000 (23:27 -0800)]
Add @covers tags to user tests
Change-Id: I9ec5644e6b780937492eb5e0ea9e27ebad15ad43
Kunal Mehta [Mon, 25 Dec 2017 07:27:02 +0000 (23:27 -0800)]
Add @covers tags to specials tests
Change-Id: I626155b890580af38c09795b2b31f625fe942358
Kunal Mehta [Mon, 25 Dec 2017 07:26:52 +0000 (23:26 -0800)]
Add @covers tags to parser tests
Change-Id: I7bce04bef5e981fd203ad819882482e72ca3f61b
Kunal Mehta [Mon, 25 Dec 2017 07:26:41 +0000 (23:26 -0800)]
Add @covers tags to page tests
Change-Id: Iadb7e8697e9992ca281b7dfe70cf832c82e194de
Kunal Mehta [Mon, 25 Dec 2017 07:26:26 +0000 (23:26 -0800)]
Add @covers tags to objectcache tests
Change-Id: I5db623a582a0424f50d939aaa14fe29da9358b4f
Kunal Mehta [Mon, 25 Dec 2017 07:26:10 +0000 (23:26 -0800)]
Add @covers tags to media tests
Change-Id: Ibd3439f677dec5177b53317f113ed2aa8ddc2633
Kunal Mehta [Mon, 25 Dec 2017 07:26:01 +0000 (23:26 -0800)]
Add @covers tags to logging tests
Change-Id: Ibb14291a75423ddbb7502a5a0ee24ff0c554a876
jenkins-bot [Mon, 25 Dec 2017 03:27:42 +0000 (03:27 +0000)]
Merge "Allow fallbacks for $wgReferrerPolicy"
Kunal Mehta [Mon, 25 Dec 2017 03:16:26 +0000 (19:16 -0800)]
Fix @covers in XmlTest
Follows up
389fa13ff875.
Change-Id: I32ddf37b24a6b5162b383260233d616cb49f7ddb
Amir Sarabadani [Mon, 25 Dec 2017 01:54:25 +0000 (02:54 +0100)]
Add tests for several methods of Xml
Added tests for methods: monthSelector, span, buildTable, buildTableRow
Change-Id: I5ca6bb231b5ed95f57f649a92d659245a4852c85
jenkins-bot [Sun, 24 Dec 2017 23:42:56 +0000 (23:42 +0000)]
Merge "[MCR] Don't require $title to be passed to Revision::newFromId"
jenkins-bot [Sun, 24 Dec 2017 23:39:58 +0000 (23:39 +0000)]
Merge "[MCR] Introduce BlobStoreFactory"
jenkins-bot [Sun, 24 Dec 2017 23:38:57 +0000 (23:38 +0000)]
Merge "Add `margin-bottom` for editButtons (EditPage)"
Kunal Mehta [Sun, 24 Dec 2017 23:23:49 +0000 (15:23 -0800)]
Add @covers tags to CategoriesRdfTest
Change-Id: I6e2eae3fc2ac722dc94bee1a7aa6632e08a4d097
addshore [Sat, 23 Dec 2017 17:14:28 +0000 (17:14 +0000)]
[MCR] Introduce BlobStoreFactory
This allows Revision::getRevisionText to get
a different BlobStore instance when $wiki is passed in
restoring the behaviour for $wiki before the MCR Revision
overhaul patch was merged.
Ia4c20a91e98df0b9b14b138eb4825c55e5200384
Bug: T183634
Bug: T183631
bug: T183583
Change-Id: Ib0949454e9a003c2965adc1aab38e31fcf121afe
Gergő Tisza [Sat, 23 Dec 2017 17:35:59 +0000 (09:35 -0800)]
Allow fallbacks for $wgReferrerPolicy
For browsers that support older versions of the Referrer Policy
specification (Edge and Safari), using a value from a newer version of
the specification will result in those browsers falling back to a
default of "default".
So allow $wgReferrerPolicy to have fallbacks if the browser does not
recognize the currently set value. It will emit <meta> tags for each
value in the array, but in reverse order, as browsers will use the last
one that they recognize.
Bug: T180921
Change-Id: Ie0f523fc6937c9ecffc8a6fc791c6b54d5a1cb06
jenkins-bot [Sun, 24 Dec 2017 22:56:00 +0000 (22:56 +0000)]
Merge "Improve documentation of $wgReferrerPolicy"
jenkins-bot [Sun, 24 Dec 2017 21:57:01 +0000 (21:57 +0000)]
Merge "JavaScriptMinifier: Improve docs around parsing of regexp literals"
jenkins-bot [Sun, 24 Dec 2017 21:54:45 +0000 (21:54 +0000)]
Merge "JavaScriptMinifier: Remove support for unused $statementsOnOwnLine flag"
Timo Tijhof [Fri, 22 Dec 2017 18:00:42 +0000 (19:00 +0100)]
JavaScriptMinifier: Improve docs around parsing of regexp literals
Bug: T75556
Change-Id: Ifcb6bc21418dfc2e1d3e44dbd2497a0f5f691bf3
Phantom42 [Wed, 20 Dec 2017 15:18:55 +0000 (17:18 +0200)]
Add `margin-bottom` for editButtons (EditPage)
Bug: T179040
Change-Id: I9e6c04556e4ff7f0cc567877041449f50abf4b4c
jenkins-bot [Sun, 24 Dec 2017 15:01:11 +0000 (15:01 +0000)]
Merge "Remove duplicate ServiceWiring definitions"
Translation updater bot [Sat, 23 Dec 2017 20:55:31 +0000 (21:55 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I26ca1588d1f8063a673809759e5b05728e4dc550
addshore [Sat, 23 Dec 2017 17:16:09 +0000 (17:16 +0000)]
Remove duplicate ServiceWiring definitions
Change-Id: I70b377c417ce6937e5d52d1790cf0b6f2ed33c15
jenkins-bot [Sat, 23 Dec 2017 12:08:42 +0000 (12:08 +0000)]
Merge "Set wgCommentTableSchemaMigrationStage in RevisionStoreTest"
addshore [Fri, 22 Dec 2017 17:32:54 +0000 (17:32 +0000)]
[MCR] Don't require $title to be passed to Revision::newFromId
If the title is not passed in as a param (already known) then select
it in Revision::newFromId instead of waiting for it to be selected
further down the tree.
This means that we can use the same Title object to pass into the
RevisionRecord as well as our legacy Revision object.
The selection chooses either a slave or master depending on
recent writes.
This logic used to be in Revision::getTitle and also in
Revision::newFromConds which was called by newFromId
Bug: T183505
Change-Id: I9cf4ce2c3c86d6bf979a3c88eb423b942b9a1ba4
Ariel T. Glenn [Fri, 22 Dec 2017 20:56:28 +0000 (22:56 +0200)]
make 7zip wrapper usable for dumping text revisions again
Change-Id: Ic9c5ad284b542c15f4ab48b5459f00e188a4301a
Gergő Tisza [Sun, 19 Nov 2017 22:19:44 +0000 (14:19 -0800)]
Improve documentation of $wgReferrerPolicy
Reference current version of the spec.
Change-Id: I1cca89b9e46a2b5ae8242715eddfdbd23ccb2d83
Umherirrender [Fri, 22 Dec 2017 22:40:57 +0000 (23:40 +0100)]
Update reference to DatabaseBase in hooks.txt
Change-Id: I65f84c0deadb611380e17a5b1b7593876894c099
Translation updater bot [Fri, 22 Dec 2017 20:59:32 +0000 (21:59 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I1edcc9b4af56fb6b66961a14e38d878ff97843e9
jenkins-bot [Fri, 22 Dec 2017 20:39:09 +0000 (20:39 +0000)]
Merge "RCLFilters: support longer page names"
jenkins-bot [Fri, 22 Dec 2017 18:46:27 +0000 (18:46 +0000)]
Merge "resourceloader: Improve JavaScriptMinifier code coverage"