Improvement for r70521: simplification, avoid iterating over an array. Thanks, thedj!

diff --git a/skins/common/password.js b/skins/common/password.js
index 990b270..167e3d8 100644 (file)
--- a/skins/common/password.js
+++ b/skins/common/password.js
@@ -31,15 +31,9 @@ function bruteForceComplexity( pwd ) {
        if ( matches ) {
                charClasses++;
                
+               var s = matches.join( '' );
                // poor man's isUpper() and isLower()
-               var i, lower = false, upper = false;
-               for ( i in matches ) {
-                       var ch = matches[i];
-                       upper |= ch != ch.toLowerCase();
-                       lower |= ch != ch.toUpperCase();
-                       if ( upper && lower ) break;
-               }
-               if ( upper && lower ) {
+               if ( s != s.toLowerCase() && s != s.toUpperCase() ) {
                        charClasses++;
                }
        }