Use a regex when checking for external urls. It's concise and DRY, less prone to...

diff --git a/resources/mediawiki/mediawiki.js b/resources/mediawiki/mediawiki.js
index 6f9e789..48b024b 100644 (file)
--- a/resources/mediawiki/mediawiki.js
+++ b/resources/mediawiki/mediawiki.js
@@ -1071,7 +1071,7 @@ window.mw = window.mediaWiki = new ( function( $ ) {
                        // Allow calling with an external script or single dependency as a string
                        if ( typeof modules === 'string' ) {
                                // Support adding arbitrary external scripts
-                               if ( modules.substr( 0, 7 ) === 'http://' || modules.substr( 0, 8 ) === 'https://' || modules.substr( 0, 2 ) === '//' ) {
+                               if ( /^(https?:)?\/\//.test( modules ) ) {
                                        if ( type === 'text/css' ) {
                                                $( 'head' ).append( $( '<link/>', {
                                                        rel: 'stylesheet',